Skip to content

Commit 53f2d72

Browse files
authored
Revert certain double quotes from workflow shell script (#14939)
Follow-up from #14938
1 parent 3629cbf commit 53f2d72

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.github/workflows/build-docker.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,8 @@ jobs:
143143
# The final command becomes `docker buildx imagetools create -t tag1 -t tag2 ... <RUFF_BASE_IMG>@sha256:<sha256_1> <RUFF_BASE_IMG>@sha256:<sha256_2> ...`
144144
run: |
145145
docker buildx imagetools create \
146-
"$(jq -cr '.tags | map("-t " + .) | join(" ")' <<< "$DOCKER_METADATA_OUTPUT_JSON")" \
147-
"$(printf "${RUFF_BASE_IMG}@sha256:%s " *)"
146+
$(jq -cr '.tags | map("-t " + .) | join(" ")' <<< "$DOCKER_METADATA_OUTPUT_JSON") \
147+
$(printf "${RUFF_BASE_IMG}@sha256:%s " *)
148148
149149
docker-publish-extra:
150150
name: Publish additional Docker image based on ${{ matrix.image-mapping }}
@@ -288,5 +288,5 @@ jobs:
288288
readarray -t lines <<< "$DOCKER_METADATA_OUTPUT_ANNOTATIONS"; annotations=(); for line in "${lines[@]}"; do annotations+=(--annotation "$line"); done
289289
docker buildx imagetools create \
290290
"${annotations[@]}" \
291-
"$(jq -cr '.tags | map("-t " + .) | join(" ")' <<< "$DOCKER_METADATA_OUTPUT_JSON")" \
292-
"$(printf "${RUFF_BASE_IMG}@sha256:%s " *)"
291+
$(jq -cr '.tags | map("-t " + .) | join(" ")' <<< "$DOCKER_METADATA_OUTPUT_JSON") \
292+
$(printf "${RUFF_BASE_IMG}@sha256:%s " *)

.github/workflows/release.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -268,9 +268,9 @@ jobs:
268268
RELEASE_COMMIT: "${{ github.sha }}"
269269
run: |
270270
# Write and read notes from a file to avoid quoting breaking things
271-
echo "$ANNOUNCEMENT_BODY" > "$RUNNER_TEMP/notes.txt"
271+
echo "$ANNOUNCEMENT_BODY" > $RUNNER_TEMP/notes.txt
272272
273-
gh release create "${{ needs.plan.outputs.tag }}" --target "$RELEASE_COMMIT" "$PRERELEASE_FLAG" --title "$ANNOUNCEMENT_TITLE" --notes-file "$RUNNER_TEMP/notes.txt" artifacts/*
273+
gh release create "${{ needs.plan.outputs.tag }}" --target "$RELEASE_COMMIT" $PRERELEASE_FLAG --title "$ANNOUNCEMENT_TITLE" --notes-file "$RUNNER_TEMP/notes.txt" artifacts/*
274274
275275
custom-notify-dependents:
276276
needs:

0 commit comments

Comments
 (0)