Add rule removal infrastructure

Removes PLR1706 for testing

Author: zanieb

crates/ruff/tests/integration_test.rs

@@ -1049,6 +1049,21 @@ fn preview_enabled_group_ignore() {
     "###);
 }
 
+#[test]
+fn removed_direct() {
+    // Selection of a removed rule should fail
+    let mut cmd = RuffCheck::default().args(["--select", "PLR1706"]).build();
+    assert_cmd_snapshot!(cmd, @r###"
+    success: false
+    exit_code: 2
+    ----- stdout -----
+
+    ----- stderr -----
+    ruff failed
+      Cause: Rule `PLR1706` was removed and cannot be selected.
+    "###);
+}
+
 #[test]
 fn deprecated_direct() {
     // Selection of a deprecated rule without preview enabled should still work

crates/ruff_linter/src/codes.rs

@@ -55,6 +55,8 @@ pub enum RuleGroup {
     /// The rule has been deprecated, warnings will be displayed during selection in stable
     /// and errors will be raised if used with preview mode enabled.
     Deprecated,
+    /// The rule has been removed, errors will be displayed on use.
+    Removed,
     /// Legacy category for unstable rules, supports backwards compatible selection.
     #[deprecated(note = "Use `RuleGroup::Preview` for new rules instead")]
     Nursery,
@@ -268,7 +270,7 @@ pub fn code_to_rule(linter: Linter, code: &str) -> Option<(RuleGroup, Rule)> {
         (Pylint, "R1704") => (RuleGroup::Preview, rules::pylint::rules::RedefinedArgumentFromLocal),
         (Pylint, "R1711") => (RuleGroup::Stable, rules::pylint::rules::UselessReturn),
         (Pylint, "R1714") => (RuleGroup::Stable, rules::pylint::rules::RepeatedEqualityComparison),
-        (Pylint, "R1706") => (RuleGroup::Preview, rules::pylint::rules::AndOrTernary),
+        (Pylint, "R1706") => (RuleGroup::Removed, rules::pylint::rules::AndOrTernary),
         (Pylint, "R1722") => (RuleGroup::Stable, rules::pylint::rules::SysExitAlias),
         (Pylint, "R1733") => (RuleGroup::Preview, rules::pylint::rules::UnnecessaryDictIndexLookup),
         (Pylint, "R1736") => (RuleGroup::Preview, rules::pylint::rules::UnnecessaryListIndexLookup),

crates/ruff_linter/src/rule_selector.rs

@@ -213,6 +213,8 @@ impl RuleSelector {
             || (preview_enabled && (matches!(self, RuleSelector::Rule { .. }) || !preview_require_explicit))
             // Deprecated rules are excluded in preview mode unless explicitly selected
             || (rule.is_deprecated() && (!preview_enabled || matches!(self, RuleSelector::Rule { .. })))
+            // Removed rules are included if explicitly selected but will error downstream
+            || (rule.is_removed() && matches!(self, RuleSelector::Rule { .. }))
         })
     }
 }

crates/ruff_macros/src/map_codes.rs

@@ -327,6 +327,10 @@ See also https://github.com/astral-sh/ruff/issues/2186.
             pub fn is_deprecated(&self) -> bool {
                 matches!(self.group(), RuleGroup::Deprecated)
             }
+
+            pub fn is_removed(&self) -> bool {
+                matches!(self.group(), RuleGroup::Removed)
+            }
         }
 
         impl Linter {

crates/ruff_workspace/src/configuration.rs

@@ -732,6 +732,7 @@ impl LintConfiguration {
         let mut redirects = FxHashMap::default();
         let mut deprecated_nursery_selectors = FxHashSet::default();
         let mut deprecated_selectors = FxHashSet::default();
+        let mut removed_selectors = FxHashSet::default();
         let mut ignored_preview_selectors = FxHashSet::default();
 
         // Track which docstring rules are specifically enabled
@@ -896,6 +897,13 @@ impl LintConfiguration {
                     }
                 }
 
+                // Removed rules
+                if let RuleSelector::Rule { prefix, .. } = selector {
+                    if prefix.rules().any(|rule| rule.is_removed()) {
+                        removed_selectors.insert(selector);
+                    }
+                }
+
                 // Redirected rules
                 if let RuleSelector::Prefix {
                     prefix,
@@ -907,6 +915,29 @@ impl LintConfiguration {
             }
         }
 
+        let removed_selectors = removed_selectors.iter().collect::<Vec<_>>();
+        match removed_selectors.as_slice() {
+            [] => (),
+            [selection] => {
+                let (prefix, code) = selection.prefix_and_code();
+                return Err(anyhow!(
+                    "Rule `{prefix}{code}` was removed and cannot be selected."
+                ));
+            }
+            [..] => {
+                let mut message =
+                    "The following rules have been removed and cannot be selected:".to_string();
+                for selection in removed_selectors {
+                    let (prefix, code) = selection.prefix_and_code();
+                    message.push_str("\n\t- ");
+                    message.push_str(prefix);
+                    message.push_str(code);
+                }
+                message.push('\n');
+                return Err(anyhow!(message));
+            }
+        }
+
         for (from, target) in redirects {
             // TODO(martin): This belongs into the ruff crate.
             warn_user_once_by_id!(