improve diagnostic ranges

Author: ntBre

crates/ruff_python_parser/src/parser/expression.rs

@@ -879,7 +879,7 @@ impl<'src> Parser<'src> {
             {
                 self.add_unsupported_syntax_error(
                     UnsupportedSyntaxErrorKind::UnparWalrusBefore310,
-                    self.node_range(start),
+                    lower.range(),
                 );
             }
 
@@ -1662,8 +1662,8 @@ impl<'src> Parser<'src> {
                     && key_or_element.is_unparenthesized_named_expr()
                 {
                     self.add_unsupported_syntax_error(
-                        UnsupportedSyntaxErrorKind::UnparWalrusBefore310,
-                        self.node_range(start),
+                        UnsupportedSyntaxErrorKind::UnparWalrus,
+                        key_or_element.range(),
                     );
                 }
 
@@ -1714,8 +1714,8 @@ impl<'src> Parser<'src> {
                     && key_or_element.is_unparenthesized_named_expr()
                 {
                     self.add_unsupported_syntax_error(
-                        UnsupportedSyntaxErrorKind::UnparWalrusBefore310,
-                        self.node_range(start),
+                        UnsupportedSyntaxErrorKind::UnparWalrus,
+                        key_or_element.range(),
                     );
                 }
                 Expr::Set(self.parse_set_expression(key_or_element.expr, start))
@@ -1884,8 +1884,8 @@ impl<'src> Parser<'src> {
                 && parsed_expr.is_unparenthesized_named_expr()
             {
                 parser.add_unsupported_syntax_error(
-                    UnsupportedSyntaxErrorKind::UnparWalrusBefore310,
-                    parser.node_range(start),
+                    UnsupportedSyntaxErrorKind::UnparWalrus,
+                    parsed_expr.range(),
                 );
             }
 

crates/ruff_python_parser/tests/snapshots/invalid_syntax@unparenthesized_walrus_set_comp_py39.py.snap

@@ -87,5 +87,5 @@ Module(
   |
 1 | # parse_options: {"target-version": "3.9"}
 2 | {last := x for x in range(3)}
-  | ^^^^^^^^^^ Syntax Error: Cannot use unparenthesized assignment expression on Python 3.9 (syntax was added in Python 3.10)
+  |  ^^^^^^^^^ Syntax Error: Cannot use unparenthesized assignment expression on Python 3.9 (syntax was added in Python 3.10)
   |

crates/ruff_python_parser/tests/snapshots/invalid_syntax@unparenthesized_walrus_set_literal_py39.py.snap

@@ -162,7 +162,7 @@ Module(
   |
 1 | # parse_options: {"target-version": "3.9"}
 2 | {x := 1, 2, 3}
-  | ^^^^^^^ Syntax Error: Cannot use unparenthesized assignment expression on Python 3.9 (syntax was added in Python 3.10)
+  |  ^^^^^^ Syntax Error: Cannot use unparenthesized assignment expression on Python 3.9 (syntax was added in Python 3.10)
 3 | {1, x := 2, 3}
 4 | {1, 2, x := 3}
   |
@@ -172,7 +172,7 @@ Module(
 1 | # parse_options: {"target-version": "3.9"}
 2 | {x := 1, 2, 3}
 3 | {1, x := 2, 3}
-  | ^^^^^^^^^^ Syntax Error: Cannot use unparenthesized assignment expression on Python 3.9 (syntax was added in Python 3.10)
+  |     ^^^^^^ Syntax Error: Cannot use unparenthesized assignment expression on Python 3.9 (syntax was added in Python 3.10)
 4 | {1, 2, x := 3}
   |
 
@@ -181,5 +181,5 @@ Module(
 2 | {x := 1, 2, 3}
 3 | {1, x := 2, 3}
 4 | {1, 2, x := 3}
-  | ^^^^^^^^^^^^^ Syntax Error: Cannot use unparenthesized assignment expression on Python 3.9 (syntax was added in Python 3.10)
+  |        ^^^^^^ Syntax Error: Cannot use unparenthesized assignment expression on Python 3.9 (syntax was added in Python 3.10)
   |