Diagnostics linger in problems panel after closing untitled Jupyter Notebooks

[anthonykim1]

I've noticed that there are stale error/warnings that show up in the problems panel when I close an VS Code Native REPL editor tab.
If you see the video you will notice that the diagnostics from Pylance will disappear right away when I close the Native REPL window but the ones from ruff will remain.

Screen.Recording.2025-04-02.at.12.38.54.PM.mov

I realized that there are two ways extension provide/interact with diagnostics when it comes to communicating with VS Code.

/cc @rchiodo @amunger

[amunger]

this also repro's for a regular untitled notebook:

1. Create new Jupyter notebook
2. add something that will generate a warning/error from Ruff
3. close the notebook and discard changes

🐛 diagnostics from Ruff remain for the untitled ipynb

[dhruvmanila]

Thanks for the report and providing the reproduction steps. I can reproduce it for the untitled notebook. I'll convert the issue as specific to untitled Jupyter Notebook and look into native REPL later.

[dhruvmanila]

Quickly debugging this, I found that these are the requests that VS Code sends when closing an untitled notebook:

[Trace - 10:55:35 AM] Sending notification 'notebookDocument/didClose'.
Params: {
    "notebookDocument": {
        "uri": "untitled:Untitled-1.ipynb?jupyter-notebook"
    },
    "cellTextDocuments": [
        {
            "uri": "vscode-notebook-cell:Untitled-1.ipynb?jupyter-notebook#W0sdW50aXRsZWQ%3D"
        }
    ]
}


[Trace - 10:55:35 AM] Sending notification 'textDocument/didClose'.
Params: {
    "textDocument": {
        "uri": "vscode-notebook-cell:Untitled-1.ipynb?jupyter-notebook#W0sdW50aXRsZWQ%3D"
    }
}

And, it seems that we're removing the text document before the textDocument/didClose request:

2025-04-03 10:58:38.671507000 DEBUG Unable to close document with key vscode-notebook-cell:Untitled-1.ipynb?jupyter-notebook#W0sdW50aXRsZWQ%3D - the snapshot was unavailable