Skip to content

Make HttpsConnectionFilter more configurable #4622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
halter73 opened this issue Oct 5, 2015 · 8 comments
Closed

Make HttpsConnectionFilter more configurable #4622

halter73 opened this issue Oct 5, 2015 · 8 comments
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-kestrel
Milestone

Comments

@halter73
Copy link
Member

halter73 commented Oct 5, 2015

  • Support multiple certificates
    • Allow certs to be specified for a given port and/or IP address
    • Allow certs to be specified for a given hostname once SNI is supported
  • Make allowed SslProtocols configurable
  • Use the options pattern (e.g. Facebook Middleware) which takes a configureOptions Action.
@muratg
Copy link
Contributor

muratg commented Oct 5, 2015

Putting this in RC1 for now, though it may have to get punted.

@muratg
Copy link
Contributor

muratg commented Oct 12, 2015

Moving further out. Feel free to talk to me to bring this back. We'll just need to prioritize it with the rest of the work.

@halter73
Copy link
Member Author

#385 makes SslProtocols configurable.

@Tratcher
Copy link
Member

@VanCoding
Copy link

What we really need is a way to specify a function that returns the correct ssl certificate to use for a given hostname.

Both Node.js & Go have such an option.

The reason why specifying it statically is not sufficient is, that we may not always know which domains are going to be used for the server. Imagine a setup where a lot of customers use the same instance, but have different subdomains, like customer1.myapplication.com and customer2.myapplication.com, and where customers are created or deleted at runtime. In such a scenario, we don't even have the certificate for a customer created at runtime. The server would create one using Letsencrypt on the first request.

Right now, the only option we have for something like that is to use an expensive wildcard certificate.

@Tratcher
Copy link
Member

Tratcher commented Dec 9, 2016

@VanCoding that requires SNI, see dotnet/corefx#9608

@VanCoding
Copy link

@Tratcher Yes, I know. I just wanted to make sure that we make the most use of it as soon as they implement it :)

@aspnet-hello aspnet-hello transferred this issue from aspnet/KestrelHttpServer Dec 12, 2018
@aspnet-hello aspnet-hello added this to the Backlog milestone Dec 12, 2018
@jkotalik
Copy link
Contributor

I believe this isn't relevant anymore.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 13, 2020
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions feature-kestrel
Projects
None yet
Development

No branches or pull requests

8 participants