Skip to content

Add --include-git to mix igniter.upgrade --all #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jimsynz opened this issue Feb 11, 2025 · 4 comments
Open

Add --include-git to mix igniter.upgrade --all #225

jimsynz opened this issue Feb 11, 2025 · 4 comments
Labels
enhancement New feature or request

Comments

@jimsynz
Copy link

jimsynz commented Feb 11, 2025

Is your feature request related to a problem? Please describe.
A client was surprised by the behaviour of igniter.upgrade not matching that of deps.update for git-based dependencies.

Describe the solution you'd like
Either --all should include git dependencies by default or it should have an additional flag to enable them.

Describe alternatives you've considered

mix igniter.upgrade --all && mix deps.update --all

Additional context
Request via an APS client.

@jimsynz jimsynz added the enhancement New feature or request label Feb 11, 2025
@zachdaniel
Copy link
Contributor

Does mix deps.update --all do git dependencies by default?

@jimsynz
Copy link
Author

jimsynz commented Feb 11, 2025

Yes

@zachdaniel
Copy link
Contributor

Ah, so the difficult thing for us is that we don't know what upgraders to run in those scenarios I think. I will have to look into doing this.

@jimsynz
Copy link
Author

jimsynz commented Feb 12, 2025

Makes sense. Maybe just update and if the package has an upgrader (and most won't) then emit a warning about it.

@zachdaniel zachdaniel moved this from Up Next to In Progress in Ash Framework Roadmap Apr 13, 2025
@zachdaniel zachdaniel moved this from In Progress to Up Next in Ash Framework Roadmap Apr 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Up Next
Development

No branches or pull requests

2 participants