improvement: make router optional in select_endpoint

improvement: accept functions in warning/notice/issue assertions
improvement: add `Igniter.Code.Common.variable?`

Author: zachdaniel

lib/igniter/code/common.ex

@@ -24,6 +24,14 @@ defmodule Igniter.Code.Common do
     end
   end
 
+  @doc "Returns true if the node represents a variable with the given name"
+  @spec variable?(zipper :: Zipper.t(), name :: atom) :: boolean()
+  def variable?(%{node: {name, _, ctx}}, name) when is_atom(ctx) do
+    true
+  end
+
+  def variable?(_, _), do: false
+
   @doc "Returns true if the node represents a variable assignment"
   @spec variable_assignment?(zipper :: Zipper.t(), name :: atom) :: boolean()
   def variable_assignment?(%{node: {:=, _, [{name, _, ctx}, _]}}, name) when is_atom(ctx) do

lib/igniter/libs/phoenix.ex

@@ -114,17 +114,35 @@ defmodule Igniter.Libs.Phoenix do
 
   If multiple endpoints are found, the user is prompted to select one of them.
   """
-  @spec select_endpoint(Igniter.t(), module(), String.t()) :: {Igniter.t(), module() | nil}
-  def select_endpoint(igniter, router, label \\ "Which endpoint should be used") do
-    case endpoints_for_router(igniter, router) do
-      {igniter, []} ->
-        {igniter, nil}
+  @spec select_endpoint(Igniter.t(), module() | nil, String.t()) :: {Igniter.t(), module() | nil}
+  def select_endpoint(igniter, router \\ nil, label \\ "Which endpoint should be used") do
+    if router do
+      case endpoints_for_router(igniter, router) do
+        {igniter, []} ->
+          {igniter, nil}
+
+        {igniter, [endpoint]} ->
+          {igniter, endpoint}
+
+        {igniter, endpoints} ->
+          {igniter, Igniter.Util.IO.select(label, endpoints, display: &inspect/1)}
+      end
+    else
+      {igniter, endpoints} =
+        Igniter.Project.Module.find_all_matching_modules(igniter, fn _mod, zipper ->
+          Igniter.Code.Module.move_to_use(zipper, Phoenix.Endpoint) != :error
+        end)
 
-      {igniter, [endpoint]} ->
-        {igniter, endpoint}
+      case endpoints do
+        [] ->
+          {igniter, nil}
 
-      {igniter, endpoints} ->
-        {igniter, Igniter.Util.IO.select(label, endpoints, display: &inspect/1)}
+        [endpoint] ->
+          {igniter, endpoint}
+
+        endpoints ->
+          {igniter, Igniter.Util.IO.select(label, endpoints, display: &inspect/1)}
+      end
     end
   end
 

lib/igniter/test.ex

@@ -208,7 +208,7 @@ defmodule Igniter.Test do
           flunk("""
           Expected to find `mix #{task} #{Enum.join(argv, " ")}` in igniter tasks.
 
-          Found tasks: 
+          Found tasks:
 
           #{Enum.map_join(igniter.tasks, "\n", fn {task, argv} -> "- mix #{task} #{Enum.join(argv)}" end)}
           """)
@@ -221,7 +221,13 @@ defmodule Igniter.Test do
 
   defmacro assert_has_notice(igniter, notice) do
     quote bind_quoted: [igniter: igniter, notice: notice] do
-      if notice not in igniter.notices do
+      if !Enum.any?(igniter.notices, fn found_notice ->
+           if is_binary(notice) do
+             notice == found_notice
+           else
+             notice.(found_notice)
+           end
+         end) do
         if Enum.empty?(igniter.notices) do
           flunk("""
           Expected to find the following notice:
@@ -236,7 +242,7 @@ defmodule Igniter.Test do
 
           #{notice}
 
-          Found notices: 
+          Found notices:
 
           #{Enum.join(igniter.notices, "\n\b")}
           """)
@@ -249,7 +255,13 @@ defmodule Igniter.Test do
 
   defmacro assert_has_warning(igniter, warning) do
     quote bind_quoted: [igniter: igniter, warning: warning] do
-      if warning not in igniter.warnings do
+      if !Enum.any?(igniter.warnings, fn found_warning ->
+           if is_binary(warning) do
+             warning == found_warning
+           else
+             warning.(found_warning)
+           end
+         end) do
         if Enum.empty?(igniter.warnings) do
           flunk("""
           Expected to find the following warning:
@@ -264,7 +276,7 @@ defmodule Igniter.Test do
 
           #{warning}
 
-          Found warnings: 
+          Found warnings:
 
           #{Enum.join(igniter.warnings, "\n\b")}
           """)
@@ -287,7 +299,13 @@ defmodule Igniter.Test do
             []
           end
 
-        if issue not in issues do
+        if !Enum.any?(igniter.issues, fn found_issue ->
+             if is_binary(issue) do
+               issue == found_issue
+             else
+               issue.(found_issue)
+             end
+           end) do
           if Enum.empty?(issues) do
             flunk("""
             Expected to find the following issue at path: #{inspect(path)}}
@@ -302,14 +320,20 @@ defmodule Igniter.Test do
 
             #{issue}
 
-            Found issue: 
+            Found issue:
 
             #{Enum.join(issues, "\n\b")}
             """)
           end
         end
       else
-        if issue not in igniter.issues do
+        if !Enum.any?(igniter.issues, fn found_issue ->
+             if is_binary(issue) do
+               issue == found_issue
+             else
+               issue.(found_issue)
+             end
+           end) do
           if Enum.empty?(igniter.issues) do
             flunk("""
             Expected to find the following issue:
@@ -324,7 +348,7 @@ defmodule Igniter.Test do
 
             #{issue}
 
-            Found issues: 
+            Found issues:
 
             #{Enum.join(igniter.issues, "\n\b")}
             """)