Skip to content

Commit f79d4d2

Browse files
Patching ScaledObjects when creation failed with an "already exists" error
Plus more refactors as necessary Signed-off-by: Aaron Schlesinger <[email protected]> Updating the release process document with correct order of operations (kedacore#327) * updating the release process document Signed-off-by: Aaron Schlesinger <[email protected]> * adding information about the chart's images.tag field in values.yaml Signed-off-by: Aaron Schlesinger <[email protected]> Bump k8s.io/apimachinery from 0.22.3 to 0.22.4 (kedacore#328) Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.22.3 to 0.22.4. - [Release notes](https://github.com/kubernetes/apimachinery/releases) - [Commits](kubernetes/apimachinery@v0.22.3...v0.22.4) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump k8s.io/client-go from 0.22.2 to 0.22.4 (kedacore#329) Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.22.2 to 0.22.4. - [Release notes](https://github.com/kubernetes/client-go/releases) - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.22.2...v0.22.4) --- updated-dependencies: - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump google.golang.org/grpc from 1.41.0 to 1.42.0 (kedacore#312) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.41.0 to 1.42.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.41.0...v1.42.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aaron Schlesinger <[email protected]> Add configMap informer (kedacore#326) Signed-off-by: laminar <[email protected]> Signed-off-by: laminar <[email protected]> Co-authored-by: Aaron Schlesinger <[email protected]> Restore target to original replica count after deleting httpscaledobject resource. (kedacore#339) Signed-off-by: laminar <[email protected]> Signed-off-by: laminar <[email protected]> Co-authored-by: Aaron Schlesinger <[email protected]> Upgrading images to use Go 1.17.2 (kedacore#349) Adding documentation for how to issue curl requests (kedacore#347) Signed-off-by: Aaron Schlesinger <[email protected]> chore: Allow blank issues (kedacore#352) Signed-off-by: Tom Kerkhove <[email protected]> Bump github.com/magefile/mage from 1.11.0 to 1.12.1 (kedacore#360) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump google.golang.org/grpc from 1.42.0 to 1.43.0 (kedacore#358) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> converting bug report issue template to a form issue (kedacore#363) Signed-off-by: Aaron Schlesinger <[email protected]> Allowing cluster-global operation (kedacore#269) * Allowing cluster-global operation Signed-off-by: Aaron Schlesinger <[email protected]> * passing less unnecessary data in the operator Signed-off-by: Aaron Schlesinger <[email protected]> * setting namespace Signed-off-by: Aaron Schlesinger <[email protected]> * updating tests: Signed-off-by: Aaron Schlesinger <[email protected]> * Updating deployment cache interfaces To accommodate multi-namespace gets and watches Signed-off-by: Aaron Schlesinger <[email protected]> * starting on deployment cache informer Signed-off-by: Aaron Schlesinger <[email protected]> * switching over to informer-based deployment cache Signed-off-by: Aaron Schlesinger <[email protected]> * fixing test compile errors and merging fake and in-memory deployment caches Signed-off-by: Aaron <[email protected]> * fixing tests Signed-off-by: Aaron Schlesinger <[email protected]> * fixing more compile errs Signed-off-by: Aaron Schlesinger <[email protected]> * improving logging, and several other small changes Signed-off-by: Aaron Schlesinger <[email protected]> * go mod tidy Signed-off-by: Aaron Schlesinger <[email protected]> * Adding config validation Signed-off-by: Aaron Schlesinger <[email protected]> * improving ns and svc name var names to indicate interceptor Signed-off-by: Aaron Schlesinger <[email protected]> * running go mod tidy Signed-off-by: Aaron Schlesinger <[email protected]> * removing unused code Signed-off-by: Aaron Schlesinger <[email protected]> * passing a function to transform target to in-cluster URL Signed-off-by: Aaron Schlesinger <[email protected]> * not requiring namespace for operator Signed-off-by: Aaron Schlesinger <[email protected]> * splitting namespace config for operator into watch and current Signed-off-by: Aaron Schlesinger <[email protected]> * removing appInfo, passing current namespace everywhere in its place Signed-off-by: Aaron Schlesinger <[email protected]> * using proper namespace when creating scaled object Signed-off-by: Aaron Schlesinger <[email protected]> * allowing xkcd chart to set ingress namespace Signed-off-by: Aaron Schlesinger <[email protected]> * printing namespace in error Signed-off-by: Aaron Schlesinger <[email protected]> * using proper fully-qualified hostname of external scaler in scaledobject Signed-off-by: Aaron Schlesinger <[email protected]> * adding note on cluster-global vs. namespaced mode Signed-off-by: Aaron Schlesinger <[email protected]> * adding note about installing the xkcd chart in cluster-global mode Signed-off-by: Aaron Schlesinger <[email protected]> * fixing hostname test Signed-off-by: Aaron Schlesinger <[email protected]> * merging scaler queue counts with routing table hosts. removing merge functionality from interceptors Signed-off-by: Aaron Schlesinger <[email protected]> * fix assumption in tests that queue has all hosts from routing table Signed-off-by: Aaron Schlesinger <[email protected]> * adding test for MergeCountsWithRoutingTable Signed-off-by: Aaron Schlesinger <[email protected]> * sleep for longer to wait for server to start Signed-off-by: Aaron Schlesinger <[email protected]> * adding handler test for merging hosts Signed-off-by: Aaron Schlesinger <[email protected]> * adding test to GetMetrics test cases for host not in queue pinger Signed-off-by: Aaron Schlesinger <[email protected]> Return custom header when request was returned from a cold start (kedacore#366) * Add X-KEDA-HTTP-Cold-Start header - Add X-KEDA-HTTP-Cold-Start header - Change signature of forwardWaitFunc to include deployment.Status.ReadyReplicas Signed-off-by: Aaron Wislang <[email protected]> * Update tests for X-KEDA-HTTP-Cold-Start header Signed-off-by: Aaron Wislang <[email protected]> * Update interceptor/main_test.go Co-authored-by: Aaron Schlesinger <[email protected]> Signed-off-by: Aaron Wislang <[email protected]> * add bracket Signed-off-by: Aaron Wislang <[email protected]> Co-authored-by: Aaron Schlesinger <[email protected]> Updating dependencies (kedacore#348) * updating dependencies Signed-off-by: Aaron Schlesinger <[email protected]> * NullLogger => Discard() Signed-off-by: Aaron Schlesinger <[email protected]> * removing redundant import Signed-off-by: Aaron Schlesinger <[email protected]> * updating to use go 1.17.2 Signed-off-by: Aaron Schlesinger <[email protected]> * upgrading vulnerable packages Signed-off-by: Aaron Schlesinger <[email protected]> * upgrading sftp Signed-off-by: Aaron Schlesinger <[email protected]> * force-upgrading sftp Signed-off-by: Aaron Schlesinger <[email protected]> Bump go.uber.org/zap from 1.19.1 to 1.20.0 (kedacore#362) Bumps [go.uber.org/zap](https://github.com/uber-go/zap) from 1.19.1 to 1.20.0. - [Release notes](https://github.com/uber-go/zap/releases) - [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md) - [Commits](uber-go/zap@v1.19.1...v1.20.0) --- updated-dependencies: - dependency-name: go.uber.org/zap dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump github.com/go-logr/zapr from 0.4.0 to 1.2.2 (kedacore#357) Bumps [github.com/go-logr/zapr](https://github.com/go-logr/zapr) from 0.4.0 to 1.2.2. - [Release notes](https://github.com/go-logr/zapr/releases) - [Commits](go-logr/zapr@v0.4.0...v1.2.2) --- updated-dependencies: - dependency-name: github.com/go-logr/zapr dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump k8s.io/apimachinery from 0.23.1 to 0.23.2 (kedacore#376) Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.23.1 to 0.23.2. - [Release notes](https://github.com/kubernetes/apimachinery/releases) - [Commits](kubernetes/apimachinery@v0.23.1...v0.23.2) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump k8s.io/client-go from 0.23.1 to 0.23.2 (kedacore#375) Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.23.1 to 0.23.2. - [Release notes](https://github.com/kubernetes/client-go/releases) - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.23.1...v0.23.2) --- updated-dependencies: - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Compile binaries and docker images with git SHA (kedacore#377) * Compile binaries and docker images with git SHA Signed-off-by: Aaron Wislang <[email protected]> Signed-off-by: Ubuntu <azureuser@vm1.dwkkbikwkshepl1jlyp52keone.bx.internal.cloudapp.net> * Fix test Signed-off-by: Aaron Wislang <[email protected]> Signed-off-by: Ubuntu <azureuser@vm1.dwkkbikwkshepl1jlyp52keone.bx.internal.cloudapp.net> * Apply suggestions from @arschles Co-authored-by: Aaron Schlesinger <[email protected]> Signed-off-by: Ubuntu <azureuser@vm1.dwkkbikwkshepl1jlyp52keone.bx.internal.cloudapp.net> Co-authored-by: Aaron Schlesinger <[email protected]> Bump github.com/onsi/gomega from 1.17.0 to 1.18.0 (kedacore#378) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Configure WhiteSource Bolt for GitHub (kedacore#379) Co-authored-by: whitesource-bolt-for-github[bot] <42819689+whitesource-bolt-for-github[bot]@users.noreply.github.com> Co-authored-by: Tom Kerkhove <[email protected]> adding targetPendingRequests to the xkcd helm chart (kedacore#373) Signed-off-by: Aaron Schlesinger <[email protected]> fixing targetPendingRequests in the HTTPScaledObject v0.2.0 documentation (kedacore#372) Signed-off-by: Aaron Schlesinger <[email protected]> Add TestStreamIsActive (kedacore#384) * Return IsActive error vs log and continue Signed-off-by: Aaron Wislang <[email protected]> * Add TestStreamIsActive Signed-off-by: Aaron Wislang <[email protected]> * Bump github.com/onsi/gomega from 1.17.0 to 1.18.0 (kedacore#378) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Aaron Wislang <[email protected]> * Configure WhiteSource Bolt for GitHub (kedacore#379) Co-authored-by: whitesource-bolt-for-github[bot] <42819689+whitesource-bolt-for-github[bot]@users.noreply.github.com> Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Aaron Wislang <[email protected]> * adding targetPendingRequests to the xkcd helm chart (kedacore#373) Signed-off-by: Aaron Schlesinger <[email protected]> Signed-off-by: Aaron Wislang <[email protected]> * fixing targetPendingRequests in the HTTPScaledObject v0.2.0 documentation (kedacore#372) Signed-off-by: Aaron Schlesinger <[email protected]> Signed-off-by: Aaron Wislang <[email protected]> * defer grpcServer.Stop() Co-authored-by: Aaron Schlesinger <[email protected]> Signed-off-by: Aaron Wislang <[email protected]> * Don't check error for gprServer Signed-off-by: Aaron Wislang <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: whitesource-bolt-for-github[bot] <42819689+whitesource-bolt-for-github[bot]@users.noreply.github.com> Co-authored-by: Tom Kerkhove <[email protected]> Co-authored-by: Aaron Schlesinger <[email protected]> Bump go.uber.org/zap from 1.20.0 to 1.21.0 (kedacore#394) Bumps [go.uber.org/zap](https://github.com/uber-go/zap) from 1.20.0 to 1.21.0. - [Release notes](https://github.com/uber-go/zap/releases) - [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md) - [Commits](uber-go/zap@v1.20.0...v1.21.0) --- updated-dependencies: - dependency-name: go.uber.org/zap dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump google.golang.org/grpc from 1.43.0 to 1.44.0 (kedacore#390) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.43.0 to 1.44.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.43.0...v1.44.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump github.com/onsi/gomega from 1.18.0 to 1.18.1 (kedacore#393) Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.18.0 to 1.18.1. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.18.0...v1.18.1) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump k8s.io/apimachinery from 0.23.2 to 0.23.3 (kedacore#392) Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.23.2 to 0.23.3. - [Release notes](https://github.com/kubernetes/apimachinery/releases) - [Commits](kubernetes/apimachinery@v0.23.2...v0.23.3) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump k8s.io/api from 0.23.2 to 0.23.3 (kedacore#389) Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.23.2 to 0.23.3. - [Release notes](https://github.com/kubernetes/api/releases) - [Commits](kubernetes/api@v0.23.2...v0.23.3) --- updated-dependencies: - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> fix shell typo in docs (kedacore#395) Signed-off-by: XinYang <[email protected]> fix documentation for creating an HTTPScaledObject (kedacore#351) * fix documentation for creating an HTTPScaledObject Signed-off-by: Marco Piovesana <[email protected]> * chore: Allow blank issues (kedacore#352) Signed-off-by: Tom Kerkhove <[email protected]> Signed-off-by: Marco Piovesana <[email protected]> * Bump github.com/magefile/mage from 1.11.0 to 1.12.1 (kedacore#360) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Marco Piovesana <[email protected]> * Bump google.golang.org/grpc from 1.42.0 to 1.43.0 (kedacore#358) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Marco Piovesana <[email protected]> * converting bug report issue template to a form issue (kedacore#363) Signed-off-by: Aaron Schlesinger <[email protected]> Signed-off-by: Marco Piovesana <[email protected]> * Allowing cluster-global operation (kedacore#269) * Allowing cluster-global operation Signed-off-by: Aaron Schlesinger <[email protected]> * passing less unnecessary data in the operator Signed-off-by: Aaron Schlesinger <[email protected]> * setting namespace Signed-off-by: Aaron Schlesinger <[email protected]> * updating tests: Signed-off-by: Aaron Schlesinger <[email protected]> * Updating deployment cache interfaces To accommodate multi-namespace gets and watches Signed-off-by: Aaron Schlesinger <[email protected]> * starting on deployment cache informer Signed-off-by: Aaron Schlesinger <[email protected]> * switching over to informer-based deployment cache Signed-off-by: Aaron Schlesinger <[email protected]> * fixing test compile errors and merging fake and in-memory deployment caches Signed-off-by: Aaron <[email protected]> * fixing tests Signed-off-by: Aaron Schlesinger <[email protected]> * fixing more compile errs Signed-off-by: Aaron Schlesinger <[email protected]> * improving logging, and several other small changes Signed-off-by: Aaron Schlesinger <[email protected]> * go mod tidy Signed-off-by: Aaron Schlesinger <[email protected]> * Adding config validation Signed-off-by: Aaron Schlesinger <[email protected]> * improving ns and svc name var names to indicate interceptor Signed-off-by: Aaron Schlesinger <[email protected]> * running go mod tidy Signed-off-by: Aaron Schlesinger <[email protected]> * removing unused code Signed-off-by: Aaron Schlesinger <[email protected]> * passing a function to transform target to in-cluster URL Signed-off-by: Aaron Schlesinger <[email protected]> * not requiring namespace for operator Signed-off-by: Aaron Schlesinger <[email protected]> * splitting namespace config for operator into watch and current Signed-off-by: Aaron Schlesinger <[email protected]> * removing appInfo, passing current namespace everywhere in its place Signed-off-by: Aaron Schlesinger <[email protected]> * using proper namespace when creating scaled object Signed-off-by: Aaron Schlesinger <[email protected]> * allowing xkcd chart to set ingress namespace Signed-off-by: Aaron Schlesinger <[email protected]> * printing namespace in error Signed-off-by: Aaron Schlesinger <[email protected]> * using proper fully-qualified hostname of external scaler in scaledobject Signed-off-by: Aaron Schlesinger <[email protected]> * adding note on cluster-global vs. namespaced mode Signed-off-by: Aaron Schlesinger <[email protected]> * adding note about installing the xkcd chart in cluster-global mode Signed-off-by: Aaron Schlesinger <[email protected]> * fixing hostname test Signed-off-by: Aaron Schlesinger <[email protected]> * merging scaler queue counts with routing table hosts. removing merge functionality from interceptors Signed-off-by: Aaron Schlesinger <[email protected]> * fix assumption in tests that queue has all hosts from routing table Signed-off-by: Aaron Schlesinger <[email protected]> * adding test for MergeCountsWithRoutingTable Signed-off-by: Aaron Schlesinger <[email protected]> * sleep for longer to wait for server to start Signed-off-by: Aaron Schlesinger <[email protected]> * adding handler test for merging hosts Signed-off-by: Aaron Schlesinger <[email protected]> * adding test to GetMetrics test cases for host not in queue pinger Signed-off-by: Aaron Schlesinger <[email protected]> Signed-off-by: Marco Piovesana <[email protected]> * Return custom header when request was returned from a cold start (kedacore#366) * Add X-KEDA-HTTP-Cold-Start header - Add X-KEDA-HTTP-Cold-Start header - Change signature of forwardWaitFunc to include deployment.Status.ReadyReplicas Signed-off-by: Aaron Wislang <[email protected]> * Update tests for X-KEDA-HTTP-Cold-Start header Signed-off-by: Aaron Wislang <[email protected]> * Update interceptor/main_test.go Co-authored-by: Aaron Schlesinger <[email protected]> Signed-off-by: Aaron Wislang <[email protected]> * add bracket Signed-off-by: Aaron Wislang <[email protected]> Co-authored-by: Aaron Schlesinger <[email protected]> Signed-off-by: Marco Piovesana <[email protected]> * Updating dependencies (kedacore#348) * updating dependencies Signed-off-by: Aaron Schlesinger <[email protected]> * NullLogger => Discard() Signed-off-by: Aaron Schlesinger <[email protected]> * removing redundant import Signed-off-by: Aaron Schlesinger <[email protected]> * updating to use go 1.17.2 Signed-off-by: Aaron Schlesinger <[email protected]> * upgrading vulnerable packages Signed-off-by: Aaron Schlesinger <[email protected]> * upgrading sftp Signed-off-by: Aaron Schlesinger <[email protected]> * force-upgrading sftp Signed-off-by: Aaron Schlesinger <[email protected]> Signed-off-by: Marco Piovesana <[email protected]> * Bump go.uber.org/zap from 1.19.1 to 1.20.0 (kedacore#362) Bumps [go.uber.org/zap](https://github.com/uber-go/zap) from 1.19.1 to 1.20.0. - [Release notes](https://github.com/uber-go/zap/releases) - [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md) - [Commits](uber-go/zap@v1.19.1...v1.20.0) --- updated-dependencies: - dependency-name: go.uber.org/zap dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Marco Piovesana <[email protected]> * Bump github.com/go-logr/zapr from 0.4.0 to 1.2.2 (kedacore#357) Bumps [github.com/go-logr/zapr](https://github.com/go-logr/zapr) from 0.4.0 to 1.2.2. - [Release notes](https://github.com/go-logr/zapr/releases) - [Commits](go-logr/zapr@v0.4.0...v1.2.2) --- updated-dependencies: - dependency-name: github.com/go-logr/zapr dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Marco Piovesana <[email protected]> * Bump k8s.io/apimachinery from 0.23.1 to 0.23.2 (kedacore#376) Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.23.1 to 0.23.2. - [Release notes](https://github.com/kubernetes/apimachinery/releases) - [Commits](kubernetes/apimachinery@v0.23.1...v0.23.2) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Marco Piovesana <[email protected]> * Bump k8s.io/client-go from 0.23.1 to 0.23.2 (kedacore#375) Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.23.1 to 0.23.2. - [Release notes](https://github.com/kubernetes/client-go/releases) - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.23.1...v0.23.2) --- updated-dependencies: - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Marco Piovesana <[email protected]> * Compile binaries and docker images with git SHA (kedacore#377) * Compile binaries and docker images with git SHA Signed-off-by: Aaron Wislang <[email protected]> Signed-off-by: Ubuntu <azureuser@vm1.dwkkbikwkshepl1jlyp52keone.bx.internal.cloudapp.net> * Fix test Signed-off-by: Aaron Wislang <[email protected]> Signed-off-by: Ubuntu <azureuser@vm1.dwkkbikwkshepl1jlyp52keone.bx.internal.cloudapp.net> * Apply suggestions from @arschles Co-authored-by: Aaron Schlesinger <[email protected]> Signed-off-by: Ubuntu <azureuser@vm1.dwkkbikwkshepl1jlyp52keone.bx.internal.cloudapp.net> Co-authored-by: Aaron Schlesinger <[email protected]> Signed-off-by: Marco Piovesana <[email protected]> * Bump github.com/onsi/gomega from 1.17.0 to 1.18.0 (kedacore#378) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Marco Piovesana <[email protected]> * Configure WhiteSource Bolt for GitHub (kedacore#379) Co-authored-by: whitesource-bolt-for-github[bot] <42819689+whitesource-bolt-for-github[bot]@users.noreply.github.com> Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Marco Piovesana <[email protected]> * adding targetPendingRequests to the xkcd helm chart (kedacore#373) Signed-off-by: Aaron Schlesinger <[email protected]> Signed-off-by: Marco Piovesana <[email protected]> * fixing targetPendingRequests in the HTTPScaledObject v0.2.0 documentation (kedacore#372) Signed-off-by: Aaron Schlesinger <[email protected]> Signed-off-by: Marco Piovesana <[email protected]> * Add TestStreamIsActive (kedacore#384) * Return IsActive error vs log and continue Signed-off-by: Aaron Wislang <[email protected]> * Add TestStreamIsActive Signed-off-by: Aaron Wislang <[email protected]> * Bump github.com/onsi/gomega from 1.17.0 to 1.18.0 (kedacore#378) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Aaron Wislang <[email protected]> * Configure WhiteSource Bolt for GitHub (kedacore#379) Co-authored-by: whitesource-bolt-for-github[bot] <42819689+whitesource-bolt-for-github[bot]@users.noreply.github.com> Co-authored-by: Tom Kerkhove <[email protected]> Signed-off-by: Aaron Wislang <[email protected]> * adding targetPendingRequests to the xkcd helm chart (kedacore#373) Signed-off-by: Aaron Schlesinger <[email protected]> Signed-off-by: Aaron Wislang <[email protected]> * fixing targetPendingRequests in the HTTPScaledObject v0.2.0 documentation (kedacore#372) Signed-off-by: Aaron Schlesinger <[email protected]> Signed-off-by: Aaron Wislang <[email protected]> * defer grpcServer.Stop() Co-authored-by: Aaron Schlesinger <[email protected]> Signed-off-by: Aaron Wislang <[email protected]> * Don't check error for gprServer Signed-off-by: Aaron Wislang <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: whitesource-bolt-for-github[bot] <42819689+whitesource-bolt-for-github[bot]@users.noreply.github.com> Co-authored-by: Tom Kerkhove <[email protected]> Co-authored-by: Aaron Schlesinger <[email protected]> Signed-off-by: Marco Piovesana <[email protected]> * Bump go.uber.org/zap from 1.20.0 to 1.21.0 (kedacore#394) Bumps [go.uber.org/zap](https://github.com/uber-go/zap) from 1.20.0 to 1.21.0. - [Release notes](https://github.com/uber-go/zap/releases) - [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md) - [Commits](uber-go/zap@v1.20.0...v1.21.0) --- updated-dependencies: - dependency-name: go.uber.org/zap dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Marco Piovesana <[email protected]> * Bump google.golang.org/grpc from 1.43.0 to 1.44.0 (kedacore#390) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.43.0 to 1.44.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.43.0...v1.44.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Marco Piovesana <[email protected]> * Bump github.com/onsi/gomega from 1.18.0 to 1.18.1 (kedacore#393) Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.18.0 to 1.18.1. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.18.0...v1.18.1) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Marco Piovesana <[email protected]> * Bump k8s.io/apimachinery from 0.23.2 to 0.23.3 (kedacore#392) Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.23.2 to 0.23.3. - [Release notes](https://github.com/kubernetes/apimachinery/releases) - [Commits](kubernetes/apimachinery@v0.23.2...v0.23.3) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Marco Piovesana <[email protected]> * Bump k8s.io/api from 0.23.2 to 0.23.3 (kedacore#389) Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.23.2 to 0.23.3. - [Release notes](https://github.com/kubernetes/api/releases) - [Commits](kubernetes/api@v0.23.2...v0.23.3) --- updated-dependencies: - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Marco Piovesana <[email protected]> * Update docs/walkthrough.md Co-authored-by: Aaron Schlesinger <[email protected]> Signed-off-by: Marco Piovesana <[email protected]> Co-authored-by: mpiovesana <[email protected]> Co-authored-by: Tom Kerkhove <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aaron Schlesinger <[email protected]> Co-authored-by: Aaron Wislang <[email protected]> Co-authored-by: whitesource-bolt-for-github[bot] <42819689+whitesource-bolt-for-github[bot]@users.noreply.github.com> Bump k8s.io/client-go from 0.23.2 to 0.23.3 (kedacore#391) Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.23.2 to 0.23.3. - [Release notes](https://github.com/kubernetes/client-go/releases) - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.23.2...v0.23.3) --- updated-dependencies: - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Fix scaler crash (kedacore#399) Signed-off-by: Jakub Leska <[email protected]> Co-authored-by: Aaron Schlesinger <[email protected]>
1 parent 79ff716 commit f79d4d2

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

71 files changed

+1915
-1813
lines changed

.devcontainer/Dockerfile

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
# [Choice] Go version: 1, 1.16, 1.15
2-
ARG VARIANT=1.17
3-
FROM mcr.microsoft.com/vscode/devcontainers/go:0-${VARIANT}
1+
ARG GO_VERSION=1.17
2+
FROM mcr.microsoft.com/vscode/devcontainers/go:0-${GO_VERSION}
43

54
# install mage
65
RUN git clone https://github.com/magefile/mage && \

.github/ISSUE_TEMPLATE/Bug_report.md

-24
This file was deleted.
+91
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,91 @@
1+
name: Report a bug 🐛
2+
description: Create a report to help us improve
3+
labels: ["bug"]
4+
body:
5+
- type: textarea
6+
id: description
7+
attributes:
8+
label: Report
9+
description: "What bug have you encountered?"
10+
placeholder: "A clear and concise description of what the bug is."
11+
- type: textarea
12+
id: expected-behavior
13+
attributes:
14+
label: Expected Behavior
15+
description: What did you expect to happen?
16+
placeholder: What did you expect to happen?
17+
validations:
18+
required: true
19+
- type: textarea
20+
id: actual-behavior
21+
attributes:
22+
label: Actual Behavior
23+
description: Also tell us, what did you see is happen?
24+
placeholder: Tell us what you see that is happening
25+
validations:
26+
required: true
27+
- type: textarea
28+
id: repro-steps
29+
attributes:
30+
label: Steps to Reproduce the Problem
31+
description: "How can we reproduce this bug? Please walk us through it step by step."
32+
value: |
33+
1.
34+
2.
35+
3.
36+
validations:
37+
required: true
38+
- type: textarea
39+
id: logs
40+
attributes:
41+
label: Logs from KEDA HTTP operator
42+
description: "Provide logs from the KEDA HTTP operator, if need be."
43+
value: |
44+
```
45+
example
46+
```
47+
validations:
48+
required: false
49+
- type: input
50+
id: keda-http-version
51+
attributes:
52+
label: What version of the KEDA HTTP Addon are you running?
53+
validations:
54+
required: false
55+
- type: dropdown
56+
id: kubernetes-version
57+
attributes:
58+
label: Kubernetes Version
59+
description: What version of Kubernetes that are you running?
60+
options:
61+
- "1.22"
62+
- "1.21"
63+
- "1.20"
64+
- "1.19"
65+
- "1.18"
66+
- "1.17"
67+
- "1.16"
68+
- "< 1.16"
69+
- "Other"
70+
validations:
71+
required: false
72+
- type: dropdown
73+
id: cluster-type
74+
attributes:
75+
label: Platform
76+
description: Where is your cluster running?
77+
options:
78+
- Any
79+
- Alibaba Cloud
80+
- Amazon Web Services
81+
- Google Cloud
82+
- Microsoft Azure
83+
- Red Hat OpenShift
84+
- Other
85+
validations:
86+
required: false
87+
- type: textarea
88+
id: anything-else
89+
attributes:
90+
label: Anything else?
91+
description: "Let us know if you have anything else to share"

.github/ISSUE_TEMPLATE/config.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
blank_issues_enabled: false
1+
blank_issues_enabled: true
22
contact_links:
33
- name: Ask a question or get support
44
url: https://github.com/kedacore/http-add-on/discussions/new

.github/workflows/build_canary.yml

+1
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ jobs:
4747
sh.keda.http.image.source=${{github.event.repository.html_url}}
4848
sh.keda.http.image.created=${{steps.prep.outputs.created}}
4949
sh.keda.http.image.revision=${{github.sha}}
50+
build-args: "VERSION=${{ steps.prep.outputs.sha }}"
5051
file: operator/Dockerfile
5152
context: .
5253
push: true

.github/workflows/build_release.yml

+1
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ jobs:
5050
sh.keda.http.image.created=${{steps.prep.outputs.created}}
5151
sh.keda.http.image.revision=${{github.sha}}
5252
sh.keda.http.image.release=${{github.ref}}
53+
build-args: "VERSION=${{ steps.prep.outputs.VERSION }}"
5354
file: operator/Dockerfile
5455
context: .
5556
push: true

.github/workflows/images.yaml

+9-6
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,9 @@ jobs:
1313
steps:
1414
- uses: actions/checkout@v2
1515
- name: Build The Scaler
16-
run:
17-
docker build -t scaler -f scaler/Dockerfile .
16+
run: |
17+
COMMIT=$(git rev-parse --short HEAD)
18+
docker build --build-arg VERSION=${COMMIT} -t scaler -f scaler/Dockerfile .
1819
1920
build_operator:
2021

@@ -23,8 +24,9 @@ jobs:
2324
steps:
2425
- uses: actions/checkout@v2
2526
- name: Build The Operator
26-
run:
27-
docker build -t operator -f operator/Dockerfile .
27+
run: |
28+
COMMIT=$(git rev-parse --short=7 HEAD)
29+
docker build --build-arg VERSION=${COMMIT} -t operator -f operator/Dockerfile .
2830
2931
build_interceptor:
3032

@@ -33,5 +35,6 @@ jobs:
3335
steps:
3436
- uses: actions/checkout@v2
3537
- name: Build The Interceptor
36-
run:
37-
docker build -t interceptor -f interceptor/Dockerfile .
38+
run: |
39+
COMMIT=$(git rev-parse --short=7 HEAD)
40+
docker build --build-arg VERSION=${COMMIT} -t interceptor -f interceptor/Dockerfile .

.github/workflows/tests.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ jobs:
1515
- name: Install Go
1616
uses: actions/setup-go@v2
1717
with:
18-
go-version: 1.16.x
18+
go-version: 1.17.2
1919
- name: Test
2020
run: go test ./...

.whitesource

+12
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
{
2+
"scanSettings": {
3+
"baseBranches": []
4+
},
5+
"checkRunSettings": {
6+
"vulnerableCheckRunConclusionLevel": "failure",
7+
"displayMode": "diff"
8+
},
9+
"issueSettings": {
10+
"minSeverityLevel": "LOW"
11+
}
12+
}

RELEASE-PROCESS.md

+32-28
Original file line numberDiff line numberDiff line change
@@ -4,32 +4,12 @@ The process of releasing a new version of the KEDA HTTP Addon involves a few ste
44

55
>The process herein is largely automated but we recognize that there may be more that we can automate. If you find something that _can_ and _should_ be automated, and you believe that you know how, please [submit an issue](https://github.com/kedacore/http-add-on/issues/new?assignees=&labels=needs-discussion%2Cfeature-request&template=Feature_request.md) explaining how.
66
7-
## 0: Current and new versions
7+
## 1: Current and new versions
88

99
Please go to the [releases page](https://github.com/kedacore/http-add-on/releases) and observe what the most recent release is. Specifically, note what the _tag_ of the release is. For example, if [version 0.1.0](https://github.com/kedacore/http-add-on/releases/tag/v0.1.0) is the latest release (it is as the time of this writing), the tag for that is `v0.1.0`.
1010

1111
To determine the new version, follow [SemVer guidelines](https://semver.org). Most releases will increment the PATCH or MINOR version number.
1212

13-
## 1: Update the [Helm Charts Repository](https://github.com/kedacore/charts)
14-
15-
The scope of the changes you'll need to make to the Helm chart vary from just changing the `appVersion` field in the [Chart.yaml file](https://github.com/kedacore/charts/blob/master/http-add-on/Chart.yaml) to changing the `HTTPScaledObject` CRD, adding new configuration, or even adding/changing components.
16-
17-
You must, at a minimum, change that `appVersion` field to the new version number, however.
18-
19-
If you have chosen `1.2.3`, for example, the `appVersion` field should read:
20-
21-
```yaml
22-
appVersion: 1.2.3
23-
```
24-
25-
See the below steps for updating the Helm chart:
26-
27-
1. Submit a Pull Request (PR) to the [github.com/kedacore/charts](https://github.com/kedacore/charts) repository with your changes. Also ensure that you follow the [Shipping a new version](https://github.com/kedacore/charts/blob/master/CONTRIBUTING.md#shipping-a-new-version) guidelines in the charts documentation to complete the chart release.
28-
- Your chart changes must go into the [http-add-on](https://github.com/kedacore/charts/tree/master/http-add-on) directory. The release artifact will go into the [docs](https://github.com/kedacore/charts/tree/master/docs) directory.
29-
- Ensure that you add a link to the HTTP Addon repository and the new release number, so that PR reviewers are aware what the work relates to
30-
2. Ensure that the Pull Request is reviewed and merged
31-
- This may require collaboration with reviewers and appropriate changes
32-
3313
## 2: Create a new GitHub release
3414

3515
[Create a new release](https://github.com/kedacore/http-add-on/releases/new) on the GitHub releases page, using your new release number.
@@ -40,20 +20,44 @@ The release description should be a short to medium length summary of what has c
4020

4121
After you create the new release, automation in a GitHub action will build and deploy new container images.
4222

43-
## 3: Update the [Artifact Hub Manifest](https://github.com/kedacore/external-scalers/tree/master/artifacthub)
23+
## 3: Submit a PR to the [Helm Charts Repository](https://github.com/kedacore/charts)
4424

45-
The HTTP Addon is listed on [ArtifactHub](https://artifacthub.io/packages/helm/kedacore/keda-add-ons-http), and its configuration is at [github.com/kedacore/external-scalers](https://github.com/kedacore/external-scalers).
25+
The scope of the changes you'll need to make to the Helm chart vary, but the below list is the minimum set of fields to change:
4626

47-
If you're releasing a new version of the HTTP Addon, you'll need to update that repository. Submit a new pull request to that repository with includes a new directory under `artifacthub/add-ons-http` called the same thing as the release version. If you're releasing version `1.2.3`, the directory should be called that. To create that directory, do this:
27+
- The `appVersion` field in `Chart.yaml`. If you've chosen `1.2.3` as the version number, this field should read:
4828

29+
```yaml
30+
appVersion: 1.2.3
4931
```
50-
cp -R artifacthub/add-ons-http/<previous version> artifacthub/add-ons-http/<new version>
32+
33+
- The `images.tag` field in `values.yaml`. If you've chosen `1.2.3` as the version number, this field should read:
34+
35+
```yaml
36+
images:
37+
# tag is the image tag to use for all images.
38+
# for example, if the operator image is "myoperator" and
39+
# tag is "mytag", the operator image used will be
40+
# "myoperator:mytag". `latest` is used to indicate the latest
41+
# stable release in the official images, `canary` is
42+
# the build for the latest commit to the `main` branch,
43+
# and you can target any other commit with `sha-<GIT_SHA[0:7]>`
44+
tag: 1.2.3
5145
```
5246
53-
Then, in the new `artifacthub-pkg.yml` file under the new directory, append a new list item under the `changes` section.
47+
>Note: the container images generated by CI/CD in step 2 will have the same tag as the tag you created in the release, minus the `v` prefix. You can always see what images created by going to the container registry page for the [interceptor](https://github.com/orgs/kedacore/packages/container/package/http-add-on-interceptor), [operator](https://github.com/kedacore/http-add-on/pkgs/container/http-add-on-operator) or [scaler](https://github.com/kedacore/http-add-on/pkgs/container/http-add-on-scaler)
5448

55-
Once you're finished with these steps, submit a PR to the [github.com/kedacore/external-scalers](https://github.com/kedacore/external-scalers) repository with your changes.
49+
50+
Once you've made changes to the chart, here's how to do submit the change to the charts repository:
51+
52+
- Submit a Pull Request (PR) to the [github.com/kedacore/charts](https://github.com/kedacore/charts) repository with your changes. Also ensure that you follow the [Shipping a new version](https://github.com/kedacore/charts/blob/master/CONTRIBUTING.md#shipping-a-new-version) guidelines in the charts documentation to complete the chart release.
53+
- Your chart changes must go into the [http-add-on](https://github.com/kedacore/charts/tree/master/http-add-on) directory. The release artifact will go into the [docs](https://github.com/kedacore/charts/tree/master/docs) directory.
54+
- Ensure that you add a link to the HTTP Addon repository and the new release number, so that PR reviewers are aware what the work relates to
55+
- Work with the maintainers of that repository to get the chart merged
56+
57+
After your PR is merged, you've completed the release. Congratulations! You can optionally write a blog post about it; see the next section if you're interested.
5658

5759
## 4: Write a blog post on the documentation site (_optional_)
5860

59-
If you believe that your release is large enough to warrant a blog post on the [keda.sh/blog](https://keda.sh/blog/) site, please go to [github.com/kedacore/keda-docs](https://github.com/kedacore/keda-docs) and submit a new PR with a blog article about the release. Include in the article a longer summary of changes and any important information about the new functionality, bugfixes, or anything else appropriate. The post should go into the [content/blog](https://github.com/kedacore/keda-docs/tree/master/content/blog) directory.
61+
If you believe that your release is large enough to warrant a blog post on the [keda.sh/blog](https://keda.sh/blog/) site, please go to [github.com/kedacore/keda-docs](https://github.com/kedacore/keda-docs) and submit a new PR with a blog article about the release.
62+
63+
Include in the article a longer summary of changes and any important information about the new functionality, bugfixes, or anything else appropriate. The post should go into the [content/blog](https://github.com/kedacore/keda-docs/tree/master/content/blog) directory.

docs/install.md

+10-2
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,13 @@ The HTTP Add On is highly modular and, as expected, builds on top of KEDA core.
66
- **Scaler** - communicates scaling-related metrics to KEDA. By default, the operator will install this for you as necessary.
77
- **Interceptor** - a cluster-internal proxy that proxies incoming HTTP requests, communicating HTTP queue size metrics to the scaler, and holding requests in a temporary request queue when there are not yet any available app `Pod`s ready to serve. By default, the operator will install this for you as necessary.
88

9-
>There is [pending work in KEDA](https://github.com/kedacore/keda/issues/615) that will eventually make this component optional. See [issue #6 in this repository](https://github.com/kedacore/http-add-on/issues/6) for even more background
9+
>There is [pending work](https://github.com/kedacore/http-add-on/issues/354) that may eventually make this component optional.
1010
11+
## Before You Start: Cluster-global vs. Namespaced installation
12+
13+
Both KEDA and the HTTP Addon can be installed in either cluster-global or namespaced mode. In the former case, your `ScaledObject`s and `HTTPScaledObject`s (respectively) can be installed in any namespace, and one installation will detect and process it. In the latter case, you must install your `ScaledObject`s and `HTTPScaledObject`s in a specific namespace.
14+
15+
You have the option of installing KEDA and the HTTP Addon in either mode, but if you install one as cluster-global, the other must also be cluster-global. Similarly, if you install one as namespaced, the also must also be namespaced in the same namespace.
1116
## Installing KEDA
1217

1318
Before you install any of these components, you need to install KEDA. Below are simplified instructions for doing so with [Helm](https://helm.sh), but if you need anything more customized, please see the [official KEDA deployment documentation](https://keda.sh/docs/2.0/deploy/). If you need to install Helm, refer to the [installation guide](https://helm.sh/docs/intro/install/).
@@ -17,16 +22,19 @@ Before you install any of these components, you need to install KEDA. Below are
1722
```console
1823
helm repo add kedacore https://kedacore.github.io/charts
1924
helm repo update
20-
helm install keda kedacore/keda --namespace ${NAMESPACE} --set watchNamespace=${NAMESPACE} --create-namespace
25+
helm install keda kedacore/keda --namespace ${NAMESPACE} --create-namespace
2126
```
2227

28+
>The above command installs KEDA in cluster-global mode. Add `--set watchNamespace=<target namespace>` to install KEDA in namespaced mode.
29+
2330
## Install via Helm Chart
2431

2532
The Helm chart for this project is within KEDA's default helm repository at [kedacore/charts](http://github.com/kedacore/charts), you can install it by running:
2633

2734
```console
2835
helm install http-add-on kedacore/keda-add-ons-http --namespace ${NAMESPACE}
2936
```
37+
>The above command installed the HTTP Addon in cluster-global mode. Add `--set operator.watchNamespace=<target namespace>` to install the HTTP Addon in namepaced mode. If you do this, you must also install KEDA in namespaced mode and use the same target namespace.
3038
3139
>Installing the HTTP add on won't affect any running workloads in your cluster. You'll need to install an `HTTPScaledObject` for each individual `Deployment` you want to scale. For more on how to do that, please see the [walkthrough](./walkthrough.md).
3240

docs/ref/v0.2.0/http_scaled_object.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@ metadata:
1111
name: xkcd
1212
spec:
1313
host: "myhost.com"
14+
targetPendingRequests: 100
1415
scaleTargetRef:
1516
deployment: xkcd
1617
service: xkcd
1718
port: 8080
18-
targetPendingRequests: 100
1919
```
2020
2121
This document is a narrated reference guide for the `HTTPScaledObject`, and we'll focus on the `spec` field.

docs/walkthrough.md

+16-2
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,16 @@ helm install xkcd ./examples/xkcd -n ${NAMESPACE}
1616

1717
You'll need to clone the repository to get access to this chart. If you have your own `Deployment` and `Service` installed, you can go right to creating an `HTTPScaledObject` in the next section.
1818

19+
>If you are running KEDA and the HTTP Addon in cluster-global mode, you can install the XKCD chart in any namespace you choose. If you do so, make sure you add `--set ingressNamespace=${NAMESPACE}` to the above installation command.
20+
1921
>To remove the app, run `helm delete xkcd -n ${NAMESPACE}`
2022
2123
## Creating an `HTTPScaledObject`
2224

23-
You interact with the operator via a CRD called `HTTPScaledObject`. This CRD object points the To get an example app up and running, read the notes below and then run the subsequent command from the root of this repository.
25+
You interact with the operator via a CRD called `HTTPScaledObject`. This CRD object instructs interceptors to forward requests for a given host to your app's backing `Service`. To get an example app up and running, read the notes below and then run the subsequent command from the root of this repository.
2426

2527
```shell
26-
kubectl create -f -n $NAMESPACE examples/v0.0.2/httpscaledobject.yaml
28+
kubectl create -n $NAMESPACE -f examples/v0.2.0/httpscaledobject.yaml
2729
```
2830

2931
>If you'd like to learn more about this object, please see the [`HTTPScaledObject` reference](./ref/v0.2.0/http_scaled_object.md).
@@ -65,3 +67,15 @@ An [`Ingress`](https://kubernetes.io/docs/concepts/services-networking/ingress/)
6567
When you're ready, please run `kubectl get svc -n ${NAMESPACE}`, find the `ingress-nginx-controller` service, and copy and paste its `EXTERNAL-IP`. This is the IP address that your application will be running at on the public internet.
6668

6769
>Note: you should go further and set your DNS records appropriately and set up a TLS certificate for this IP address. Instructions to do that are out of scope of this document, though.
70+
71+
### Making an HTTP Request to your App
72+
73+
Now that you have your application running and your ingress configured, you can issue an HTTP request. To do so, you'll need to know the IP address to request. If you're using an ingress controller, that is the IP of the ingress controller's `Service`. If you're using a "raw" `Service` with `type: LoadBalancer`, that is the IP address of the `Service` itself.
74+
75+
Regardless, you can use the below `curl` command to make a request to your application:
76+
77+
```shell
78+
curl -H "Host: myhost.com" <Your IP>
79+
```
80+
81+
>Note the `-H` flag above to specify the `Host` header. This is needed to tell the interceptor how to route the request. If you have a DNS name set up for the IP, you don't need this header.

examples/xkcd/templates/httpscaledobject.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ metadata:
44
name: {{ include "xkcd.fullname" . }}
55
spec:
66
host: {{ .Values.host }}
7+
targetPendingRequests: {{ .Values.targetPendingRequests }}
78
scaleTargetRef:
89
deployment: {{ include "xkcd.fullname" . }}
910
service: {{ include "xkcd.fullname" . }}

examples/xkcd/templates/ingress.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ apiVersion: networking.k8s.io/v1
22
kind: Ingress
33
metadata:
44
name: {{ include "xkcd.fullname" . }}
5+
namespace: {{ .Values.ingressNamespace | default .Release.Namespace }}
56
annotations:
67
nginx.ingress.kubernetes.io/rewrite-target: /
78
kubernetes.io/ingress.class: nginx

0 commit comments

Comments
 (0)