Skip to content

Commit fc2dab7

Browse files
chrisbobbegnprice
authored andcommitted
android/deps: compileSdkVersion to 33 (Android 13); image-picker to 4.10.2
Seems like react-native-image-picker made it *possible* to build on the new SDK in the same commit where they made it *necessary* to do so, which was a bad choice: zulip#5543 (comment) So, shove the sdk bump and this image-picker upgrade together into one commit. Anyway, as Greg said in his draft of the compileSdkVersion bump, f5c90ec: This version is out; time to start using it in the build. This setting is not to be confused with the targetSdkVersion. The latter goes into the built manifest, and affects a wide range of behavior, so bumping it requires careful testing. This is used purely at build time, and should have no effect on runtime behavior. Its main effect is that it become possible for code to conditionally use new API features. It also brings new compiler warnings -- hence the pair of library updates preceding this. We take the latest image-picker version, but in particular at least 4.10.1, to get a bugfix for an image-orientation issue: react-native-image-picker/react-native-image-picker#2036 that was reportedly introduced in 4.8.5: react-native-image-picker/react-native-image-picker#2022
1 parent 07eebd7 commit fc2dab7

File tree

7 files changed

+42
-17
lines changed

7 files changed

+42
-17
lines changed

android/build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ buildscript {
1919
// https://medium.com/androiddevelopers/picking-your-compilesdkversion-minsdkversion-targetsdkversion-a098a0341ebd
2020
// What's the latest? Consult this list:
2121
// https://developer.android.com/studio/releases/platforms
22-
compileSdkVersion = 31
22+
compileSdkVersion = 33
2323
}
2424
repositories {
2525
google()

ios/Podfile.lock

+2-2
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@ PODS:
310310
- glog
311311
- react-native-cameraroll (5.0.4):
312312
- React-Core
313-
- react-native-image-picker (4.8.4):
313+
- react-native-image-picker (4.10.2):
314314
- React-Core
315315
- react-native-netinfo (6.0.0):
316316
- React-Core
@@ -723,7 +723,7 @@ SPEC CHECKSUMS:
723723
React-jsinspector: eb202e43b3879aba9a14f3f65788aec85d4e1ea9
724724
React-logger: 98f663b292a60967ebbc6d803ae96c1381183b6d
725725
react-native-cameraroll: 38b40d9033e4077b6c603f92f95c6d05fa7907df
726-
react-native-image-picker: cffb727cf2f59bd5c0408e30b3dbe0b935f88835
726+
react-native-image-picker: bf34f3f516d139ed3e24c5f5a381a91819e349ea
727727
react-native-netinfo: e849fc21ca2f4128a5726c801a82fc6f4a6db50d
728728
react-native-photo-view: ea0ec91bf5991a6843e740b1f47ab355171c996c
729729
react-native-safe-area-context: 99b24a0c5acd0d5dcac2b1a7f18c49ea317be99a

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
"react-native-device-info": "^8.1.7",
6060
"react-native-document-picker": "^3.2.4",
6161
"react-native-gesture-handler": "^2.8.0",
62-
"react-native-image-picker": "4.8.4",
62+
"react-native-image-picker": "4.10.2",
6363
"react-native-photo-view": "alwx/react-native-photo-view#91b873c85",
6464
"react-native-reanimated": "^2.2.0 <2.3.0",
6565
"react-native-safe-area-context": "^4.3.1",
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,14 @@
11
/* @flow
22
* @generated by TsFlower
33
*/
4-
import {
5-
type CameraOptions,
6-
type ImageLibraryOptions,
7-
type Callback,
8-
type ImagePickerResponse,
9-
} from './types';
10-
4+
import type { ImagePickerResponse as $tsflower_import_type$_$_2e__2f_types$ImagePickerResponse } from './types';
5+
import { type CameraOptions, type ImageLibraryOptions, type Callback } from './types';
116
export * from './types';
127
declare export function launchCamera(
138
options: CameraOptions,
149
callback?: Callback,
15-
): Promise<ImagePickerResponse>;
10+
): Promise<$tsflower_import_type$_$_2e__2f_types$ImagePickerResponse>;
1611
declare export function launchImageLibrary(
1712
options: ImageLibraryOptions,
1813
callback?: Callback,
19-
): Promise<ImagePickerResponse>;
14+
): Promise<$tsflower_import_type$_$_2e__2f_types$ImagePickerResponse>;
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
/* @flow
2+
* @generated by TsFlower
3+
*/
4+
import {
5+
type CameraOptions,
6+
type ImageLibraryOptions,
7+
type Callback,
8+
type ImagePickerResponse,
9+
} from '../types';
10+
11+
declare export function camera(
12+
options: CameraOptions,
13+
callback?: Callback,
14+
): Promise<ImagePickerResponse>;
15+
declare export function imageLibrary(
16+
options: ImageLibraryOptions,
17+
callback?: Callback,
18+
): Promise<ImagePickerResponse>;
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
/* @flow
2+
* @generated by TsFlower
3+
*/
4+
import { type ImageLibraryOptions, type Callback, type ImagePickerResponse } from '../types';
5+
declare export function camera(
6+
options?: ImageLibraryOptions,
7+
callback?: Callback,
8+
): Promise<ImagePickerResponse>;
9+
declare export function imageLibrary(
10+
options?: ImageLibraryOptions,
11+
callback?: Callback,
12+
): Promise<ImagePickerResponse>;

yarn.lock

+4-4
Original file line numberDiff line numberDiff line change
@@ -10222,10 +10222,10 @@ react-native-gradle-plugin@^0.0.6:
1022210222
resolved "https://registry.yarnpkg.com/react-native-gradle-plugin/-/react-native-gradle-plugin-0.0.6.tgz#b61a9234ad2f61430937911003cddd7e15c72b45"
1022310223
integrity sha512-eIlgtsmDp1jLC24dRn43hB3kEcZVqx6DUQbR0N1ABXGnMEafm9I3V3dUUeD1vh+Dy5WqijSoEwLNUPLgu5zDMg==
1022410224

10225-
react-native-image-picker@4.8.4:
10226-
version "4.8.4"
10227-
resolved "https://registry.yarnpkg.com/react-native-image-picker/-/react-native-image-picker-4.8.4.tgz#ac52f1e265458e944664adf1dcd0a9ee408fe083"
10228-
integrity sha512-Mjh2j/sddyolb16EpmprWzbtyeFvW8Xgzr/8WNi9d6bR2FC/kL78cY/a+7Yzujg5ZDtT1MWys+eWw/qtfwgGiw==
10225+
react-native-image-picker@4.10.2:
10226+
version "4.10.2"
10227+
resolved "https://registry.yarnpkg.com/react-native-image-picker/-/react-native-image-picker-4.10.2.tgz#75b356c9eea70c2c4f5c1089f8758e2fa32f88a8"
10228+
integrity sha512-3h9PrA1dQ84rVeipzQE4eWTELvflSHNtJZN6rz7NkZyaxo9YZV8H/TswBpHwiS5YWlyu+zlLzSoWVa1opSu7GA==
1022910229

1023010230
react-native-iphone-x-helper@^1.3.0:
1023110231
version "1.3.1"

0 commit comments

Comments
 (0)