Skip to content

Preserve previous approvals #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sidharthv96 opened this issue Oct 2, 2024 · 2 comments
Open

Preserve previous approvals #1384

sidharthv96 opened this issue Oct 2, 2024 · 2 comments
Labels

Comments

@sidharthv96
Copy link
Contributor

As a user, after I approve a large set of changes manually, it is difficult to review everything again if there is another push to the branch.

Motivation

Suppose there are 100+ valid changes in a branch, I review each one of them and approve once.
If there is another push to the same PR, then my previous review is discarded, and we have to look at everything again.

It would be wonderful to have a separate "These have changed since your last approval" section, and if there are no changes, auto approve?

Detail

Example PR mermaid-js/mermaid#5825

@gregberge
Copy link
Member

Hello @sidharthv96, we already identified this as a potential feature. Glad you confirmed it's a good one. I keep you up to date when it will be available.

@gregberge gregberge added the feat label Jan 5, 2025
@gregberge gregberge moved this to 📋 Backlog in Argos Roadmap Jan 5, 2025
@gregberge gregberge moved this from 📋 Backlog to 🔖 Ready in Argos Roadmap Jan 5, 2025
@ologbonowiwi
Copy link

Would be great to have this... I'm helping on a docusaurus v3 migration and it's very time consuming to re-review 100+ files at each commit 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🔖 Ready
Development

No branches or pull requests

3 participants