Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestListWorkflows createdAfter fails when executing locally #14346

Open
4 tasks done
jswxstw opened this issue Apr 2, 2025 · 0 comments · May be fixed by #14347
Open
4 tasks done

TestListWorkflows createdAfter fails when executing locally #14346

jswxstw opened this issue Apr 2, 2025 · 0 comments · May be fixed by #14347
Labels
area/contributing Contributing docs, ownership, etc. Also devtools like devcontainer and Nix type/bug

Comments

@jswxstw
Copy link
Member

jswxstw commented Apr 2, 2025

Pre-requisites

  • I have double-checked my configuration
  • I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
  • I have searched existing issues and could not find a match for this bug
  • I'd like to contribute the fix myself (see contributing guide)

What happened? What did you expect to happen?

make test fails as below:

--- FAIL: TestStoreOperation (0.00s)
    --- PASS: TestStoreOperation/TestAddWorkflow (0.00s)
    --- PASS: TestStoreOperation/TestUpdateWorkflow (0.00s)
    --- PASS: TestStoreOperation/TestDeleteWorkflow (0.00s)
    --- PASS: TestStoreOperation/TestListWorkflows (0.00s)
    --- PASS: TestStoreOperation/TestListWorkflows_name (0.00s)
    --- PASS: TestStoreOperation/TestListWorkflows_namePrefix (0.00s)
    --- PASS: TestStoreOperation/TestListWorkflows_namePattern (0.00s)
    --- PASS: TestStoreOperation/TestListWorkflows_finishedBefore (0.00s)
    --- FAIL: TestStoreOperation/TestListWorkflows_createdAfter (0.00s)

Local TimeZone: CST

TestListWorkflows createdAfter list workflows with query:

select workflow from argo_workflows
where instanceid = ?
 and namespace = ? and json_extract(workflow, '$.metadata.creationTimestamp') >= ? order by startedat desc limit ? offset ?

metadata.creationTimestamp is UTC time, but the query input parameter is not.

wfList, err := store.ListWorkflows(context.Background(), "argo", "", time.Now().Format(time.RFC3339), "", metav1.ListOptions{})

Version(s)

ba3441f

Paste a minimal workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflow that uses private images.

UT fails, no workflow

Logs from the workflow controller

kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

Logs from in your workflow's wait container

kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded
@jswxstw jswxstw added type/bug area/contributing Contributing docs, ownership, etc. Also devtools like devcontainer and Nix labels Apr 2, 2025
jswxstw added a commit to jswxstw/argo-workflows that referenced this issue Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/contributing Contributing docs, ownership, etc. Also devtools like devcontainer and Nix type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant