fix: refactor argoKubeClient to start argo server when creating workflowServiceClient (#14401)

Signed-off-by: Jakub Buczak <[email protected]>

Author: jakkubu

pkg/apiclient/argo-kube-client.go

@@ -58,6 +58,7 @@ type argoKubeClient struct {
 	cwfTmplStore      types.ClusterWorkflowTemplateStore
 	wfLister          store.WorkflowLister
 	wfStore           store.WorkflowStore
+	namespace         string
 }
 
 var _ Client = &argoKubeClient{}
@@ -108,18 +109,19 @@ func newArgoKubeClient(ctx context.Context, opts ArgoKubeOpts, clientConfig clie
 		opts:              opts,
 		instanceIDService: instanceIDService,
 		wfClient:          wfClient,
+		namespace:         namespace,
 	}
-	err = client.startStores(restConfig, namespace)
+	err = client.startStores(restConfig)
 	if err != nil {
 		return nil, nil, err
 	}
 
 	return ctx, client, nil
 }
 
-func (a *argoKubeClient) startStores(restConfig *restclient.Config, namespace string) error {
+func (a *argoKubeClient) startStores(restConfig *restclient.Config) error {
 	if a.opts.UseCaching {
-		wftmplInformer, err := workflowtemplateserver.NewInformer(restConfig, namespace)
+		wftmplInformer, err := workflowtemplateserver.NewInformer(restConfig, a.namespace)
 		if err != nil {
 			return err
 		}
@@ -147,7 +149,9 @@ func (a *argoKubeClient) startStores(restConfig *restclient.Config, namespace st
 
 func (a *argoKubeClient) NewWorkflowServiceClient() workflowpkg.WorkflowServiceClient {
 	wfArchive := sqldb.NullWorkflowArchive
-	return &errorTranslatingWorkflowServiceClient{&argoKubeWorkflowServiceClient{workflowserver.NewWorkflowServer(a.instanceIDService, argoKubeOffloadNodeStatusRepo, wfArchive, a.wfClient, a.wfLister, a.wfStore, a.wfTmplStore, a.cwfTmplStore, nil, nil)}}
+	wfServer := workflowserver.NewWorkflowServer(a.instanceIDService, argoKubeOffloadNodeStatusRepo, wfArchive, a.wfClient, a.wfLister, a.wfStore, a.wfTmplStore, a.cwfTmplStore, nil, &a.namespace)
+	go wfServer.Run(a.opts.CachingCloseCh)
+	return &errorTranslatingWorkflowServiceClient{&argoKubeWorkflowServiceClient{wfServer}}
 }
 
 func (a *argoKubeClient) NewCronWorkflowServiceClient() (cronworkflow.CronWorkflowServiceClient, error) {