fix: cronOperator/serverResubmitWf retry create workflow on transient error. Fixes #13970 (#13971)

tczhao · web-flow · commit 9d1d2cd51862 · 2024-12-06T14:36:28.000+11:00
Signed-off-by: Tianchu Zhao &lt;evantczhao@gmail.com&gt;
diff --git a/workflow/util/util.go b/workflow/util/util.go
@@ -195,7 +195,13 @@ func SubmitWorkflow(ctx context.Context, wfIf v1alpha1.WorkflowInterface, wfClie
 		}
 		return wf, err
 	} else {
-		return wfIf.Create(ctx, wf, metav1.CreateOptions{})
+		var runWf *wfv1.Workflow
+		err = waitutil.Backoff(retry.DefaultRetry, func() (bool, error) {
+			var err error
+			runWf, err = wfIf.Create(ctx, wf, metav1.CreateOptions{})
+			return !errorsutil.IsTransientErr(err), err
+		})
+		return runWf, err
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,13 @@ func SubmitWorkflow(ctx context.Context, wfIf v1alpha1.WorkflowInterface, wfClie`
`195`	`195`	`}`
`196`	`196`	`return wf, err`
`197`	`197`	`} else {`
`198`		`- return wfIf.Create(ctx, wf, metav1.CreateOptions{})`
	`198`	`+ var runWf *wfv1.Workflow`
	`199`	`+ err = waitutil.Backoff(retry.DefaultRetry, func() (bool, error) {`
	`200`	`+ var err error`
	`201`	`+ runWf, err = wfIf.Create(ctx, wf, metav1.CreateOptions{})`
	`202`	`+ return !errorsutil.IsTransientErr(err), err`
	`203`	`+ })`
	`204`	`+ return runWf, err`
`199`	`205`	`}`
`200`	`206`	`}`
`201`	`207`