Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show more information in the UI about why Rollout gets aborted #3957

Open
andrii-korotkov-verkada opened this issue Nov 19, 2024 · 1 comment · May be fixed by #4175
Open

Show more information in the UI about why Rollout gets aborted #3957

andrii-korotkov-verkada opened this issue Nov 19, 2024 · 1 comment · May be fixed by #4175
Assignees
@andrii-korotkov-verkada
Labels
enhancement New feature or request

Comments

@andrii-korotkov-verkada
Copy link
Contributor

Summary

Provide more information in status and events about rollout abort before steps with analysis runs.

Use Cases

Right now if the failure happened on the step before analysis run is configured to happen, there might be no indication what went wrong, e.g. no bad events and generic message in status like

- lastTransitionTime: '2024-11-19T21:48:19Z'
  lastUpdateTime: '2024-11-19T21:48:19Z'
  message: Rollout aborted update to revision 386
  reason: RolloutAborted
  status: 'False'
  type: Progressing

The info+ logs weren't helpful either.

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.
@andrii-korotkov-verkada andrii-korotkov-verkada added the enhancement New feature or request label Nov 19, 2024
Closed
@andrii-korotkov-verkada
Copy link
Contributor Author

Here's the relevant code in Rollouts:

	if isAborted {
		revision, _ := replicasetutil.Revision(c.rollout)
		message := fmt.Sprintf(conditions.RolloutAbortedMessage, revision)
		if c.pauseContext.abortMessage != "" {
			message = fmt.Sprintf("%s: %s", message, c.pauseContext.abortMessage)
		}
		condition := conditions.NewRolloutCondition(v1alpha1.RolloutProgressing, corev1.ConditionFalse, conditions.RolloutAbortedReason, message)
		if conditions.SetRolloutCondition(&newStatus, *condition) {
			c.recorder.Warnf(c.rollout, record.EventOptions{EventReason: conditions.RolloutAbortedReason}, message)
		}
	}

So looks like abortMessage can be missing sometimes.
@zachaller, do you know why we won't always have some abort message?

andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/argo-rollouts that referenced this issue Mar 5, 2025
@andrii-korotkov-verkada
chore: Make sure rollouts abort always has some more detailed message (…
ca833ba 
…argoproj#3957)

Closes argoproj#3957

Sometimes the rollout aborted message is just that, without any reason. Adding more detailed abort messages here.

Signed-off-by: Andrii Korotkov <[email protected]>
@andrii-korotkov-verkada andrii-korotkov-verkada linked a pull request Mar 5, 2025 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrii-korotkov-verkada andrii-korotkov-verkada

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@andrii-korotkov-verkada