fix: npe caused by incomplete initialization of dependencies

Author: YongwuHe

arex-instrumentation-api/src/main/java/io/arex/inst/runtime/config/Config.java

@@ -4,6 +4,7 @@
 import io.arex.agent.bootstrap.util.ConcurrentHashSet;
 import io.arex.agent.bootstrap.util.StringUtil;
 import io.arex.inst.runtime.context.RecordLimiter;
+import io.arex.inst.runtime.listener.EventProcessor;
 import io.arex.inst.runtime.model.DynamicClassEntity;
 
 import java.util.ArrayList;
@@ -197,6 +198,9 @@ public boolean isLocalStorage() {
      * @return true: invalid, false: valid
      */
     public boolean invalidRecord(String path) {
+        if (!EventProcessor.dependencyInitComplete()) {
+            return true;
+        }
         if (isLocalStorage()) {
             return false;
         }

arex-instrumentation-api/src/main/java/io/arex/inst/runtime/listener/EventProcessor.java

@@ -41,7 +41,7 @@ public class EventProcessor {
      * the onRequest method must be called before calling the onCreate method
      */
     public static void onCreate(EventSource source){
-        if (!InitializeEnum.COMPLETE.equals(INIT_DEPENDENCY.get())) {
+        if (!dependencyInitComplete()) {
             return;
         }
         initContext(source);
@@ -131,4 +131,8 @@ private static void initLog(ClassLoader contextClassLoader) {
         List<Logger> extensionLoggerList = ServiceLoader.load(Logger.class, contextClassLoader);
         LogManager.build(extensionLoggerList);
     }
+
+    public static boolean dependencyInitComplete() {
+        return InitializeEnum.COMPLETE.equals(INIT_DEPENDENCY.get());
+    }
 }

arex-instrumentation-api/src/test/java/io/arex/inst/runtime/config/ConfigTest.java

@@ -3,16 +3,22 @@
 import io.arex.agent.bootstrap.constants.ConfigConstants;
 import io.arex.agent.bootstrap.util.ConcurrentHashSet;
 import io.arex.inst.runtime.context.RecordLimiter;
+import io.arex.inst.runtime.listener.EventProcessor;
 import io.arex.inst.runtime.model.ArexConstants;
 import io.arex.inst.runtime.model.DynamicClassEntity;
 import java.util.Arrays;
 import java.util.HashSet;
 import java.util.List;
+
+import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.Arguments;
 import org.junit.jupiter.params.provider.MethodSource;
+import org.mockito.MockedStatic;
+import org.mockito.Mockito;
 
 import java.util.function.Predicate;
 import java.util.stream.Stream;
@@ -21,6 +27,15 @@
 import static org.junit.jupiter.params.provider.Arguments.arguments;
 
 class ConfigTest {
+    @BeforeAll
+    static void setUp() {
+        Mockito.mockStatic(EventProcessor.class);
+    }
+
+    @AfterAll
+    static void tearDown() {
+        Mockito.clearAllCaches();
+    }
 
     @ParameterizedTest
     @MethodSource("invalidCase")
@@ -32,27 +47,38 @@ void invalidRecord(Runnable mocker, Predicate<Boolean> predicate) {
     static Stream<Arguments> invalidCase() {
         ConfigBuilder config = ConfigBuilder.create("mock");
         Runnable mocker1 = () -> {
+            Mockito.when(EventProcessor.dependencyInitComplete()).thenReturn(true);
             config.addProperty(ConfigConstants.STORAGE_SERVICE_MODE, "local").build();;
         };
         Runnable mocker2 = () -> {
+            Mockito.when(EventProcessor.dependencyInitComplete()).thenReturn(true);
             config.addProperty(ConfigConstants.STORAGE_SERVICE_MODE, "").build();;
             config.recordRate(0).build();
         };
         Runnable mocker3 = () -> {
+            Mockito.when(EventProcessor.dependencyInitComplete()).thenReturn(true);
             config.recordRate(1).build();
         };
         Runnable mocker4 = () -> {
+            Mockito.when(EventProcessor.dependencyInitComplete()).thenReturn(true);
             config.addProperty(ConfigConstants.DURING_WORK, "true").build();;
         };
         Runnable mocker5 = () -> {
+            Mockito.when(EventProcessor.dependencyInitComplete()).thenReturn(true);
             config.addProperty(ConfigConstants.AGENT_ENABLED, "true").build();
             RecordLimiter.init(mock -> true);
         };
         Runnable disableRecord = () -> {
+            Mockito.when(EventProcessor.dependencyInitComplete()).thenReturn(true);
             config.addProperty(ConfigConstants.DISABLE_RECORD, "true").build();;
             RecordLimiter.init(mock -> true);
         };
 
+        Runnable dependencyNotInitComplete = () -> {
+            Mockito.when(EventProcessor.dependencyInitComplete()).thenReturn(false);
+            config.build();;
+        };
+
         Predicate<Boolean> assertFalse = result -> !result;
         Predicate<Boolean> assertTrue = result -> result;
         return Stream.of(
@@ -61,7 +87,8 @@ static Stream<Arguments> invalidCase() {
             arguments(mocker3, assertTrue),
             arguments(mocker4, assertTrue),
             arguments(mocker5, assertFalse),
-            arguments(disableRecord, assertTrue)
+            arguments(disableRecord, assertTrue),
+            arguments(dependencyNotInitComplete, assertTrue)
         );
     }