Skip to content

Commit bae60ab

Browse files
committed
fix: get response bytes error
1 parent 9717461 commit bae60ab

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

arex-instrumentation/httpclient/arex-httpclient-ning/src/main/java/io/arex/inst/httpclient/ning/NingHttpClientAdapter.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,14 +77,13 @@ public HttpResponseWrapper wrap(Object response) {
7777
if (response instanceof Response) {
7878
Response tempResponse = (Response) response;
7979
httpResponseWrapper.setStatusLine(tempResponse.getStatusText());
80-
httpResponseWrapper.setContent(tempResponse.getResponseBodyAsBytes());
80+
httpResponseWrapper.setContent(getBytesFromString(tempResponse.getResponseBody()));
8181
httpResponseWrapper.setHeaders(buildHeaders(tempResponse.getHeaders()));
8282
httpResponseWrapper.setStatusCode(tempResponse.getStatusCode());
8383
return httpResponseWrapper;
8484
}
8585
String responseString = Serializer.serialize(response);
86-
httpResponseWrapper.setContent(StringUtil.isEmpty(responseString) ?
87-
ZERO_BYTE : responseString.getBytes(StandardCharsets.UTF_8));
86+
httpResponseWrapper.setContent(getBytesFromString(responseString));
8887
httpResponseWrapper.setTypeName(TypeUtil.getName(response));
8988
return httpResponseWrapper;
9089
} catch (Exception e) {
@@ -93,6 +92,11 @@ public HttpResponseWrapper wrap(Object response) {
9392
}
9493
}
9594

95+
private byte[] getBytesFromString(String responseBody) {
96+
return StringUtil.isEmpty(responseBody) ?
97+
ZERO_BYTE : responseBody.getBytes(StandardCharsets.UTF_8);
98+
}
99+
96100
private List<HttpResponseWrapper.StringTuple> buildHeaders(FluentCaseInsensitiveStringsMap headers) {
97101
List<HttpResponseWrapper.StringTuple> headerList = new ArrayList<>(headers.size());
98102
for (Map.Entry<String, List<String>> entry : headers.entrySet()) {

arex-instrumentation/httpclient/arex-httpclient-ning/src/test/java/io/arex/inst/httpclient/ning/NingHttpClientAdapterTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ void getUri() {
9696
void wrap() throws IOException {
9797
Response response = mock(Response.class);
9898
when(response.getStatusText()).thenReturn("OK");
99-
when(response.getResponseBodyAsBytes()).thenReturn("test".getBytes());
99+
when(response.getResponseBody()).thenReturn("test");
100100
when(response.getStatusCode()).thenReturn(200);
101101
FluentCaseInsensitiveStringsMap map = new FluentCaseInsensitiveStringsMap();
102102
map.add("key", "value1");

0 commit comments

Comments
 (0)