fix: dubbo replay NPE if null (#451)

Author: lucas-myx

arex-instrumentation/dubbo/arex-dubbo-alibaba/src/main/java/io/arex/inst/dubbo/alibaba/DubboAdapter.java

@@ -193,6 +193,7 @@ public Map<String, String> getServerAttachment() {
      * < 2.6.3 not support serverContext
      */
     public void setServerAttachment(String key, String val) {
+        RpcContext.getContext().setAttachment(key, val);
         if (SERVER_CONTEXT_METHOD != null) {
             RpcContext.getServerContext().setAttachment(key, val);
         }

arex-instrumentation/dubbo/arex-dubbo-alibaba/src/main/java/io/arex/inst/dubbo/alibaba/DubboConsumerExtractor.java

@@ -30,19 +30,16 @@ private Mocker makeMocker() {
     public MockResult replay() {
         Object result = MockUtils.replayBody(makeMocker());
         boolean ignoreMockResult = IgnoreUtils.ignoreMockResult(adapter.getPath(), adapter.getOperationName());
-        RpcResult rpcResult = null;
-        if (result != null && !ignoreMockResult) {
-            rpcResult = new RpcResult();
-            boolean isAsync = RpcUtils.isAsync(adapter.getUrl(), adapter.getInvocation());
-            if (isAsync) {
-                ResponseFuture future = new SimpleFuture(result);
-                RpcContext.getContext().setFuture(new FutureAdapter<>(future));
+        RpcResult rpcResult = new RpcResult();
+        boolean isAsync = RpcUtils.isAsync(adapter.getUrl(), adapter.getInvocation());
+        if (isAsync) {
+            ResponseFuture future = new SimpleFuture(result);
+            RpcContext.getContext().setFuture(new FutureAdapter<>(future));
+        } else {
+            if (result instanceof Throwable) {
+                rpcResult.setException((Throwable) result);
             } else {
-                if (result instanceof Throwable) {
-                    rpcResult.setException((Throwable) result);
-                } else {
-                    rpcResult.setValue(result);
-                }
+                rpcResult.setValue(result);
             }
         }
         return MockResult.success(ignoreMockResult, rpcResult);

arex-instrumentation/dubbo/arex-dubbo-apache-v2/src/main/java/io/arex/inst/dubbo/apache/v2/DubboConsumerExtractor.java

@@ -28,26 +28,24 @@ private Mocker makeMocker() {
     public MockResult replay() {
         Object result = MockUtils.replayBody(makeMocker());
         boolean ignoreMockResult = IgnoreUtils.ignoreMockResult(adapter.getPath(), adapter.getOperationName());
-        AsyncRpcResult asyncRpcResult = null;
-        if (result != null && !ignoreMockResult) {
-            Invocation invocation = adapter.getInvocation();
-            if (result instanceof Throwable) {
-                asyncRpcResult = AsyncRpcResult.newDefaultAsyncResult((Throwable) result, invocation);
-            } else {
-                asyncRpcResult = AsyncRpcResult.newDefaultAsyncResult(result, invocation);
-            }
-            // need to set invoke mode to FUTURE if return type is CompletableFuture
-            if (invocation instanceof RpcInvocation) {
-                RpcInvocation rpcInv = (RpcInvocation) invocation;
-                rpcInv.setInvokeMode(RpcUtils.getInvokeMode(adapter.getUrl(), invocation));
-            }
-            // compatible with dubbo 2.7.8, refer to org.apache.dubbo.rpc.protocol.AbstractInvoker.invoke
-            CompletableFuture<AppResponse> future = new CompletableFuture<>();
-            future.complete((AppResponse)asyncRpcResult.getAppResponse());
-            RpcContext.getContext().setFuture(new FutureAdapter<AppResponse>(future));
-            // save for 2.6.x compatibility, for example, TraceFilter in Zipkin uses com.alibaba.xxx.FutureAdapter
-            FutureContext.getContext().setCompatibleFuture(future);
+        AsyncRpcResult asyncRpcResult;
+        Invocation invocation = adapter.getInvocation();
+        if (result instanceof Throwable) {
+            asyncRpcResult = AsyncRpcResult.newDefaultAsyncResult((Throwable) result, invocation);
+        } else {
+            asyncRpcResult = AsyncRpcResult.newDefaultAsyncResult(result, invocation);
         }
+        // need to set invoke mode to FUTURE if return type is CompletableFuture
+        if (invocation instanceof RpcInvocation) {
+            RpcInvocation rpcInv = (RpcInvocation) invocation;
+            rpcInv.setInvokeMode(RpcUtils.getInvokeMode(adapter.getUrl(), invocation));
+        }
+        // compatible with dubbo 2.7.8, refer to org.apache.dubbo.rpc.protocol.AbstractInvoker.invoke
+        CompletableFuture<AppResponse> future = new CompletableFuture<>();
+        future.complete((AppResponse)asyncRpcResult.getAppResponse());
+        RpcContext.getContext().setFuture(new FutureAdapter<AppResponse>(future));
+        // save for 2.6.x compatibility, for example, TraceFilter in Zipkin uses com.alibaba.xxx.FutureAdapter
+        FutureContext.getContext().setCompatibleFuture(future);
         return MockResult.success(ignoreMockResult, asyncRpcResult);
     }
 }

arex-instrumentation/dubbo/arex-dubbo-apache-v3/src/main/java/io/arex/inst/dubbo/apache/v3/DubboConsumerExtractor.java

@@ -24,21 +24,19 @@ private Mocker makeMocker() {
     public MockResult replay() {
         Object result = MockUtils.replayBody(makeMocker());
         boolean ignoreMockResult = IgnoreUtils.ignoreMockResult(adapter.getPath(), adapter.getOperationName());
-        AsyncRpcResult asyncRpcResult = null;
-        if (result != null && !ignoreMockResult) {
-            Invocation invocation = adapter.getInvocation();
-            if (result instanceof Throwable) {
-                asyncRpcResult = AsyncRpcResult.newDefaultAsyncResult((Throwable) result, invocation);
-            } else {
-                asyncRpcResult = AsyncRpcResult.newDefaultAsyncResult(result, invocation);
-            }
-            // need to set invoke mode to FUTURE if return type is CompletableFuture
-            if (invocation instanceof RpcInvocation) {
-                RpcInvocation rpcInv = (RpcInvocation) invocation;
-                rpcInv.setInvokeMode(RpcUtils.getInvokeMode(adapter.getUrl(), invocation));
-            }
-            RpcContext.getContext().setFuture(new FutureAdapter<>(asyncRpcResult.getResponseFuture()));
+        AsyncRpcResult asyncRpcResult;
+        Invocation invocation = adapter.getInvocation();
+        if (result instanceof Throwable) {
+            asyncRpcResult = AsyncRpcResult.newDefaultAsyncResult((Throwable) result, invocation);
+        } else {
+            asyncRpcResult = AsyncRpcResult.newDefaultAsyncResult(result, invocation);
         }
+        // need to set invoke mode to FUTURE if return type is CompletableFuture
+        if (invocation instanceof RpcInvocation) {
+            RpcInvocation rpcInv = (RpcInvocation) invocation;
+            rpcInv.setInvokeMode(RpcUtils.getInvokeMode(adapter.getUrl(), invocation));
+        }
+        RpcContext.getContext().setFuture(new FutureAdapter<>(asyncRpcResult.getResponseFuture()));
         return MockResult.success(ignoreMockResult, asyncRpcResult);
     }
 }