fix: support exclusiveMinimum & exclusiveMaximum boolean values (#1609)

Author: ardatan

.changeset/rotten-parrots-draw.md

@@ -0,0 +1,5 @@
+---
+'fets': patch
+---
+
+Support `exclusiveMinimum` or `exclusiveMaximum` as booleans instead of numbers only

packages/fets/src/client/types.ts

@@ -242,8 +242,10 @@ export type OASModel<
     : never;
 
 // Later suggest using json-machete
-export type FixJSONSchema<T> = FixAdditionalPropertiesForAllOf<
-  FixMissingAdditionalProperties<FixMissingTypeObject<FixExtraRequiredFields<T>>>
+export type FixJSONSchema<T> = RemoveExclusiveMinimumAndMaximum<
+  FixAdditionalPropertiesForAllOf<
+    FixMissingAdditionalProperties<FixMissingTypeObject<FixExtraRequiredFields<T>>>
+  >
 >;
 
 type FixAdditionalPropertiesForAllOf<T> = T extends { allOf: any[] }
@@ -270,6 +272,14 @@ type FixExtraRequiredFields<T> = T extends {
     }
   : T;
 
+// Currently boolean values for those two are not supported
+type RemoveExclusiveMinimumAndMaximum<T> = T extends {
+  exclusiveMinimum?: boolean;
+  exclusiveMaximum?: boolean;
+}
+  ? Omit<T, 'exclusiveMinimum' | 'exclusiveMaximum'>
+  : T;
+
 export type OASRequestParams<
   TOAS extends OpenAPIDocument,
   TPath extends keyof OASPathMap<TOAS>,

packages/fets/tests/client/client-exclusive-oas.ts

@@ -0,0 +1,15 @@
+import { createClient, NormalizeOAS } from 'fets';
+import exampleExclusiveOas from './fixtures/example-exclusive-oas';
+
+const client = createClient<NormalizeOAS<typeof exampleExclusiveOas>>({});
+
+const res = await client['/minmaxtest'].post({
+  json: {
+    sequence: 1,
+  },
+});
+
+if (res.ok) {
+  const successBody = await res.json();
+  console.log(successBody.sequence);
+}

packages/fets/tests/client/fixtures/example-exclusive-oas.ts

@@ -0,0 +1,63 @@
+export default {
+  openapi: '3.0.3',
+  info: {
+    title: 'Minmaxtest',
+    description: 'Minmaxtest',
+    version: '0.1.0',
+  },
+  components: {
+    securitySchemes: {
+      basicAuth: {
+        type: 'http',
+        scheme: 'basic',
+      },
+    },
+    schemas: {},
+  },
+  paths: {
+    '/minmaxtest': {
+      post: {
+        requestBody: {
+          content: {
+            'application/json': {
+              schema: {
+                type: 'object',
+                properties: {
+                  sequence: {
+                    type: 'integer',
+                    exclusiveMinimum: true,
+                    minimum: 0,
+                  },
+                },
+                required: ['sequence'],
+                additionalProperties: false,
+              },
+            },
+          },
+          required: true,
+        },
+        responses: {
+          '201': {
+            description: 'Default Response',
+            content: {
+              'application/json': {
+                schema: {
+                  type: 'object',
+                  properties: {
+                    sequence: {
+                      type: 'integer',
+                      exclusiveMinimum: true,
+                      minimum: 0,
+                    },
+                  },
+                  required: ['sequence'],
+                  additionalProperties: false,
+                },
+              },
+            },
+          },
+        },
+      },
+    },
+  },
+} as const;