fs.cp w recursive and force is roughly cpr w overwrite

Author: tbeseda

.github/workflows/build.yml

@@ -44,7 +44,7 @@ jobs:
 
     - name: Set up bundle
       run: |
-        gem install bundler -v 1.17.3
+        gem install bundler -v 1.17.3 # Bundler 2.x breaks test lockfile
         bundle config jobs 4
         bundle config retry 3
 

src/shared/copy.js

@@ -18,7 +18,7 @@ module.exports = function copy (source, destination, params, callback) {
     }
     else {
       // cpr(source, destination, { overwrite: true }, callback)
-      cp(source, destination, { recursive: true }, callback)
+      cp(source, destination, { recursive: true, force: true }, callback)
     }
   }
   catch (err) {

test/integration/_shared.js

@@ -153,7 +153,7 @@ let viewsArtifactsDisabled = [
 function reset (t, callback) {
   process.chdir(join(__dirname, '..'))
   destroyPath(mockTmp)
-  cp(mockSource, mockTmp, { recursive: true }, function (err) {
+  cp(mockSource, mockTmp, { recursive: true, force: true }, function (err) {
     if (err) t.fail(err)
     else {
       process.chdir(mockTmp)
@@ -163,31 +163,31 @@ function reset (t, callback) {
 }
 function resetAndCopyShared (t, callback) {
   reset(t, function () {
-    cp('_shared', 'src', { recursive: true }, function done (err) {
+    cp('_shared', 'src', { recursive: true, force: true }, function done (err) {
       if (err) t.fail(err)
       else callback()
     })
   })
 }
 function resetAndCopySharedAutoinstall (t, callback) {
   reset(t, function () {
-    cp('_shared-autoinstall', '.', { recursive: true }, function done (err) {
+    cp('_shared-autoinstall', '.', { recursive: true, force: true }, function done (err) {
       if (err) t.fail(err)
       else callback()
     })
   })
 }
 function resetAndCopySharedCustom (t, callback) {
   reset(t, function () {
-    cp('_shared-custom', '.', { recursive: true }, function done (err) {
+    cp('_shared-custom', '.', { recursive: true, force: true }, function done (err) {
       if (err) t.fail(err)
       else callback()
     })
   })
 }
 function resetAndCopySharedPlugins (t, callback) {
   reset(t, function () {
-    cp('_shared-plugins', 'src', { recursive: true }, function done (err) {
+    cp('_shared-plugins', 'src', { recursive: true, force: true }, function done (err) {
       if (err) t.fail(err)
       else callback()
     })

test/integration/default/shared-tests.js

@@ -108,7 +108,7 @@ test(`[Shared file copying with plugins (default paths)] shared() copies shared
     pluginArtifacts.length + 1,
   )
   resetAndCopySharedPlugins(t, function () {
-    cp(join('src', 'app.plugins'), join('.', 'app.arc'), { recursive: true },
+    cp(join('src', 'app.plugins'), join('.', 'app.arc'), { recursive: true, force: true },
       function (err) {
         if (err) t.fail(err)
         else {
@@ -183,7 +183,7 @@ test(`[Shared file copying (custom paths)] shared() copies shared and views (unl
 test(`[Shared file copying (default paths)] shared() views to only @views (unless disabled or folder not found)`, t => {
   t.plan(viewsArtifacts.length + viewsArtifactsDisabled.length + 1)
   resetAndCopyShared(t, function () {
-    cp(join('src', 'app.arc-views'), join('.', 'app.arc'), { recursive: true }, function (err) {
+    cp(join('src', 'app.arc-views'), join('.', 'app.arc'), { recursive: true, force: true }, function (err) {
       if (err) t.fail(err)
       else {
         hydrate.shared({}, function (err) {
@@ -212,7 +212,7 @@ test(`[Shared file copying (default paths)] shared() views to only @views (unles
 test(`[Shared file copying (custom paths)] shared() views to only @views (unless disabled or folder not found)`, t => {
   t.plan(viewsArtifacts.length + viewsArtifactsDisabled.length + 1)
   resetAndCopySharedCustom(t, function () {
-    cp(join('_shared-custom', 'app.arc-views'), join('.', 'app.arc'), { recursive: true }, function (err) {
+    cp(join('_shared-custom', 'app.arc-views'), join('.', 'app.arc'), { recursive: true, force: true }, function (err) {
       if (err) t.fail(err)
       else {
         hydrate.shared({}, function (err) {

test/integration/symlink/shared-tests.js

@@ -112,7 +112,7 @@ test(`[Shared file symlinking with plugins (default paths)] shared() copies shar
     pluginArtifacts.length + 1,
   )
   resetAndCopySharedPlugins(t, function () {
-    cp(join('src', 'app.plugins'), join('.', 'app.arc'), { recursive: true },
+    cp(join('src', 'app.plugins'), join('.', 'app.arc'), { recursive: true, force: true },
       function (err) {
         if (err) t.fail(err)
         else {
@@ -187,7 +187,7 @@ test(`[Shared file symlinking (custom paths)] shared() copies shared and views (
 test(`[Shared file symlinking (default paths)] shared() views to only @views (unless disabled or folder not found)`, t => {
   t.plan(viewsArtifacts.length + viewsArtifactsDisabled.length + 1)
   resetAndCopyShared(t, function () {
-    cp(join('src', 'app.arc-views'), join('.', 'app.arc'), { recursive: true }, function (err) {
+    cp(join('src', 'app.arc-views'), join('.', 'app.arc'), { recursive: true, force: true }, function (err) {
       if (err) t.fail(err)
       else {
         hydrate.shared({ symlink }, function (err) {
@@ -216,7 +216,7 @@ test(`[Shared file symlinking (default paths)] shared() views to only @views (un
 test(`[Shared file symlinking (custom paths)] shared() views to only @views (unless disabled or folder not found)`, t => {
   t.plan(viewsArtifacts.length + viewsArtifactsDisabled.length + 1)
   resetAndCopySharedCustom(t, function () {
-    cp(join('_shared-custom', 'app.arc-views'), join('.', 'app.arc'), { recursive: true }, function (err) {
+    cp(join('_shared-custom', 'app.arc-views'), join('.', 'app.arc'), { recursive: true, force: true }, function (err) {
       if (err) t.fail(err)
       else {
         hydrate.shared({ symlink }, function (err) {