Merge pull request #219 from appsembler/john/fix-course-completion

Fixes incorrect site monthly metrics course completion data

Author: johnbaldwin

figures/metrics.py

@@ -346,6 +346,7 @@ def get_total_site_users_joined_for_time_period(site, start_date, end_date,
     """returns the number of new enrollments for the time period
 
     NOTE: Untested and not yet used in the general site metrics, but we'll want to add it
+    TODO: Rename this function to be "new_users" for consistency with the API endpoint
     """
     def calc_from_user_model():
         filter_args = dict(

figures/views.py

@@ -565,6 +565,9 @@ def registered_users(self, request):
 
     @list_route()
     def new_users(self, request):
+        """
+        TODO: Rename the metrics module function to "new_users" to match this
+        """
         site = django.contrib.sites.shortcuts.get_current_site(self.request)
         date_for = datetime.utcnow().date()
         months_back = 6
@@ -585,7 +588,7 @@ def course_completions(self, request):
         months_back = 6
 
         course_completions = metrics.get_monthly_history_metric(
-            func=metrics.get_total_site_users_for_time_period,
+            func=metrics.get_total_course_completions_for_time_period,
             site=site,
             date_for=date_for,
             months_back=months_back,