Skip to content

Commit 975a341

Browse files
committed
Enrollment metrics - restructure queryset to avoid pylint failure
1 parent 9657776 commit 975a341

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

figures/pipeline/enrollment_metrics.py

+6-3
Original file line numberDiff line numberDiff line change
@@ -150,15 +150,18 @@ def collect_metrics_for_enrollment(course_enrollment, date_for=None, **_kwargs):
150150
course_enrollment.course_id))
151151

152152
student_modules = student_modules_for_course_enrollment(ce=course_enrollment)
153-
154153
if student_modules:
155154
most_recent_sm = student_modules.latest('modified')
156155
else:
157156
most_recent_sm = None
158157

159-
most_recent_lcgm = LearnerCourseGradeMetrics.objects.filter(
158+
lcgm = LearnerCourseGradeMetrics.objects.filter(
160159
user=course_enrollment.user,
161-
course_id=str(course_enrollment.course_id)).order_by('date_for').last()
160+
course_id=str(course_enrollment.course_id))
161+
if lcgm:
162+
most_recent_lcgm = lcgm.latest('date_for')
163+
else:
164+
most_recent_lcgm = None
162165

163166
if _enrollment_metrics_needs_update(most_recent_lcgm, most_recent_sm):
164167
progress_data = _collect_progress_data(most_recent_sm)

0 commit comments

Comments
 (0)