Skip to content

Commit 3f12fa3

Browse files
committed
Code cleanup - Remove pdb traces and remarked out code from test code
1 parent bbefd3e commit 3f12fa3

File tree

3 files changed

+4
-9
lines changed

3 files changed

+4
-9
lines changed

tests/models/test_course_daily_metrics_model.py

-7
Original file line numberDiff line numberDiff line change
@@ -130,13 +130,11 @@ def test_with_valid_average_progress(self, average_progress):
130130
course_id='course-v1:SomeOrg+ABC01+2121',
131131
enrollment_count=11,
132132
active_learners_today=1,
133-
# average_progress=Decimal(str(average_progress)),
134133
average_progress=str(average_progress),
135134
average_days_to_complete=5,
136135
num_learners_completed=10
137136
)
138137
metrics = CourseDailyMetrics.objects.create(**rec)
139-
# assert metrics.average_progress == Decimal(str(average_progress))
140138
assert metrics.average_progress == average_progress
141139
metrics.clean_fields()
142140

@@ -154,7 +152,6 @@ def test_with_valid_average_progress_2(self, average_progress):
154152
defaults=dict(
155153
enrollment_count=11,
156154
active_learners_today=1,
157-
# average_progress=Decimal(str(average_progress)),
158155
average_progress=str(average_progress),
159156
average_days_to_complete=5,
160157
num_learners_completed=10,
@@ -163,10 +160,6 @@ def test_with_valid_average_progress_2(self, average_progress):
163160
cdm, created = CourseDailyMetrics.objects.update_or_create(**rec)
164161
cdm.save()
165162

166-
# import pdb; pdb.set_trace()
167-
168-
169-
# assert metrics.average_progress == Decimal(str(average_progress))
170163
assert cdm.average_progress == str(average_progress)
171164
cdm.clean_fields()
172165

tests/views/test_learner_details_view.py

-1
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,6 @@ def test_serializer(self):
301301
queryset = enrollments.filter(user=self.my_site_users[0])
302302
assert queryset
303303
serializer = LearnerCourseDetailsSerializer(queryset[0])
304-
# import pdb; pdb.set_trace()
305304
# We're asserting that we can get the serializer `data` property without
306305
# error, not checking the contents of the data. That should be done in
307306
# the serializer specific tests (see tests/test_serializers.py).

tests/views/test_site_monthly_metrics_viewset.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,10 @@ def check_response(self, response, endpoint):
105105
return True
106106

107107
def run_request(self, endpoint, user_reg_test_data):
108-
import pdb; pdb.set_trace()
108+
"""
109+
Stub
110+
"""
111+
pass
109112

110113
@pytest.mark.skip(reason='We need to confirm who is in total registered users')
111114
def test_registered_learners(self, monkeypatch, user_reg_test_data):

0 commit comments

Comments
 (0)