Skip to content

Commit 33e61a3

Browse files
committed
A couple of inline comments for code improvement
1 parent b89d23d commit 33e61a3

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

figures/models.py

+2
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,8 @@ class SiteDailyMetrics(TimeStampedModel):
103103
total_user_count = models.IntegerField()
104104
course_count = models.IntegerField()
105105
total_enrollment_count = models.IntegerField()
106+
107+
# Should change this to default value of 0
106108
mau = models.IntegerField(blank=True, null=True)
107109

108110
class Meta:

figures/sites.py

+3
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,9 @@ def get_courses_for_site(site):
160160

161161

162162
def get_user_ids_for_site(site):
163+
"""
164+
We can use organization_instance.users instead
165+
"""
163166
if figures.helpers.is_multisite():
164167
orgs = organizations.models.Organization.objects.filter(sites__in=[site])
165168
mappings = organizations.models.UserOrganizationMapping.objects.filter(

0 commit comments

Comments
 (0)