Skip to content

Commit 9224b8d

Browse files
Merge pull request #327 from TikhomirovSergey/#320-fix
@SButterfly You can: - switch to your java_client fork using git - > git checkout -b your_new_branch_name master - > git pull https://github.com/User_Name/java-client.git target_branch But now you can clone master
2 parents e0958c7 + 5e2d896 commit 9224b8d

File tree

8 files changed

+40
-1
lines changed

8 files changed

+40
-1
lines changed

src/main/java/io/appium/java_client/pagefactory/Widget.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,4 +61,8 @@ public WebDriver getWrappedDriver() {
6161
public WebElement getWrappedElement() {
6262
return (WebElement) element;
6363
}
64+
65+
public Widget getSelfReference() {
66+
return this;
67+
}
6468
}

src/test/java/io/appium/java_client/pagefactory_tests/widgets/AndroidOverrideWidgetTest.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
import io.appium.java_client.android.AndroidDriver;
44
import io.appium.java_client.pagefactory.AppiumFieldDecorator;
55
import io.appium.java_client.pagefactory.TimeOutDuration;
6+
import io.appium.java_client.pagefactory_tests.widgets.android.annotated.AnnotatedAndroidMovie;
7+
import io.appium.java_client.pagefactory_tests.widgets.android.simple.AndroidMovie;
68
import io.appium.java_client.remote.MobileCapabilityType;
79
import io.appium.java_client.service.local.AppiumDriverLocalService;
810
import org.apache.commons.lang3.StringUtils;
@@ -68,6 +70,7 @@ public void checkACommonWidget() {
6870
movie.goToReview();
6971

7072
rottenTomatoes.checkSimpleReview();
73+
assertTrue(movie.getSelfReference().getClass().equals(AndroidMovie.class));
7174
}
7275

7376
@Override
@@ -81,6 +84,7 @@ public void checkAnAnnotatedWidget() {
8184
movie.goToReview();
8285

8386
rottenTomatoes.checkAnnotatedReview();
87+
assertTrue(movie.getSelfReference().getClass().equals(AnnotatedAndroidMovie.class));
8488
}
8589

8690

@@ -95,6 +99,7 @@ public void checkAnExtendedWidget() {
9599
movie.goToReview();
96100

97101
rottenTomatoes.checkExtendedReview();
102+
assertTrue(movie.getSelfReference().getClass().equals(AnnotatedAndroidMovie.class));
98103
}
99104

100105
@Override

src/test/java/io/appium/java_client/pagefactory_tests/widgets/HtmlOverrideWidgetTest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
import io.appium.java_client.pagefactory.AppiumFieldDecorator;
44
import io.appium.java_client.pagefactory.TimeOutDuration;
5+
import io.appium.java_client.pagefactory_tests.widgets.html.annotated.AnnotatedHtmlMovie;
6+
import io.appium.java_client.pagefactory_tests.widgets.html.simple.HtmlMovie;
57
import org.apache.commons.lang3.StringUtils;
68
import org.junit.AfterClass;
79
import org.junit.Before;
@@ -45,7 +47,7 @@ public static void beforeClass() throws Exception {
4547
@Before
4648
public void setUp() throws Exception {
4749
if (driver != null)
48-
driver.get("file:///" + new File("src/test/java/io/appium/java_client/RottenTomatoesSnapshot.html").getAbsolutePath());
50+
driver.get( new File("src/test/java/io/appium/java_client/RottenTomatoesSnapshot.html").toURI().toString());
4951
}
5052

5153
@AfterClass
@@ -65,6 +67,7 @@ public void checkACommonWidget() {
6567
movie.goToReview();
6668

6769
rottenTomatoes.checkSimpleReview();
70+
assertTrue(movie.getSelfReference().getClass().equals(HtmlMovie.class));
6871
}
6972

7073
@Override
@@ -78,6 +81,7 @@ public void checkAnAnnotatedWidget() {
7881
movie.goToReview();
7982

8083
rottenTomatoes.checkAnnotatedReview();
84+
assertTrue(movie.getSelfReference().getClass().equals(AnnotatedHtmlMovie.class));
8185
}
8286

8387

@@ -92,6 +96,7 @@ public void checkAnExtendedWidget() {
9296
movie.goToReview();
9397

9498
rottenTomatoes.checkExtendedReview();
99+
assertTrue(movie.getSelfReference().getClass().equals(AnnotatedHtmlMovie.class));
95100
}
96101

97102
@Override

src/test/java/io/appium/java_client/pagefactory_tests/widgets/IOSOverrideWidgetTest.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
import io.appium.java_client.ios.IOSDriver;
44
import io.appium.java_client.pagefactory.AppiumFieldDecorator;
55
import io.appium.java_client.pagefactory.TimeOutDuration;
6+
import io.appium.java_client.pagefactory_tests.widgets.ios.annotated.AnnotatedIOSMovie;
7+
import io.appium.java_client.pagefactory_tests.widgets.ios.simple.IOSMovie;
68
import io.appium.java_client.remote.MobileCapabilityType;
79
import io.appium.java_client.service.local.AppiumDriverLocalService;
810
import org.apache.commons.lang3.StringUtils;
@@ -68,6 +70,7 @@ public void checkACommonWidget() {
6870
movie.goToReview();
6971

7072
rottenTomatoes.checkSimpleReview();
73+
assertTrue(movie.getSelfReference().getClass().equals(IOSMovie.class));
7174
}
7275

7376
@Override
@@ -81,6 +84,7 @@ public void checkAnAnnotatedWidget() {
8184
movie.goToReview();
8285

8386
rottenTomatoes.checkAnnotatedReview();
87+
assertTrue(movie.getSelfReference().getClass().equals(AnnotatedIOSMovie.class));
8488
}
8589

8690

@@ -95,6 +99,7 @@ public void checkAnExtendedWidget() {
9599
movie.goToReview();
96100

97101
rottenTomatoes.checkExtendedReview();
102+
assertTrue(movie.getSelfReference().getClass().equals(AnnotatedIOSMovie.class));
98103
}
99104

100105
@Override

src/test/java/io/appium/java_client/pagefactory_tests/widgets/Movie.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,9 @@ protected Movie(WebElement element) {
1515
public abstract Object getPoster();
1616

1717
public abstract void goToReview();
18+
19+
@Override
20+
public Movie getSelfReference() {
21+
return (Movie) super.getSelfReference();
22+
}
1823
}

src/test/java/io/appium/java_client/pagefactory_tests/widgets/Movies.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,9 @@ protected Movies(WebElement element) {
1212
public abstract int getMovieCount();
1313

1414
public abstract Movie getMovie(int index);
15+
16+
@Override
17+
public Movies getSelfReference() {
18+
return (Movies) super.getSelfReference();
19+
}
1520
}

src/test/java/io/appium/java_client/pagefactory_tests/widgets/Review.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,9 @@ protected Review(WebElement element) {
1616
public abstract String info();
1717

1818
public abstract Object getPoster();
19+
20+
@Override
21+
public Review getSelfReference() {
22+
return (Review) super.getSelfReference();
23+
}
1924
}

src/test/java/io/appium/java_client/pagefactory_tests/widgets/SelendroidOverrideWidgetTest.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
import io.appium.java_client.android.AndroidDriver;
44
import io.appium.java_client.pagefactory.AppiumFieldDecorator;
55
import io.appium.java_client.pagefactory.TimeOutDuration;
6+
import io.appium.java_client.pagefactory_tests.widgets.selendroid.annotated.AnnotatedSelendroidMovie;
7+
import io.appium.java_client.pagefactory_tests.widgets.selendroid.simple.SelendroidMovie;
68
import io.appium.java_client.remote.AutomationName;
79
import io.appium.java_client.remote.MobileCapabilityType;
810
import io.appium.java_client.service.local.AppiumDriverLocalService;
@@ -72,6 +74,7 @@ public void checkACommonWidget() {
7274
movie.goToReview();
7375
driver.getPageSource(); //forcing the refreshing hierarchy
7476
rottenTomatoes.checkSimpleReview();
77+
assertTrue(movie.getSelfReference().getClass().equals(SelendroidMovie.class));
7578
}
7679

7780
@Override
@@ -85,6 +88,7 @@ public void checkAnAnnotatedWidget() {
8588
movie.goToReview();
8689
driver.getPageSource(); //forcing the refreshing hierarchy
8790
rottenTomatoes.checkAnnotatedReview();
91+
assertTrue(movie.getSelfReference().getClass().equals(AnnotatedSelendroidMovie.class));
8892
}
8993

9094

@@ -99,6 +103,7 @@ public void checkAnExtendedWidget() {
99103
movie.goToReview();
100104
driver.getPageSource(); //forcing the refreshing hierarchy
101105
rottenTomatoes.checkExtendedReview();
106+
assertTrue(movie.getSelfReference().getClass().equals(AnnotatedSelendroidMovie.class));
102107
}
103108

104109
@Override

0 commit comments

Comments
 (0)