Skip to content

Commit 7915d34

Browse files
authored
refactor: avoid casting to RemoteWebElement (#1345)
1 parent fb8fd72 commit 7915d34

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/main/java/io/appium/java_client/touch/offset/ElementOption.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
import org.openqa.selenium.Point;
88
import org.openqa.selenium.WebElement;
9-
import org.openqa.selenium.remote.RemoteWebElement;
9+
import org.openqa.selenium.internal.HasIdentity;
1010

1111
import java.util.HashMap;
1212
import java.util.Map;
@@ -84,9 +84,9 @@ public ElementOption withCoordinates(int xOffset, int yOffset) {
8484
public ElementOption withElement(WebElement element) {
8585
checkNotNull(element);
8686
checkArgument(true, "Element should be an instance of the class which "
87-
+ "extends org.openqa.selenium.remote.RemoteWebElement",
88-
(RemoteWebElement.class.isAssignableFrom(element.getClass())));
89-
elementId = RemoteWebElement.class.cast(element).getId();
87+
+ "implements org.openqa.selenium.internal.HasIdentity",
88+
element instanceof HasIdentity);
89+
elementId = ((HasIdentity) element).getId();
9090
return this;
9191
}
9292

src/test/java/io/appium/java_client/touch/TouchOptionsTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import java.util.Map;
2828

2929
public class TouchOptionsTests {
30-
private static final WebElement DUMMY_ELEMENT = new DummyElement();
30+
private static final RemoteWebElement DUMMY_ELEMENT = new DummyElement();
3131

3232
@Test(expected = IllegalArgumentException.class)
3333
public void invalidEmptyPointOptionsShouldFailOnBuild() {
@@ -62,7 +62,7 @@ public void longPressOptionsShouldBuildProperly() {
6262
.withDuration(ofMillis(1))
6363
.build();
6464
final Map<String, Object> expectedOpts = new HashMap<>();
65-
expectedOpts.put("element", ((RemoteWebElement) DUMMY_ELEMENT).getId());
65+
expectedOpts.put("element", DUMMY_ELEMENT.getId());
6666
expectedOpts.put("x", 0);
6767
expectedOpts.put("y", 0);
6868
expectedOpts.put("duration", 1L);

0 commit comments

Comments
 (0)