Skip to content

Commit 5dab23d

Browse files
Merge pull request #766 from mykola-mokhnach/else_get
Avoid making unnecessary function calls
2 parents 3438cc5 + a1d8386 commit 5dab23d

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/main/java/io/appium/java_client/internal/ElementMap.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public static Class<? extends RemoteWebElement> getElementClass(HasSessionDetail
7777
}
7878
ElementMap element = Optional.ofNullable(mobileElementMap.get(String
7979
.valueOf(hasSessionDetails.getAutomationName()).toLowerCase().trim()))
80-
.orElse(mobileElementMap
80+
.orElseGet(() -> mobileElementMap
8181
.get(String.valueOf(hasSessionDetails.getPlatformName()).toLowerCase().trim()));
8282
if (element == null) {
8383
return RemoteWebElement.class;

src/main/java/io/appium/java_client/pagefactory/WidgetByBuilder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,12 +93,12 @@ private By getByFromDeclaredClass(WhatIsNeeded whatIsNeeded) {
9393

9494
@Override protected By buildDefaultBy() {
9595
return ofNullable(super.buildDefaultBy())
96-
.orElse(getByFromDeclaredClass(WhatIsNeeded.DEFAULT_OR_HTML));
96+
.orElseGet(() -> getByFromDeclaredClass(WhatIsNeeded.DEFAULT_OR_HTML));
9797
}
9898

9999
@Override protected By buildMobileNativeBy() {
100100
return ofNullable(super.buildMobileNativeBy())
101-
.orElse(getByFromDeclaredClass(WhatIsNeeded.MOBILE_NATIVE));
101+
.orElseGet(() -> getByFromDeclaredClass(WhatIsNeeded.MOBILE_NATIVE));
102102
}
103103

104104
private enum WhatIsNeeded {

0 commit comments

Comments
 (0)