Skip to content

Commit 406da1f

Browse files
Code optimization #521. README update.
1 parent 096b085 commit 406da1f

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@ You can get it on [WIKI](https://github.com/appium/java-client/wiki)
129129
- **[UPDATE]** to Selenium 3.0. [#489](https://github.com/appium/java-client/pull/489)
130130
- [ENHANCEMENT]. Additional methods which perform device rotation were implemented. [#489](https://github.com/appium/java-client/pull/489). [#439](https://github.com/appium/java-client/pull/439). But it works only for iOS in XCUIT mode. The feature request: [#7131](https://github.com/appium/appium/issues/7131)
131131
- [ENHANCEMENT]. TouchID Implementation (iOS Sim Only). Details: [#509](https://github.com/appium/java-client/pull/509)
132+
- [ENHANCEMENT]. The ability to use port, ip and log file as server arguments was provided. Feature request: [#521](https://github.com/appium/java-client/issues/521). Fixes: [#522](https://github.com/appium/java-client/issues/522), [#524](https://github.com/appium/java-client/issues/524).
132133
- [BUG FIX]: There was the issue when "@WithTimeout" was changing general timeout of the waiting for elements. Bug report: [#467](https://github.com/appium/java-client/issues/467). Fixes: [#468](https://github.com/appium/java-client/issues/468), [#469](https://github.com/appium/java-client/issues/469), [#480](https://github.com/appium/java-client/issues/480). Read: [supported-settings](https://github.com/appium/appium/blob/master/docs/en/advanced-concepts/settings.md#supported-settings)
133134
- Added the server flag `io.appium.java_client.service.local.flags.AndroidServerFlag#REBOOT`. [#476](https://github.com/appium/java-client/pull/476)
134135
- Added `io.appium.java_client.remote.AndroidMobileCapabilityType.APP_WAIT_DURATION ` capability. [#461](https://github.com/appium/java-client/pull/461)

src/main/java/io/appium/java_client/service/local/AppiumServiceBuilder.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -238,11 +238,11 @@ public AppiumServiceBuilder withArgument(ServerArgument argument) {
238238
*/
239239
public AppiumServiceBuilder withArgument(ServerArgument argument, String value) {
240240
String argName = argument.getArgument().trim().toLowerCase();
241-
if ("--port".equalsIgnoreCase(argName) || "-p".equalsIgnoreCase(argName)) {
241+
if ("--port".equals(argName) || "-p".equals(argName)) {
242242
usingPort(Integer.valueOf(value));
243-
} else if ("--address".equalsIgnoreCase(argName) || "-a".equalsIgnoreCase(argName)) {
243+
} else if ("--address".equals(argName) || "-a".equals(argName)) {
244244
withIPAddress(value);
245-
} else if ("--log".equalsIgnoreCase(argName) || "-g".equalsIgnoreCase(argName)) {
245+
} else if ("--log".equals(argName) || "-g".equals(argName)) {
246246
withLogFile(new File(value));
247247
} else {
248248
serverArguments.put(argName, value);

0 commit comments

Comments
 (0)