build(deps-dev): bump @appium/eslint-config-appium-ts from 0.3.3 to 1.0.1 (#854)

Author: dependabot[bot]

.eslintignore

@@ -0,0 +1,10 @@
+import appiumConfig from '@appium/eslint-config-appium-ts';
+
+export default [
+  ...appiumConfig,
+  {
+    ignores: [
+      'docs/**',
+    ],
+  },
+];

.eslintrc.json

@@ -76,7 +76,6 @@ export async function performActions(actions) {
  * @this {AndroidUiautomator2Driver}
  * @returns {Promise<void>}
  */
-// eslint-disable-next-line require-await
 export async function releaseActions() {
   this.log.info('On this platform, releaseActions is a no-op');
 }

eslint.config.mjs

@@ -10,7 +10,7 @@ import type {
   StringRecord,
 } from '@appium/types';
 import {DEFAULT_ADB_PORT} from 'appium-adb';
-import AndroidDriver, {utils} from 'appium-android-driver';
+import {AndroidDriver, utils} from 'appium-android-driver';
 import {SETTINGS_HELPER_ID} from 'io.appium.settings';
 import {BaseDriver, DeviceSettings} from 'appium/driver';
 import {fs, mjpeg, util} from 'appium/support';
@@ -481,7 +481,7 @@ class AndroidUiautomator2Driver
       const [startPort, endPort] = DEVICE_PORT_RANGE;
       try {
         this.systemPort = await findAPortNotInUse(startPort, endPort);
-      } catch (e) {
+      } catch {
         throw this.log.errorWithException(
           `Cannot find any free port in range ${startPort}..${endPort}}. ` +
             `Please set the available port number by providing the systemPort capability or ` +
@@ -878,7 +878,7 @@ class AndroidUiautomator2Driver
           (async () => {
             try {
               await task();
-            } catch (ign) {}
+            } catch {}
           })();
         })
       );

lib/commands/actions.js

@@ -16,7 +16,7 @@ export async function isWriteable(filePath) {
       await fs.close(await fs.open(filePath, 'r+'));
     }
     return true;
-  } catch (ign) {
+  } catch {
     return false;
   }
 }

lib/driver.ts

@@ -226,7 +226,6 @@ class UiAutomator2Server {
           } else if (pmOutput.includes(INSTRUMENTATION_TARGET)) {
             pmOutput = ''; // remove output, so it is not printed below
             this.log.debug(`Instrumentation target '${INSTRUMENTATION_TARGET}' is available`);
-            // eslint-disable-next-line require-atomic-updates
             isPmServiceAvailable = true;
           } else if (!pmError) {
             pmError = new Error('The instrumentation target is not listed by Package Manager');
@@ -237,7 +236,7 @@ class UiAutomator2Server {
         waitMs: SERVICES_LAUNCH_TIMEOUT,
         intervalMs: 1000,
       });
-    } catch (err) {
+    } catch {
       // @ts-ignore It is ok if the attribute does not exist
       this.log.error(`Unable to find instrumentation target '${INSTRUMENTATION_TARGET}': ${(pmError || {}).message}`);
       if (pmOutput) {
@@ -268,23 +267,23 @@ class UiAutomator2Server {
       this.jwproxy.didInstrumentationExit = false;
       try {
         await this.stopInstrumentationProcess();
-      } catch (ign) {}
+      } catch {}
       await this.startInstrumentationProcess();
       if (!this.jwproxy.didInstrumentationExit) {
         try {
           await waitForCondition(async () => {
             try {
               await this.jwproxy.command('/status', 'GET');
               return true;
-            } catch (err) {
+            } catch {
               // short circuit to retry or fail fast
               return this.jwproxy.didInstrumentationExit;
             }
           }, {
             waitMs: timeout,
             intervalMs: 1000,
           });
-        } catch (err) {
+        } catch {
           throw this.log.errorWithException(
             `The instrumentation process cannot be initialized within ${timeout}ms timeout. `
             + 'Make sure the application under test does not crash and investigate the logcat output. '
@@ -391,14 +390,14 @@ class UiAutomator2Server {
               url: `http://${this.host}:${this.systemPort}/status`,
               timeout: axiosTimeout,
             });
-          } catch (err) {
+          } catch {
             return true;
           }
         }, {
           waitMs: timeout,
           intervalMs: 100,
         });
-      } catch (err) {
+      } catch {
         this.log.warn(`The ${SERVER_TEST_PACKAGE_ID} process might fail to stop within ${timeout}ms timeout.`);
       }
     };
@@ -429,12 +428,12 @@ class UiAutomator2Server {
         this.adb.forceStop(SERVER_PACKAGE_ID),
         this.adb.forceStop(SERVER_TEST_PACKAGE_ID)
       ]);
-    } catch (ignore) {}
+    } catch {}
     if (strictCleanup) {
       // https://github.com/appium/appium/issues/10749
       try {
         await this.adb.killProcessesByName('uiautomator');
-      } catch (ignore) {}
+      } catch {}
     }
     await waitStop();
   }

lib/helpers.js

@@ -72,7 +72,7 @@
   },
   "devDependencies": {
     "@appium/docutils": "^1.0.1",
-    "@appium/eslint-config-appium-ts": "^0.x",
+    "@appium/eslint-config-appium-ts": "^1.x",
     "@appium/support": "^6.0.0",
     "@appium/test-support": "^3.0.0",
     "@appium/tsconfig": "^0.x",

lib/uiautomator2.js

@@ -29,11 +29,11 @@ describe('Find - uiautomator', function () {
     els.length.should.be.above(8);
     els.length.should.be.below(14);
   });
-  it('should find elements without prepending "new UiSelector()"', async function () {
+  it('should find elements without prepending "new UiSelector()" relative', async function () {
     const els = await driver.$$('android=.clickable(true)');
     els.should.have.length.at.least(8);
   });
-  it('should find elements without prepending "new UiSelector()"', async function () {
+  it('should find elements without prepending "new UiSelector()" absolute', async function () {
     const els = await driver.$$('android=clickable(true)');
     els.should.have.length.at.least(8);
   });
@@ -75,7 +75,7 @@ describe('Find - uiautomator', function () {
     els.should.have.length(0);
     await driver.setTimeout({ implicit: 20000 }); // restore implicit wait
   });
-  it('should allow multiple selector statements and return the Union of the two sets', async function () {
+  it('should allow multiple selector statements and return the Union of the two sets containing non clickable elements', async function () {
     const clickableEls = await driver.$$('android=new UiSelector().clickable(true)');
     clickableEls.length.should.be.above(0);
     const notClickableEls = await driver.$$('android=new UiSelector().clickable(false)');

package.json

@@ -35,7 +35,7 @@ describe('setUrl', function () {
 
       btn = await driver.$('id=com.android.chrome:id/negative_button');
       await btn.click();
-    } catch (ign) {}
+    } catch {}
 
     await driver.url('https://autify.com');