remove dead feature to correct a harmless security warning, update uploadfs to correct a more serious one

Author: boutell

DEVELOPMENT.md

@@ -10,15 +10,3 @@ We generally aim to follow [Vue best practices](https://vuejs.org/v2/style-guide
 ### UI component styles
 
 As a rule, all user interface components should have their styles scoped (using the `scoped` attribute). This helps us write simpler CSS selectors and avoide a certain amount of style "bleed" across components. Global styles, and styles for top level Vue apps (e.g., `TheAposNotifications`), should be in `.scss` files and imported into the import file: `/modules/@apostrophecms/ui/ui/apos/scss/imports.scss`.
-
-## Analyzing bundle size
-
-It is possible to analyze the size of the admin UI webpack bundle:
-
-```
-APOS_BUNDLE_ANALYZER=1 node app @apostrophecms/asset:build
-```
-
-This will display a visualization in your browser.
-
-As of this writing, we are not optimizing the webpack build for production, so expect to see big numbers.

modules/@apostrophecms/asset/index.js

@@ -253,13 +253,6 @@ module.exports = {
 
           await deploy(deployFiles);
 
-          if (process.env.APOS_BUNDLE_ANALYZER) {
-            return new Promise((resolve, reject) => {
-              // Intentionally never resolve it, so the task never exits
-              // and the UI stays up
-            });
-          }
-
           async function moduleOverrides(modulesDir, source, pnpmPaths) {
             await fs.remove(modulesDir);
             await fs.mkdirp(modulesDir);

modules/@apostrophecms/asset/lib/webpack/apos/webpack.config.js

@@ -6,10 +6,6 @@ const js = require('./webpack.js');
 
 let BundleAnalyzerPlugin;
 
-if (process.env.APOS_BUNDLE_ANALYZER) {
-  BundleAnalyzerPlugin = require('webpack-bundle-analyzer').BundleAnalyzerPlugin;
-}
-
 module.exports = ({
   importFile,
   modulesDir,
@@ -84,8 +80,7 @@ module.exports = ({
       ],
       symlinks: false
     },
-    stats: 'verbose',
-    plugins: process.env.APOS_BUNDLE_ANALYZER ? [ new BundleAnalyzerPlugin() ] : []
+    stats: 'verbose'
   };
 
   return merge(config, ...tasks);

modules/@apostrophecms/asset/lib/webpack/apos/webpack.vue.js

@@ -1,4 +1,4 @@
-const VueLoaderPlugin = require('vue-loader/lib/plugin');
+const { VueLoaderPlugin } = require('vue-loader');
 
 module.exports = (options, apos) => {
   return {

modules/@apostrophecms/asset/lib/webpack/src/webpack.config.js

@@ -3,12 +3,6 @@ const merge = require('webpack-merge').merge;
 const scssTask = require('./webpack.scss');
 const srcBuildNames = [ 'src-build', 'src-es5-build' ];
 
-let BundleAnalyzerPlugin;
-
-if (process.env.APOS_BUNDLE_ANALYZER) {
-  BundleAnalyzerPlugin = require('webpack-bundle-analyzer').BundleAnalyzerPlugin;
-}
-
 module.exports = ({
   importFile,
   modulesDir,
@@ -99,7 +93,7 @@ module.exports = ({
       symlinks: false
     },
     stats: 'verbose',
-    plugins: process.env.APOS_BUNDLE_ANALYZER ? [ new BundleAnalyzerPlugin() ] : []
+    plugins: []
   };
 
   if (es5) {

package.json

@@ -130,7 +130,7 @@
     "tinycolor2": "^1.4.2",
     "tough-cookie": "^4.0.0",
     "underscore.string": "^3.3.4",
-    "uploadfs": "^1.22.1",
+    "uploadfs": "^1.22.3",
     "v-tooltip": "^2.0.3",
     "vue": "^2.6.14",
     "vue-advanced-cropper": "^1.10.1",
@@ -157,10 +157,9 @@
     "stylelint": "^14.6.1",
     "stylelint-declaration-strict-value": "^1.8.0",
     "stylelint-order": "^5.0.0",
-    "vue-eslint-parser": "^7.1.1",
-    "webpack-bundle-analyzer": "^3.9.0"
+    "vue-eslint-parser": "^7.1.1"
   },
   "browserslist": [
     "ie >= 10"
   ]
-}
+}