Non-all field merging causes selection set initializer to stop being generated for local cache mutations

[calvincestari]

Summary

This is unintentional behaviour from the field merging work (#431).

extension ApolloCodegenConfiguration {
  /// Determine whether the operations files are output to the schema types module.
  func shouldGenerateSelectionSetInitializers(for operation: IR.Operation) -> Bool {
    guard experimentalFeatures.fieldMerging == .all else { return false }

    if operation.definition.isLocalCacheMutation {
      return true

    } else if options.selectionSetInitializers.contains(.operations) {
      return true

    } else {
      return options.selectionSetInitializers.contains(definitionNamed: operation.definition.name)
    }
  }

  /// Determine whether the operations files are output to the schema types module.
  func shouldGenerateSelectionSetInitializers(for fragment: IR.NamedFragment) -> Bool {
    guard experimentalFeatures.fieldMerging == .all else { return false }

    if options.selectionSetInitializers.contains(.namedFragments) { return true }

    if fragment.definition.isLocalCacheMutation {
      return true
    }

    return options.selectionSetInitializers.contains(definitionNamed: fragment.definition.name)
  }
}

Version

1.21.0

Steps to reproduce the behavior

Use a field merging configuration value of anything other than all in combination with local cache mutations.

Logs

Anything else?

No response