Skip to content

Add config option to get block number from RPC instead of the contract #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Siegrift opened this issue May 20, 2024 · 2 comments
Closed

Comments

@Siegrift
Copy link
Collaborator

Related to #273

On some chains block.number on chain does not work as expected and we need to call the getBlock from RPC instead. While this should be fixed properly in the issue above, there are more chains with this property and it makes sense to add a config option for these (instead of hardcoding these chains in the code).

Once #273 is implemented, the config option should be removed.

@Siegrift Siegrift self-assigned this May 22, 2024
@Siegrift
Copy link
Collaborator Author

As a note, Burak had a good point on the call, that having this as config option is nice even if there is some flag in @api3/chains, because it allows running Airseeker with chains that are not released in @api3/chains.

So in general, the airseeker config creator should be based on @api3/chains, but generate the Airseeker config and utilize its config option for this. Airseeker should not depend on @api3/chains.

@Siegrift
Copy link
Collaborator Author

This is no longer needed. See #314 (comment)

@Siegrift Siegrift removed their assignment May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant