Skip to content
This repository was archived by the owner on Jul 9, 2024. It is now read-only.

Do not use multicall for individual Beacon updates #449

Closed
bbenligiray opened this issue Jul 17, 2023 · 3 comments · Fixed by #471
Closed

Do not use multicall for individual Beacon updates #449

bbenligiray opened this issue Jul 17, 2023 · 3 comments · Fixed by #471
Assignees
Labels
enhancement New feature or request Operations
Milestone

Comments

@bbenligiray
Copy link
Member

This adds an unnecessary gas cost overhead for individual Beacon updates, which is quite important for self-funded feeds

@metobom metobom added this to the Phase 2 milestone Jul 18, 2023
@bbenligiray
Copy link
Member Author

@metobom same with api3dao/airseeker#448 (comment)

@metobom metobom modified the milestones: Phase 2, Post-Phase 2 Aug 14, 2023
@metobom metobom added the enhancement New feature or request label Aug 15, 2023
@acenolaza acenolaza self-assigned this Aug 29, 2023
@acenolaza
Copy link
Contributor

acenolaza commented Aug 30, 2023

@bbenligiray at first I understood that we should not use tryMulticall on updateBeacons() when the count of update calldatas is equal to 1 but after re-reading the title and description on the issue I'm now thinking that the expected change is to just remove the tryMulticall altogether from updateBeacons(). Is this right?

@bbenligiray
Copy link
Member Author

at first I understood that we should not use tryMulticall on updateBeacons() when the count of update calldatas is equal to 1

This is right

If there are 11 Beacons to be updated and we're updating them in batches of 10, we can also omit the tryMulticall() of the second batch with a single Becaon update. It feels like this would also reduce code duplication in your implementation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request Operations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants