Skip to content

Commit 90c86ea

Browse files
committed
[Improve] app backup minor improvements
1 parent bbe7731 commit 90c86ea

File tree

1 file changed

+14
-29
lines changed

1 file changed

+14
-29
lines changed

streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/service/impl/ApplicationBackUpServiceImpl.java

Lines changed: 14 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -207,37 +207,22 @@ public Boolean delete(Long id) throws InternalException {
207207
@Override
208208
@Transactional(rollbackFor = {Exception.class})
209209
public void backup(Application application, FlinkSql flinkSql) {
210-
// basic configuration file backup
211-
log.info("skip backup..");
212-
if (application != null) {
213-
return;
210+
ApplicationConfig config = configService.getEffective(application.getId());
211+
if (config != null) {
212+
application.setConfigId(config.getId());
213+
}
214+
// flink sql tasks need to back up sql and dependencies
215+
int version = 1;
216+
if (flinkSql != null) {
217+
application.setSqlId(flinkSql.getId());
218+
version = flinkSql.getVersion();
219+
} else if (config != null) {
220+
version = config.getVersion();
214221
}
215-
String appHome =
216-
(application.isCustomCodeJob() && application.isCICDJob())
217-
? application.getDistHome()
218-
: application.getAppHome();
219-
FsOperator fsOperator = application.getFsOperator();
220-
if (fsOperator.exists(appHome)) {
221-
// move files to back up directory
222-
ApplicationConfig config = configService.getEffective(application.getId());
223-
if (config != null) {
224-
application.setConfigId(config.getId());
225-
}
226-
// flink sql tasks need to back up sql and dependencies
227-
int version = 1;
228-
if (flinkSql != null) {
229-
application.setSqlId(flinkSql.getId());
230-
version = flinkSql.getVersion();
231-
} else if (config != null) {
232-
version = config.getVersion();
233-
}
234222

235-
ApplicationBackUp applicationBackUp = new ApplicationBackUp(application);
236-
applicationBackUp.setVersion(version);
223+
ApplicationBackUp applicationBackUp = new ApplicationBackUp(application);
224+
applicationBackUp.setVersion(version);
237225

238-
this.save(applicationBackUp);
239-
fsOperator.mkdirs(applicationBackUp.getPath());
240-
fsOperator.copyDir(appHome, applicationBackUp.getPath());
241-
}
226+
this.save(applicationBackUp);
242227
}
243228
}

0 commit comments

Comments
 (0)