Merge pull request #30 from sharding-sphere/dev

update from origin

Author: beckhampu

sharding-core/src/main/java/io/shardingsphere/core/parsing/parser/clause/TableReferencesClauseParser.java

@@ -29,6 +29,7 @@
 import io.shardingsphere.core.parsing.parser.clause.expression.BasicExpressionParser;
 import io.shardingsphere.core.parsing.parser.context.table.Table;
 import io.shardingsphere.core.parsing.parser.dialect.ExpressionParserFactory;
+import io.shardingsphere.core.parsing.parser.exception.SQLParsingUnsupportedException;
 import io.shardingsphere.core.parsing.parser.sql.SQLStatement;
 import io.shardingsphere.core.parsing.parser.token.IndexToken;
 import io.shardingsphere.core.parsing.parser.token.TableToken;
@@ -75,7 +76,13 @@ public final void parse(final SQLStatement sqlStatement, final boolean isSingleT
             parseTableReference(sqlStatement, isSingleTableOnly);
         } while (lexerEngine.skipIfEqual(Symbol.COMMA));
     }
-    
+
+    /**
+     * Parse table references.
+     *
+     * @param sqlStatement SQL statement
+     * @param isSingleTableOnly is parse single table only
+     */
     protected void parseTableReference(final SQLStatement sqlStatement, final boolean isSingleTableOnly) {
         parseTableFactor(sqlStatement, isSingleTableOnly);
     }
@@ -103,7 +110,7 @@ protected final void parseTableFactor(final SQLStatement sqlStatement, final boo
         parseForceIndex(tableName, sqlStatement);
         parseJoinTable(sqlStatement);
         if (isSingleTableOnly && !sqlStatement.getTables().isSingleTable()) {
-            throw new UnsupportedOperationException("Cannot support Multiple-Table.");
+            throw new SQLParsingUnsupportedException("Cannot support Multiple-Table.");
         }
     }
 
@@ -128,7 +135,7 @@ private void parseForceIndex(final String tableName, final SQLStatement sqlState
     private void parseJoinTable(final SQLStatement sqlStatement) {
         while (parseJoinType()) {
             if (lexerEngine.equalAny(Symbol.LEFT_PAREN)) {
-                throw new UnsupportedOperationException("Cannot support sub query for join table.");
+                throw new SQLParsingUnsupportedException("Cannot support sub query for join table.");
             }
             parseTableFactor(sqlStatement, false);
             parseJoinCondition(sqlStatement);
@@ -147,7 +154,12 @@ private boolean parseJoinType() {
         lexerEngine.skipAll(joinTypeKeywordArrays);
         return true;
     }
-    
+
+    /**
+     * Get keywords for join type.
+     *
+     * @return new Keyword object array
+     */
     protected Keyword[] getKeywordsForJoinType() {
         return new Keyword[0];
     }

sharding-core/src/main/java/io/shardingsphere/core/parsing/parser/exception/SQLParsingUnsupportedException.java

@@ -34,4 +34,8 @@ public final class SQLParsingUnsupportedException extends ShardingException {
     public SQLParsingUnsupportedException(final TokenType tokenType) {
         super(String.format(MESSAGE, tokenType.toString()));
     }
+
+    public SQLParsingUnsupportedException(final String message) {
+        super(message);
+    }
 }

sharding-proxy/src/main/java/io/shardingsphere/proxy/frontend/mysql/MySQLFrontendHandler.java

@@ -135,7 +135,7 @@ public void run() {
             }
         }
 
-        private CommandPacket getCommandPacket(final MySQLPacketPayload payload, final BackendConnection backendConnection, final FrontendHandler frontendHandler) {
+        private CommandPacket getCommandPacket(final MySQLPacketPayload payload, final BackendConnection backendConnection, final FrontendHandler frontendHandler) throws SQLException {
             int sequenceId = payload.readInt1();
             int connectionId = ChannelRegistry.getInstance().getConnectionId(context.channel().id().asShortText());
             return CommandPacketFactory.newInstance(sequenceId, connectionId, payload, backendConnection, frontendHandler);

sharding-proxy/src/main/java/io/shardingsphere/proxy/transport/mysql/packet/command/CommandPacketFactory.java

@@ -32,6 +32,8 @@
 import lombok.AccessLevel;
 import lombok.NoArgsConstructor;
 
+import java.sql.SQLException;
+
 /**
  * Command packet factory.
  *
@@ -50,9 +52,10 @@ public final class CommandPacketFactory {
      * @param backendConnection backend connection
      * @param frontendHandler   frontend handler
      * @return command packet
+     * @throws SQLException SQL exception
      */
     public static CommandPacket newInstance(final int sequenceId, final int connectionId, final MySQLPacketPayload payload, 
-                                            final BackendConnection backendConnection, final FrontendHandler frontendHandler) {
+                                            final BackendConnection backendConnection, final FrontendHandler frontendHandler) throws SQLException {
         int commandPacketTypeValue = payload.readInt1();
         CommandPacketType type = CommandPacketType.valueOf(commandPacketTypeValue);
         switch (type) {

sharding-proxy/src/main/java/io/shardingsphere/proxy/transport/mysql/packet/command/query/binary/execute/ComStmtExecutePacket.java

@@ -77,7 +77,7 @@ public final class ComStmtExecutePacket implements QueryCommandPacket {
 
     private final BackendHandler backendHandler;
 
-    public ComStmtExecutePacket(final int sequenceId, final int connectionId, final MySQLPacketPayload payload, final BackendConnection backendConnection, final FrontendHandler frontendHandler) {
+    public ComStmtExecutePacket(final int sequenceId, final int connectionId, final MySQLPacketPayload payload, final BackendConnection backendConnection, final FrontendHandler frontendHandler) throws SQLException {
         this.sequenceId = sequenceId;
         statementId = payload.readInt4();
         binaryStatement = BinaryStatementRegistry.getInstance().getBinaryStatement(statementId);
@@ -107,7 +107,7 @@ private List<BinaryStatementParameterType> getParameterTypes(final MySQLPacketPa
         return result;
     }
 
-    private List<Object> getParameters(final MySQLPacketPayload payload, final int parametersCount) {
+    private List<Object> getParameters(final MySQLPacketPayload payload, final int parametersCount) throws SQLException {
         List<Object> result = new ArrayList<>(parametersCount);
         for (int parameterIndex = 0; parameterIndex < parametersCount; parameterIndex++) {
             BinaryProtocolValue binaryProtocolValue = BinaryProtocolValueFactory.getBinaryProtocolValue(binaryStatement.getParameterTypes().get(parameterIndex).getColumnType());

sharding-proxy/src/main/java/io/shardingsphere/proxy/transport/mysql/packet/command/query/binary/execute/protocol/BinaryProtocolValue.java

@@ -19,6 +19,8 @@
 
 import io.shardingsphere.proxy.transport.mysql.packet.MySQLPacketPayload;
 
+import java.sql.SQLException;
+
 /**
  * Binary protocol value.
  *
@@ -34,8 +36,9 @@ public interface BinaryProtocolValue {
      *
      * @param payload payload operation for MySQL packet
      * @return binary value result
+     * @throws SQLException SQL exception
      */
-    Object read(MySQLPacketPayload payload);
+    Object read(MySQLPacketPayload payload) throws SQLException;
 
     /**
      * Write binary protocol value.

sharding-proxy/src/main/java/io/shardingsphere/proxy/transport/mysql/packet/command/query/binary/execute/protocol/DateBinaryProtocolValue.java

@@ -19,6 +19,8 @@
 
 import io.shardingsphere.proxy.transport.mysql.packet.MySQLPacketPayload;
 
+import java.sql.SQLException;
+import java.sql.SQLFeatureNotSupportedException;
 import java.sql.Timestamp;
 import java.util.Calendar;
 
@@ -31,11 +33,11 @@
 public final class DateBinaryProtocolValue implements BinaryProtocolValue {
 
     @Override
-    public Object read(final MySQLPacketPayload payload) {
+    public Object read(final MySQLPacketPayload payload) throws SQLException {
         int length = payload.readInt1();
         switch (length) {
             case 0:
-                return new Timestamp(0L);
+                throw new SQLFeatureNotSupportedException("Can not support date format if year, month, day is absent.");
             case 4:
                 return getTimestampForDate(payload);
             case 7:
@@ -63,25 +65,18 @@ private Timestamp getTimestampForDatetime(final MySQLPacketPayload payload) {
 
     @Override
     public void write(final MySQLPacketPayload payload, final Object value) {
-        // TODO :yonglun confirm here is cannot set YEAR == 0, it at least 1970 here
         Timestamp timestamp = (Timestamp) value;
         Calendar calendar = Calendar.getInstance();
-        calendar.setTimeInMillis(timestamp.getTime());
+        calendar.setTime(timestamp);
         int year = calendar.get(Calendar.YEAR);
-        // TODO :yonglun confirm here is month + 1, and isDateAbsent adjust is 0 == month, is it never == 0?
         int month = calendar.get(Calendar.MONTH) + 1;
         int dayOfMonth = calendar.get(Calendar.DAY_OF_MONTH);
         int hourOfDay = calendar.get(Calendar.HOUR_OF_DAY);
         int minutes = calendar.get(Calendar.MINUTE);
         int seconds = calendar.get(Calendar.SECOND);
         int nanos = timestamp.getNanos();
-        boolean isDateAbsent = 0 == year && 0 == month && 0 == dayOfMonth;
         boolean isTimeAbsent = 0 == hourOfDay && 0 == minutes && 0 == seconds;
         boolean isNanosAbsent = 0 == nanos;
-        if (isDateAbsent && isTimeAbsent && isNanosAbsent) {
-            payload.writeInt1(0);
-            return;
-        }
         if (isTimeAbsent && isNanosAbsent) {
             payload.writeInt1(4);
             writeDate(payload, year, month, dayOfMonth);