Skip to content

Commit e76938b

Browse files
committed
Fix typo
1 parent edab778 commit e76938b

File tree

5 files changed

+28
-14
lines changed

5 files changed

+28
-14
lines changed

ansible/roles/invoker/tasks/clean.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
user: "{{ invoker.username }}"
3434
password: "{{ invoker.password }}"
3535
force_basic_auth: yes
36-
ignore_errors: "{{ invoker.deployment_ignore_error }}"
36+
ignore_errors: "{{ invoker.deployment.ignore_error }}"
3737
when: zeroDowntimeDeployment.enabled == true and enable_scheduler
3838

3939
- name: wait invoker{{ groups['invokers'].index(inventory_hostname) }} to clean up all existing containers
@@ -42,6 +42,8 @@
4242
validate_certs: no
4343
client_key: "{{ invoker.confdir }}/invoker{{ groups['invokers'].index(inventory_hostname) }}/{{ invoker.ssl.key }}"
4444
client_cert: "{{ invoker.confdir }}/invoker{{ groups['invokers'].index(inventory_hostname) }}/{{ invoker.ssl.cert }}"
45+
user: "{{ invoker.username }}"
46+
password: "{{ invoker.password }}"
4547
return_content: yes
4648
register: result
4749
until: result.content == '0'

core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/FPCSchedulerServer.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class FPCSchedulerServer(scheduler: SchedulerCore, systemUsername: String, syste
5252
(list
5353
.map(scheduler => "queue:" -> scheduler._2.toString)
5454
.toMap
55-
++ Map("creationCount" -> creationCount.toString)).toJson.asJsObject
55+
++ Map("creationCount" -> creationCount.toString)).toJson
5656
}
5757
}
5858
} ~ (path("disable") & post) {

core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/Scheduler.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ class Scheduler(schedulerId: SchedulerInstanceId, schedulerEndpoints: SchedulerE
131131
}
132132

133133
override def getQueueStatusData: Future[List[StatusData]] = {
134-
queueManager.ask(StatusQuery)(Timeout(1.minute)).mapTo[List[StatusData]]
134+
queueManager.ask(StatusQuery)(Timeout(1.minute)).mapTo[Future[List[StatusData]]].flatten
135135
}
136136

137137
override def disable(): Unit = {

core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/queue/MemoryQueue.scala

Lines changed: 19 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,17 +69,30 @@ case object NamespaceThrottled extends MemoryQueueState
6969

7070
// Data
7171
sealed abstract class MemoryQueueData()
72-
case class NoData() extends MemoryQueueData()
73-
case class NoActors() extends MemoryQueueData()
74-
case class RunningData(schedulerActor: ActorRef, droppingActor: ActorRef) extends MemoryQueueData()
75-
case class ThrottledData(schedulerActor: ActorRef, droppingActor: ActorRef) extends MemoryQueueData()
72+
case class NoData() extends MemoryQueueData() {
73+
override def toString = "NoData"
74+
}
75+
case class NoActors() extends MemoryQueueData() {
76+
override def toString = "NoActors"
77+
}
78+
case class RunningData(schedulerActor: ActorRef, droppingActor: ActorRef) extends MemoryQueueData() {
79+
override def toString = "RunningData"
80+
}
81+
case class ThrottledData(schedulerActor: ActorRef, droppingActor: ActorRef) extends MemoryQueueData() {
82+
override def toString = "ThrottledData"
83+
}
7684
case class FlushingData(schedulerActor: ActorRef,
7785
droppingActor: ActorRef,
7886
error: ContainerCreationError,
7987
reason: String,
8088
activeDuringFlush: Boolean = false)
81-
extends MemoryQueueData()
82-
case class RemovingData(schedulerActor: ActorRef, droppingActor: ActorRef, outdated: Boolean) extends MemoryQueueData()
89+
extends MemoryQueueData() {
90+
override def toString = s"ThrottledData(error: $error, reason: $reason, activeDuringFlush: $activeDuringFlush)"
91+
}
92+
case class RemovingData(schedulerActor: ActorRef, droppingActor: ActorRef, outdated: Boolean)
93+
extends MemoryQueueData() {
94+
override def toString = s"RemovingData(outdated: $outdated)"
95+
}
8396

8497
// Events sent by the actor
8598
case class QueueRemoved(invocationNamespace: String, action: DocInfo, leaderKey: Option[String])

core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/queue/QueueManager.scala

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -262,11 +262,10 @@ class QueueManager(
262262
sender ! QueuePool.size
263263

264264
case StatusQuery =>
265-
Future
266-
.sequence {
267-
QueuePool.values.map(_.queue.ask(StatusQuery)(Timeout(5.seconds)).mapTo[StatusData]).toList
268-
}
269-
.map(sender ! _)
265+
val result =
266+
Future.sequence(QueuePool.values.map(_.queue.ask(StatusQuery)(Timeout(5.seconds)).mapTo[StatusData]).toList)
267+
268+
sender ! result
270269

271270
case msg =>
272271
logging.error(this, s"failed to elect a leader for ${msg}")

0 commit comments

Comments
 (0)