Skip to content

Commit e65f899

Browse files
authored
Fix build error (#5123)
1 parent 99fb2c5 commit e65f899

File tree

4 files changed

+14
-22
lines changed

4 files changed

+14
-22
lines changed

core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/v2/ActivationClientProxy.scala

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import akka.actor.Status.{Failure => FailureMessage}
2121
import akka.actor.{ActorRef, ActorSystem, FSM, Props, Stash}
2222
import akka.grpc.internal.ClientClosedException
2323
import akka.pattern.pipe
24-
import akka.stream.ActorMaterializer
2524
import io.grpc.StatusRuntimeException
2625
import org.apache.openwhisk.common.{Logging, TransactionId}
2726
import org.apache.openwhisk.core.connector.ActivationMessage
@@ -73,7 +72,6 @@ class ActivationClientProxy(
7372
containerId: ContainerId,
7473
activationClientFactory: (String, FullyQualifiedEntityName, String, Int, Boolean) => Future[ActivationServiceClient])(
7574
implicit actorSystem: ActorSystem,
76-
mat: ActorMaterializer,
7775
logging: Logging)
7876
extends FSM[ActivationClientProxyState, ActivationClientProxyData]
7977
with Stash {
@@ -406,13 +404,12 @@ object ActivationClientProxy {
406404
schedulerHost: String,
407405
rpcPort: Int,
408406
containerId: ContainerId,
409-
activationClientFactory: (String,
410-
FullyQualifiedEntityName,
411-
String,
412-
Int,
413-
Boolean) => Future[ActivationServiceClient])(implicit actorSystem: ActorSystem,
414-
mat: ActorMaterializer,
415-
logging: Logging) = {
407+
activationClientFactory: (
408+
String,
409+
FullyQualifiedEntityName,
410+
String,
411+
Int,
412+
Boolean) => Future[ActivationServiceClient])(implicit actorSystem: ActorSystem, logging: Logging) = {
416413
Props(
417414
new ActivationClientProxy(
418415
invocationNamespace,

core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/v2/FunctionPullingContainerProxy.scala

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import akka.actor.{ActorRef, ActorRefFactory, ActorSystem, FSM, Props, Stash}
2525
import akka.event.Logging.InfoLevel
2626
import akka.io.{IO, Tcp}
2727
import akka.pattern.pipe
28-
import akka.stream.ActorMaterializer
2928
import org.apache.openwhisk.common.tracing.WhiskTracerProvider
3029
import org.apache.openwhisk.common.{LoggingMarkers, TransactionId, _}
3130
import org.apache.openwhisk.core.ConfigKeys
@@ -194,7 +193,7 @@ class FunctionPullingContainerProxy(
194193
poolConfig: ContainerPoolConfig,
195194
timeoutConfig: ContainerProxyTimeoutConfig,
196195
healtCheckConfig: ContainerProxyHealthCheckConfig,
197-
testTcp: Option[ActorRef])(implicit actorSystem: ActorSystem, mat: ActorMaterializer, logging: Logging)
196+
testTcp: Option[ActorRef])(implicit actorSystem: ActorSystem, logging: Logging)
198197
extends FSM[ProxyState, Data]
199198
with Stash {
200199
startWith(Uninitialized, NonexistentData())
@@ -373,7 +372,7 @@ class FunctionPullingContainerProxy(
373372
case Event(initializedData: InitializedData, _) =>
374373
context.parent ! Initialized(initializedData)
375374
initializedData.clientProxy ! RequestActivation()
376-
setTimer(UnusedTimeoutName, StateTimeout, unusedTimeout)
375+
startSingleTimer(UnusedTimeoutName, StateTimeout, unusedTimeout)
377376
stay() using initializedData
378377

379378
// 2. read executable action data from db
@@ -506,7 +505,7 @@ class FunctionPullingContainerProxy(
506505
// 1. request activation message to client
507506
case Event(activationResult: RunActivationCompleted, data: WarmData) =>
508507
// create timeout
509-
setTimer(UnusedTimeoutName, StateTimeout, unusedTimeout)
508+
startSingleTimer(UnusedTimeoutName, StateTimeout, unusedTimeout)
510509
data.clientProxy ! RequestActivation(activationResult.duration)
511510
stay() using data
512511

@@ -613,7 +612,7 @@ class FunctionPullingContainerProxy(
613612
logging.info(
614613
this,
615614
s"Remain running activations ${runningActivations.keySet().toString()} when received ClientClosed")
616-
setTimer(RunningActivationTimeoutName, ClientClosed, runningActivationTimeout)
615+
startSingleTimer(RunningActivationTimeoutName, ClientClosed, runningActivationTimeout)
617616
stay
618617
}
619618

@@ -674,7 +673,7 @@ class FunctionPullingContainerProxy(
674673
// since akka port will no be used, we can put any value except 0 here
675674
data.clientProxy ! RequestActivation(
676675
newScheduler = Some(SchedulerEndpoints(job.schedulerHost, job.rpcPort, 10)))
677-
setTimer(UnusedTimeoutName, StateTimeout, unusedTimeout)
676+
startSingleTimer(UnusedTimeoutName, StateTimeout, unusedTimeout)
678677
timedOut = false
679678
}
680679
.recover {
@@ -715,7 +714,7 @@ class FunctionPullingContainerProxy(
715714
logging.info(
716715
this,
717716
s"This is the remaining container for ${data.action}. The container will stop after $warmedContainerKeepingTimeout.")
718-
setTimer(KeepingTimeoutName, Remove, warmedContainerKeepingTimeout)
717+
startSingleTimer(KeepingTimeoutName, Remove, warmedContainerKeepingTimeout)
719718
stay
720719

721720
case Event(Remove | GracefulShutdown, data: WarmData) =>
@@ -777,7 +776,7 @@ class FunctionPullingContainerProxy(
777776
}
778777
}
779778
unstashAll()
780-
case _ -> Paused => setTimer(IdleTimeoutName, StateTimeout, idleTimeout)
779+
case _ -> Paused => startSingleTimer(IdleTimeoutName, StateTimeout, idleTimeout)
781780
case _ -> Removing => unstashAll()
782781
}
783782

@@ -1245,7 +1244,7 @@ object FunctionPullingContainerProxy {
12451244
timeoutConfig: ContainerProxyTimeoutConfig,
12461245
healthCheckConfig: ContainerProxyHealthCheckConfig =
12471246
loadConfigOrThrow[ContainerProxyHealthCheckConfig](ConfigKeys.containerProxyHealth),
1248-
tcp: Option[ActorRef] = None)(implicit actorSystem: ActorSystem, mat: ActorMaterializer, logging: Logging) =
1247+
tcp: Option[ActorRef] = None)(implicit actorSystem: ActorSystem, logging: Logging) =
12491248
Props(
12501249
new FunctionPullingContainerProxy(
12511250
factory,

tests/src/test/scala/org/apache/openwhisk/core/containerpool/v2/test/ActivationClientProxyTests.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import akka.Done
2121
import akka.actor.FSM.{CurrentState, SubscribeTransitionCallBack, Transition}
2222
import akka.actor.{ActorRef, ActorSystem}
2323
import akka.grpc.internal.ClientClosedException
24-
import akka.stream.ActorMaterializer
2524
import akka.testkit.{ImplicitSender, TestKit, TestProbe}
2625
import common.StreamLogging
2726
import io.grpc.StatusRuntimeException
@@ -59,7 +58,6 @@ class ActivationClientProxyTests
5958

6059
override def afterAll: Unit = TestKit.shutdownActorSystem(system)
6160

62-
implicit val mat = ActorMaterializer()
6361
implicit val ec = system.dispatcher
6462

6563
val timeout = 20.seconds

tests/src/test/scala/org/apache/openwhisk/core/containerpool/v2/test/FunctionPullingContainerProxyTests.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ import akka.actor.FSM.{CurrentState, StateTimeout, SubscribeTransitionCallBack,
2626
import akka.actor.{Actor, ActorRef, ActorRefFactory, ActorSystem, Props}
2727
import akka.http.scaladsl.model
2828
import akka.io.Tcp.Connect
29-
import akka.stream.ActorMaterializer
3029
import akka.stream.scaladsl.{Sink, Source}
3130
import akka.testkit.{ImplicitSender, TestKit, TestProbe}
3231
import akka.util.ByteString
@@ -86,7 +85,6 @@ class FunctionPullingContainerProxyTests
8685
super.afterAll()
8786
}
8887

89-
implicit val mat = ActorMaterializer()
9088
implicit val ece: ExecutionContextExecutor = system.dispatcher
9189

9290
val timeout = 20.seconds

0 commit comments

Comments
 (0)