Add missing resourceTags and imagePullSecret

Author: ningyougang

core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/kubernetes/KubernetesClient.scala

@@ -143,7 +143,8 @@ class KubernetesClient(
           resourceTags: Option[List[String]],
           imagePullSecret: Option[String] = None)(implicit transid: TransactionId): Future[KubernetesContainer] = {
 
-    val (pod, pdb) = podBuilder.buildPodSpec(name, image, memory, environment, labels, config, resourceTags)
+    val (pod, pdb) =
+      podBuilder.buildPodSpec(name, image, memory, environment, labels, config, resourceTags, imagePullSecret)
     if (transid.meta.extraLogging) {
       log.info(this, s"Pod spec being created\n${Serialization.asYaml(pod)}")
     }

core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/kubernetes/KubernetesContainer.scala

@@ -61,23 +61,26 @@ object KubernetesContainer {
              memory: ByteSize = 256.MB,
              environment: Map[String, String] = Map.empty,
              labels: Map[String, String] = Map.empty,
-             resourceTags: Option[List[String]] = None)(implicit kubernetes: KubernetesApi,
-                                                        ec: ExecutionContext,
-                                                        log: Logging): Future[KubernetesContainer] = {
+             resourceTags: Option[List[String]] = None,
+             imagePullSecret: Option[String] = None)(implicit kubernetes: KubernetesApi,
+                                                     ec: ExecutionContext,
+                                                     log: Logging): Future[KubernetesContainer] = {
     implicit val tid = transid
 
     // Kubernetes naming rule allows maximum length of 63 character and ended with character only.
     val origName = name.replace("_", "-").replaceAll("[()]", "").toLowerCase.take(63)
     val podName = if (origName.endsWith("-")) origName.reverse.dropWhile(_ == '-').reverse else origName
 
     for {
-      container <- kubernetes.run(podName, image, memory, environment, labels, resourceTags).recoverWith {
-        case e: KubernetesPodApiException =>
-          //apiserver call failed - this will expose a different error to users
-          cleanupFailedPod(e, podName, WhiskContainerStartupError(Messages.resourceProvisionError))
-        case e: Throwable =>
-          cleanupFailedPod(e, podName, WhiskContainerStartupError(s"Failed to run container with image '${image}'."))
-      }
+      container <- kubernetes
+        .run(podName, image, memory, environment, labels, resourceTags, imagePullSecret)
+        .recoverWith {
+          case e: KubernetesPodApiException =>
+            //apiserver call failed - this will expose a different error to users
+            cleanupFailedPod(e, podName, WhiskContainerStartupError(Messages.resourceProvisionError))
+          case e: Throwable =>
+            cleanupFailedPod(e, podName, WhiskContainerStartupError(s"Failed to run container with image '${image}'."))
+        }
     } yield container
   }
   private def cleanupFailedPod(e: Throwable, podName: String, failureCause: Exception)(

core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/kubernetes/WhiskPodBuilder.scala

@@ -52,7 +52,8 @@ class WhiskPodBuilder(client: NamespacedKubernetesClient, config: KubernetesClie
     environment: Map[String, String],
     labels: Map[String, String],
     config: KubernetesClientConfig,
-    resourceTags: Option[List[String]] = None)(implicit transid: TransactionId): (Pod, Option[PodDisruptionBudget]) = {
+    resourceTags: Option[List[String]] = None,
+    imagePullSecret: Option[String] = None)(implicit transid: TransactionId): (Pod, Option[PodDisruptionBudget]) = {
     val envVars = environment.map {
       case (key, value) => new EnvVarBuilder().withName(key).withValue(value).build()
     }.toSeq ++ config.fieldRefEnvironment