Skip to content

Commit c2ce94b

Browse files
committed
Reformat code
1 parent dfe7d07 commit c2ce94b

File tree

4 files changed

+136
-60
lines changed

4 files changed

+136
-60
lines changed

common/scala/src/main/scala/org/apache/openwhisk/core/connector/Message.scala

Lines changed: 86 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ case class ActivationMessage(override val transid: TransactionId,
6060
lockedArgs: Map[String, String] = Map.empty,
6161
cause: Option[ActivationId] = None,
6262
traceContext: Option[Map[String, String]] = None)
63-
extends Message {
63+
extends Message {
6464

6565
override def serialize = ActivationMessage.serdes.write(this).compactPrint
6666

@@ -78,6 +78,7 @@ case class ActivationMessage(override val transid: TransactionId,
7878
*/
7979
abstract class AcknowledegmentMessage(private val tid: TransactionId) extends Message {
8080
override val transid: TransactionId = tid
81+
8182
override def serialize: String = AcknowledegmentMessage.serdes.write(this).compactPrint
8283

8384
/** Pithy descriptor for logging. */
@@ -115,17 +116,23 @@ abstract class AcknowledegmentMessage(private val tid: TransactionId) extends Me
115116
* The constructor is private so that callers must use the more restrictive constructors which ensure the respose is always
116117
* Right when this message is created.
117118
*/
118-
case class CombinedCompletionAndResultMessage private (override val transid: TransactionId,
119-
response: Either[ActivationId, WhiskActivation],
120-
override val isSystemError: Option[Boolean],
121-
instance: InstanceId)
122-
extends AcknowledegmentMessage(transid) {
119+
case class CombinedCompletionAndResultMessage private(override val transid: TransactionId,
120+
response: Either[ActivationId, WhiskActivation],
121+
override val isSystemError: Option[Boolean],
122+
instance: InstanceId)
123+
extends AcknowledegmentMessage(transid) {
123124
override def messageType = "combined"
125+
124126
override def result = Some(response)
127+
125128
override def isSlotFree = Some(instance)
129+
126130
override def activationId = response.fold(identity, _.activationId)
131+
127132
override def toJson = CombinedCompletionAndResultMessage.serdes.write(this)
133+
128134
override def shrink = copy(response = response.flatMap(a => Left(a.activationId)))
135+
129136
override def toString = activationId.asString
130137
}
131138

@@ -135,16 +142,21 @@ case class CombinedCompletionAndResultMessage private (override val transid: Tra
135142
* phase notification to the load balancer where an invoker first sends a `ResultMessage` and later sends the
136143
* `CompletionMessage`.
137144
*/
138-
case class CompletionMessage private (override val transid: TransactionId,
139-
override val activationId: ActivationId,
140-
override val isSystemError: Option[Boolean],
141-
instance: InstanceId)
142-
extends AcknowledegmentMessage(transid) {
145+
case class CompletionMessage private(override val transid: TransactionId,
146+
override val activationId: ActivationId,
147+
override val isSystemError: Option[Boolean],
148+
instance: InstanceId)
149+
extends AcknowledegmentMessage(transid) {
143150
override def messageType = "completion"
151+
144152
override def result = None
153+
145154
override def isSlotFree = Some(instance)
155+
146156
override def toJson = CompletionMessage.serdes.write(this)
157+
147158
override def shrink = this
159+
148160
override def toString = activationId.asString
149161
}
150162

@@ -156,15 +168,22 @@ case class CompletionMessage private (override val transid: TransactionId,
156168
* The constructor is private so that callers must use the more restrictive constructors which ensure the respose is always
157169
* Right when this message is created.
158170
*/
159-
case class ResultMessage private (override val transid: TransactionId, response: Either[ActivationId, WhiskActivation])
160-
extends AcknowledegmentMessage(transid) {
171+
case class ResultMessage private(override val transid: TransactionId, response: Either[ActivationId, WhiskActivation])
172+
extends AcknowledegmentMessage(transid) {
161173
override def messageType = "result"
174+
162175
override def result = Some(response)
176+
163177
override def isSlotFree = None
178+
164179
override def isSystemError = response.fold(_ => None, a => Some(a.response.isWhiskError))
180+
165181
override def activationId = response.fold(identity, _.activationId)
182+
166183
override def toJson = ResultMessage.serdes.write(this)
184+
167185
override def shrink = copy(response = response.flatMap(a => Left(a.activationId)))
186+
168187
override def toString = activationId.asString
169188
}
170189

@@ -234,7 +253,7 @@ object AcknowledegmentMessage extends DefaultJsonProtocol {
234253
Left(value.convertTo[ActivationId])
235254

236255
case _: JsObject => Right(value.convertTo[WhiskActivation])
237-
case _ => deserializationError("could not read ResultMessage")
256+
case _ => deserializationError("could not read ResultMessage")
238257
}
239258
}
240259

@@ -265,6 +284,7 @@ case class PingMessage(instance: InvokerInstanceId) extends Message {
265284

266285
object PingMessage extends DefaultJsonProtocol {
267286
def parse(msg: String) = Try(serdes.read(msg.parseJson))
287+
268288
implicit val serdes = jsonFormat(PingMessage.apply _, "name")
269289
}
270290

@@ -276,7 +296,7 @@ object EventMessageBody extends DefaultJsonProtocol {
276296

277297
implicit val format = new JsonFormat[EventMessageBody] {
278298
def write(eventMessageBody: EventMessageBody) = eventMessageBody match {
279-
case m: Metric => m.toJson
299+
case m: Metric => m.toJson
280300
case a: Activation => a.toJson
281301
}
282302

@@ -301,9 +321,11 @@ case class Activation(name: String,
301321
causedBy: Option[String],
302322
size: Option[Int] = None,
303323
userDefinedStatusCode: Option[Int] = None)
304-
extends EventMessageBody {
324+
extends EventMessageBody {
305325
val typeName = Activation.typeName
326+
306327
override def serialize = toJson.compactPrint
328+
307329
def entityPath: FullyQualifiedEntityName = EntityPath(name).toFullyQualifiedEntityName
308330

309331
def toJson = Activation.activationFormat.write(this)
@@ -327,12 +349,12 @@ object Activation extends DefaultJsonProtocol {
327349
private implicit val durationFormat = new RootJsonFormat[Duration] {
328350
override def write(obj: Duration): JsValue = obj match {
329351
case o if o.isFinite => JsNumber(o.toMillis)
330-
case _ => JsNumber.zero
352+
case _ => JsNumber.zero
331353
}
332354

333355
override def read(json: JsValue): Duration = json match {
334356
case JsNumber(n) if n <= 0 => Duration.Zero
335-
case JsNumber(n) => toDuration(n.longValue)
357+
case JsNumber(n) => toDuration(n.longValue)
336358
}
337359
}
338360

@@ -352,7 +374,7 @@ object Activation extends DefaultJsonProtocol {
352374
"size",
353375
"userDefinedStatusCode")
354376

355-
/** Get "StatusCode" from result response set by action developer **/
377+
/** Get "StatusCode" from result response set by action developer * */
356378
def userDefinedStatusCode(result: Option[JsValue]): Option[Int] = {
357379
val statusCode = JsHelpers
358380
.getFieldPath(result.get.asJsObject, ERROR_FIELD, "statusCode")
@@ -394,13 +416,17 @@ object Activation extends DefaultJsonProtocol {
394416

395417
case class Metric(metricName: String, metricValue: Long) extends EventMessageBody {
396418
val typeName = "Metric"
419+
397420
override def serialize = toJson.compactPrint
421+
398422
def toJson = Metric.metricFormat.write(this).asJsObject
399423
}
400424

401425
object Metric extends DefaultJsonProtocol {
402426
val typeName = "Metric"
427+
403428
def parse(msg: String) = Try(metricFormat.read(msg.parseJson))
429+
404430
implicit val metricFormat = jsonFormat(Metric.apply _, "metricName", "metricValue")
405431
}
406432

@@ -411,7 +437,7 @@ case class EventMessage(source: String,
411437
userId: UUID,
412438
eventType: String,
413439
timestamp: Long = System.currentTimeMillis())
414-
extends Message {
440+
extends Message {
415441
override def serialize = EventMessage.format.write(this).compactPrint
416442
}
417443

@@ -434,7 +460,7 @@ case class InvokerResourceMessage(status: String,
434460
inProgressMemory: Long,
435461
tags: Seq[String],
436462
dedicatedNamespaces: Seq[String])
437-
extends Message {
463+
extends Message {
438464

439465
/**
440466
* Serializes message to string. Must be idempotent.
@@ -444,6 +470,7 @@ case class InvokerResourceMessage(status: String,
444470

445471
object InvokerResourceMessage extends DefaultJsonProtocol {
446472
def parse(msg: String): Try[InvokerResourceMessage] = Try(serdes.read(msg.parseJson))
473+
447474
implicit val serdes =
448475
jsonFormat(
449476
InvokerResourceMessage.apply _,
@@ -462,23 +489,25 @@ object InvokerResourceMessage extends DefaultJsonProtocol {
462489
*
463490
* [
464491
* ...
465-
* {
466-
* "data": "RunningData",
467-
* "fqn": "whisk.system/elasticsearch/[email protected]",
468-
* "invocationNamespace": "style95",
469-
* "status": "Running",
470-
* "waitingActivation": 1
471-
* },
492+
* {
493+
* "data": "RunningData",
494+
* "fqn": "whisk.system/elasticsearch/[email protected]",
495+
* "invocationNamespace": "style95",
496+
* "status": "Running",
497+
* "waitingActivation": 1
498+
* },
472499
* ...
473500
* ]
474501
*/
475502
object StatusQuery
503+
476504
case class StatusData(invocationNamespace: String, fqn: String, waitingActivation: Int, status: String, data: String)
477-
extends Message {
505+
extends Message {
478506

479507
override def serialize: String = StatusData.serdes.write(this).compactPrint
480508

481509
}
510+
482511
object StatusData extends DefaultJsonProtocol {
483512

484513
implicit val serdes =
@@ -498,6 +527,7 @@ case class ContainerCreationMessage(override val transid: TransactionId,
498527
extends ContainerMessage(transid) {
499528

500529
override def toJson: JsValue = ContainerCreationMessage.serdes.write(this)
530+
501531
override def serialize: String = toJson.compactPrint
502532
}
503533

@@ -528,6 +558,7 @@ case class ContainerDeletionMessage(override val transid: TransactionId,
528558
whiskActionMetaData: WhiskActionMetaData)
529559
extends ContainerMessage(transid) {
530560
override def toJson: JsValue = ContainerDeletionMessage.serdes.write(this)
561+
531562
override def serialize: String = toJson.compactPrint
532563
}
533564

@@ -544,6 +575,7 @@ object ContainerDeletionMessage extends DefaultJsonProtocol {
544575

545576
abstract class ContainerMessage(private val tid: TransactionId) extends Message {
546577
override val transid: TransactionId = tid
578+
547579
override def serialize: String = ContainerMessage.serdes.write(this).compactPrint
548580

549581
/** Serializes the message to JSON. */
@@ -569,18 +601,31 @@ object ContainerMessage extends DefaultJsonProtocol {
569601
}
570602

571603
sealed trait ContainerCreationError
604+
572605
object ContainerCreationError extends Enumeration {
606+
573607
case object NoAvailableInvokersError extends ContainerCreationError
608+
574609
case object NoAvailableResourceInvokersError extends ContainerCreationError
610+
575611
case object ResourceNotEnoughError extends ContainerCreationError
612+
576613
case object WhiskError extends ContainerCreationError
614+
577615
case object UnknownError extends ContainerCreationError
616+
578617
case object TimeoutError extends ContainerCreationError
618+
579619
case object ShuttingDownError extends ContainerCreationError
620+
580621
case object NonExecutableActionError extends ContainerCreationError
622+
581623
case object DBFetchError extends ContainerCreationError
624+
582625
case object BlackBoxError extends ContainerCreationError
626+
583627
case object ZeroNamespaceLimit extends ContainerCreationError
628+
584629
case object TooManyConcurrentRequests extends ContainerCreationError
585630

586631
val whiskErrors: Set[ContainerCreationError] =
@@ -595,21 +640,22 @@ object ContainerCreationError extends Enumeration {
595640
ZeroNamespaceLimit)
596641

597642
private def parse(name: String) = name.toUpperCase match {
598-
case "NOAVAILABLEINVOKERSERROR" => NoAvailableInvokersError
643+
case "NOAVAILABLEINVOKERSERROR" => NoAvailableInvokersError
599644
case "NOAVAILABLERESOURCEINVOKERSERROR" => NoAvailableResourceInvokersError
600-
case "RESOURCENOTENOUGHERROR" => ResourceNotEnoughError
601-
case "NONEXECUTBLEACTIONERROR" => NonExecutableActionError
602-
case "DBFETCHERROR" => DBFetchError
603-
case "WHISKERROR" => WhiskError
604-
case "BLACKBOXERROR" => BlackBoxError
605-
case "TIMEOUTERROR" => TimeoutError
606-
case "ZERONAMESPACELIMIT" => ZeroNamespaceLimit
607-
case "TOOMANYCONCURRENTREQUESTS" => TooManyConcurrentRequests
608-
case "UNKNOWNERROR" => UnknownError
645+
case "RESOURCENOTENOUGHERROR" => ResourceNotEnoughError
646+
case "NONEXECUTBLEACTIONERROR" => NonExecutableActionError
647+
case "DBFETCHERROR" => DBFetchError
648+
case "WHISKERROR" => WhiskError
649+
case "BLACKBOXERROR" => BlackBoxError
650+
case "TIMEOUTERROR" => TimeoutError
651+
case "ZERONAMESPACELIMIT" => ZeroNamespaceLimit
652+
case "TOOMANYCONCURRENTREQUESTS" => TooManyConcurrentRequests
653+
case "UNKNOWNERROR" => UnknownError
609654
}
610655

611656
implicit val serds = new RootJsonFormat[ContainerCreationError] {
612657
override def write(error: ContainerCreationError): JsValue = JsString(error.toString)
658+
613659
override def read(json: JsValue): ContainerCreationError =
614660
Try {
615661
val JsString(str) = json
@@ -642,6 +688,7 @@ case class ContainerCreationAckMessage(override val transid: TransactionId,
642688

643689
object ContainerCreationAckMessage extends DefaultJsonProtocol {
644690
def parse(msg: String): Try[ContainerCreationAckMessage] = Try(serdes.read(msg.parseJson))
691+
645692
private implicit val fqnSerdes = FullyQualifiedEntityName.serdes
646693
private implicit val byteSizeSerdes = size.serdes
647694
implicit val serdes = jsonFormat12(ContainerCreationAckMessage.apply)

0 commit comments

Comments
 (0)