Skip to content

Commit c1c8ca1

Browse files
authored
Merge 3e99442 into 7c94e9b
2 parents 7c94e9b + 3e99442 commit c1c8ca1

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/queue/MemoryQueue.scala

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -694,13 +694,17 @@ class MemoryQueue(private val etcdClient: EtcdClient,
694694
cleanUpWatcher()
695695
cleanUpData()
696696

697+
context.parent ! queueRemovedMsg
698+
697699
goto(Removed) using NoData()
698700
}
699701

700702
private def cleanUpActorsAndGotoRemoved(data: FlushingData) = {
701703
cleanUpActors(data)
702704
cleanUpData()
703705

706+
context.parent ! queueRemovedMsg
707+
704708
goto(Removed) using NoData()
705709
}
706710

tests/src/test/scala/org/apache/openwhisk/core/scheduler/queue/test/MemoryQueueTests.scala

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -654,13 +654,14 @@ class MemoryQueueTests
654654
fsm ! StateTimeout
655655
expectMsg(Transition(fsm, Idle, Removed))
656656
queueRef.queue.length shouldBe 0
657+
parent.expectMsg(queueRemovedMsg)
658+
657659
fsm ! message
658660

659661
// queue is timed out again in the Removed state.
660662
parent.expectMsg(message)
661663

662664
fsm ! StateTimeout
663-
parent.expectMsg(queueRemovedMsg)
664665

665666
expectNoMessage()
666667

@@ -1103,10 +1104,7 @@ class MemoryQueueTests
11031104
fsm ! message
11041105
probe.expectMsg(ActivationResponse.developerError("nonExecutbleAction error"))
11051106

1106-
parent.expectMsgAnyOf(
1107-
2 * queueConfig.flushGrace + 5.seconds,
1108-
QueueRemoved(testInvocationNamespace, fqn.toDocId.asDocInfo(action.rev), Some(leaderKey)),
1109-
Transition(fsm, Flushing, Removed))
1107+
parent.expectMsgAllOf(2 * queueConfig.flushGrace + 5.seconds, queueRemovedMsg, Transition(fsm, Flushing, Removed))
11101108

11111109
fsm ! StateTimeout
11121110
parent.expectMsg(queueRemovedMsg)
@@ -1409,10 +1407,7 @@ class MemoryQueueTests
14091407

14101408
val duration = FiniteDuration(queueConfig.maxBlackboxRetentionMs, MILLISECONDS) + queueConfig.flushGrace
14111409
probe.expectMsg(duration, ActivationResponse.whiskError("no available invokers"))
1412-
parent.expectMsgAnyOf(
1413-
duration,
1414-
QueueRemoved(testInvocationNamespace, fqn.toDocId.asDocInfo(action.rev), Some(leaderKey)),
1415-
Transition(fsm, Flushing, Removed))
1410+
parent.expectMsgAllOf(duration, queueRemovedMsg, Transition(fsm, Flushing, Removed))
14161411
fsm ! QueueRemovedCompleted
14171412
parent.expectTerminated(fsm)
14181413

0 commit comments

Comments
 (0)