Skip to content

Commit a7a51d9

Browse files
committed
Fix review points
1 parent 2d6b920 commit a7a51d9

File tree

1 file changed

+2
-24
lines changed

1 file changed

+2
-24
lines changed

common/scala/src/main/scala/org/apache/openwhisk/core/entity/WhiskAction.scala

Lines changed: 2 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -366,30 +366,8 @@ object WhiskAction extends DocumentFactory[WhiskAction] with WhiskEntityQueries[
366366

367367
val defaultPermissions = "rwxr-x"
368368

369-
// notes on users, just have 2 type users,
370-
// 1. the action's owner
371-
// 2. the user (not the owner) who used the shared action directly(e.g. get, invoke), we call it "the shared user"
372-
//
373-
// Notes on permission control
374-
// 1. the owner has read(or download) permission on any situation, but for the shared user,
375-
// in spite of has read permission on any situation, but can set it undownloadable or downloadable
376-
// 2. the shared user can't update/delete the action on any situation.
377-
// 3. the owner's permission can affect the shared user's permission, e.g
378-
// if the owner is not given execute permission, the shared user can't have execute permission as well.
379-
//
380-
// Notes on permission values, include below permission value
381-
// 1. permission code:rwxr-x: owner:read(yes)/write(yes)/execute(yes)|the shared action's user:download(yes)/write(no)/execute(yes), this is default
382-
// 2. permission code:rwxr--: owner:read(yes)/write(yes)/execute(yes)|the shared action's user:download(yes)/write(no)/execute(no)
383-
// 3. permission code:r-xr-x: owner:read(yes)/write(no)/execute(yes)|the shared action's user:download(yes)/write(no)/execute(yes)
384-
// 4. permission code:r-xr--: owner:read(yes)/write(no)/execute(yes)|the shared action's user:download(yes)/write(no)/execute(no)
385-
// 5. permission code:r--r--: owner:read(yes)/write(no)/execute(no)|the shared action's user:download(yes)/write(no)/execute(no)
386-
// 6. permission code:rw-r--: owner:read(yes)/write(yes)/execute(no)|the shared action's user:download(yes)/write(no)/execute(no)
387-
// 7. permission code:rwx--x: owner:read(yes)/write(yes)/execute(yes)|the shared action's user:download(no)/write(no)/execute(yes)
388-
// 8. permission code:rwx---: owner:read(yes)/write(yes)/execute(yes)|the shared action's user:download(no)/write(no)/execute(no)
389-
// 9. permission code:r-x--x: owner:read(yes)/write(no)/execute(yes)|the shared action's user:download(no)/write(no)/execute(yes)
390-
// 10. permission code:r-x---: owner:read(yes)/write(no)/execute(yes)|the shared action's user:download(no)/write(no)/execute(no)
391-
// 11. permission code:r-----: owner:read(yes)/write(no)/execute(no)|the shared action's user:download(no)/write(no)/execute(no)
392-
// 12. permission code:rw----: owner:read(yes)/write(yes)/execute(no)|the shared action's user:download(no)/write(no)/execute(no)
369+
// For more information about permission, please refer to the online manual at
370+
// https://github.com/apache/openwhisk/blob/master/docs/actions.md#action-permission-management
393371
val permissionList = List(
394372
defaultPermissions,
395373
"rwxr--",

0 commit comments

Comments
 (0)