Finish setup on error (#5419)

* Fast-fail on errors

* Fix an indentation error

* Fail the setup script on an error

Author: style95

.github/workflows/0-on-demand.yaml

@@ -64,6 +64,9 @@ env:
 jobs:
   openwhisk:
     runs-on: ubuntu-22.04
+    continue-on-error: false
+      strategy:
+        fail-fast: true
     steps:
       - name: Checkout
         uses: actions/checkout@v3

.github/workflows/1-unit.yaml

@@ -49,11 +49,14 @@ env:
 
   # github
   GH_BUILD: ${{ github.event_name }}-${{ github.sha }}
-  GH_BRANCH: ${{ github.head_ref || github.ref_name }} 
+  GH_BRANCH: ${{ github.head_ref || github.ref_name }}
 
 jobs:
   openwhisk:
     runs-on: ubuntu-22.04
+    continue-on-error: false
+    strategy:
+      fail-fast: true
     steps:
       - name: Checkout
         uses: actions/checkout@v3

.github/workflows/2-system.yaml

@@ -44,11 +44,14 @@ env:
 
   # github
   GH_BUILD: ${{ github.event_name }}-${{ github.sha }}
-  GH_BRANCH: ${{ github.head_ref || github.ref_name }} 
+  GH_BRANCH: ${{ github.head_ref || github.ref_name }}
 
 jobs:
   openwhisk:
     runs-on: ubuntu-22.04
+    continue-on-error: false
+    strategy:
+      fail-fast: true
     steps:
       - name: Checkout
         uses: actions/checkout@v3

.github/workflows/3-multi-runtime.yaml

@@ -44,11 +44,14 @@ env:
 
   # github
   GH_BUILD: ${{ github.event_name }}-${{ github.sha }}
-  GH_BRANCH: ${{ github.head_ref || github.ref_name }} 
+  GH_BRANCH: ${{ github.head_ref || github.ref_name }}
 
 jobs:
   openwhisk:
     runs-on: ubuntu-22.04
+    continue-on-error: false
+    strategy:
+      fail-fast: true
     steps:
       - name: Checkout
         uses: actions/checkout@v3

.github/workflows/4-standalone.yaml

@@ -44,11 +44,14 @@ env:
 
   # github
   GH_BUILD: ${{ github.event_name }}-${{ github.sha }}
-  GH_BRANCH: ${{ github.head_ref || github.ref_name }} 
+  GH_BRANCH: ${{ github.head_ref || github.ref_name }}
 
 jobs:
   openwhisk:
     runs-on: ubuntu-22.04
+    continue-on-error: false
+    strategy:
+      fail-fast: true
     steps:
       - name: Checkout
         uses: actions/checkout@v3

.github/workflows/5-scheduler.yaml

@@ -44,11 +44,14 @@ env:
 
   # github
   GH_BUILD: ${{ github.event_name }}-${{ github.sha }}
-  GH_BRANCH: ${{ github.head_ref || github.ref_name }} 
+  GH_BRANCH: ${{ github.head_ref || github.ref_name }}
 
 jobs:
   openwhisk:
     runs-on: ubuntu-22.04
+    continue-on-error: false
+    strategy:
+      fail-fast: true
     steps:
       - name: Checkout
         uses: actions/checkout@v3

.github/workflows/6-performance.yaml

@@ -44,11 +44,14 @@ env:
 
   # github
   GH_BUILD: ${{ github.event_name }}-${{ github.sha }}
-  GH_BRANCH: ${{ github.head_ref || github.ref_name }} 
+  GH_BRANCH: ${{ github.head_ref || github.ref_name }}
 
 jobs:
   openwhisk:
     runs-on: ubuntu-22.04
+    continue-on-error: false
+    strategy:
+      fail-fast: true
     steps:
       - name: Checkout
         uses: actions/checkout@v3
@@ -79,9 +82,9 @@ jobs:
       - run: OPENWHISK_HOST="172.17.0.1" USERS="1" REQUESTS_PER_SEC="1" ./gradlew gatlingRun-org.apache.openwhisk.ColdBlockingInvokeSimulation
         continue-on-error: true
       - name: Slack Notification
-        run: > 
-             ./tools/github/writeOnSlack.sh
-             "[$TEST_SUITE]" ${{ steps.tests.outcome }} on ${GH_BUILD}
-             $'\nbranch:' $GH_BRANCH
-             $'\nmessage:' "$(git log -1 --oneline | cat)"
-             $'\nCheck GitHub logs for results'
+        run: >
+          ./tools/github/writeOnSlack.sh
+          "[$TEST_SUITE]" ${{ steps.tests.outcome }} on ${GH_BUILD}
+          $'\nbranch:' $GH_BRANCH
+          $'\nmessage:' "$(git log -1 --oneline | cat)"
+          $'\nCheck GitHub logs for results'

tools/github/setup.sh

@@ -20,6 +20,8 @@
 #then echo skipping setup ; exit 0
 #fi
 
+set -e
+
 # retries a command for five times and exits with the non-zero exit if even after
 # the retries the command did not succeed.
 function retry() {