Fix review points

Author: ningyougang

core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/v2/FunctionPullingContainerProxy.scala

@@ -51,9 +51,9 @@ case object ContainerRemoved // when container is destroyed
 sealed trait ProxyState
 case object LeaseStart extends ProxyState
 case object Uninitialized extends ProxyState
-case object ContainerCreating extends ProxyState
+case object CreatingContainer extends ProxyState
 case object ContainerCreated extends ProxyState
-case object ClientCreating extends ProxyState
+case object CreatingClient extends ProxyState
 case object ClientCreated extends ProxyState
 case object Running extends ProxyState
 case object Pausing extends ProxyState

core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/v2/InvokerHealthyManager.scala

@@ -62,20 +62,17 @@ class InvokerHealthManager(instanceId: InvokerInstanceId,
       InvokerHealthManager.prepare(entityStore, instanceId).map { _ =>
         startTestAction(self)
       }
-
       goto(Unhealthy)
   }
 
   when(Unhealthy) {
     case Event(ContainerRemoved, _) =>
       healthActionProxy = None
       startTestAction(self)
-
       stay
 
     case Event(msg: FailureMessage, _) =>
       logging.error(this, s"invoker${instanceId}, status:${stateName} got a failure message: ${msg}")
-
       stay
 
     case Event(ContainerCreationFailed(_), _) =>
@@ -92,6 +89,7 @@ class InvokerHealthManager(instanceId: InvokerInstanceId,
     case Event(_: Initialized, _) =>
       // Initialized messages sent by ContainerProxy for HealthManger
       stay()
+
     case Event(ContainerRemoved, _) =>
       // Drop messages sent by ContainerProxy for HealthManger
       healthActionProxy = None
@@ -114,9 +112,7 @@ class InvokerHealthManager(instanceId: InvokerInstanceId,
     // in case of StatusRuntimeException: NOT_FOUND: etcdserver: requested lease not found, we need to get the lease again.
     case Event(t: FailureMessage, _) =>
       logging.error(this, s"Failure happens, restart InvokerHealthManager: ${t}")
-
       goto(Offline)
-
   }
 
   // It is important to note that stateName and the stateData in onTransition callback refer to the previous one.
@@ -147,9 +143,7 @@ class InvokerHealthManager(instanceId: InvokerInstanceId,
 
     case _ -> newState =>
       publishHealthStatusAndStay(newState, nextStateData)
-
       unstashAll()
-
   }
 
   private def publishHealthStatusAndStay(state: InvokerState, stateData: InvokerHealthData) = {
@@ -162,14 +156,11 @@ class InvokerHealthManager(instanceId: InvokerInstanceId,
           data.memory.inProgressMemory,
           instanceId.tags,
           instanceId.dedicatedNamespaces)
-        InvokerHealthManager.useMemory = invokerResourceMessage.busyMemory + invokerResourceMessage.inProgressMemory
         dataManagementService ! UpdateDataOnChange(InvokerKeys.health(instanceId), invokerResourceMessage.serialize)
-
         stay using data.copy(currentInvokerResource = Some(invokerResourceMessage))
 
       case data =>
         logging.error(this, s"unexpected data is found: $data")
-
         stay
     }
   }
@@ -281,9 +272,6 @@ object InvokerHealthManager {
   val healthActionNamePrefix = "invokerHealthTestAction"
   val bufferSize = 10
   val bufferErrorTolerance = 3
-
-  var useMemory = 0l
-
   val healthActionIdentity: Identity = {
     val whiskSystem = "whisk.system"
     val uuid = UUID()