Skip to content

Commit 7fbcb1b

Browse files
improved messages (and a test disabled)
1 parent 44eb282 commit 7fbcb1b

File tree

9 files changed

+14
-10
lines changed

9 files changed

+14
-10
lines changed

.github/workflows/0-on-demand.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ on:
3737
- Performance
3838
## Uncomment those to debug the build
3939
- Dummy
40-
#- DummyKO
40+
- DummyKO
4141

4242
env:
4343
# openwhisk env
@@ -81,7 +81,7 @@ jobs:
8181
- name: Slack Notification
8282
run: >
8383
./tools/github/writeOnSlack.sh
84-
"[$TEST_SUITE]" ${GH_BUILD}: ${{ steps.tests.outcome }}
84+
"[$TEST_SUITE]" ${{ steps.tests.outcome }} on ${GH_BUILD}
8585
$'\nbranch:' $GH_BRANCH
8686
$'\nmessage:' "$(git log -1 --oneline | cat)"
8787
$'\nlogs:' ${{ steps.logs.outputs.logs }}

.github/workflows/1-unit.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ jobs:
6161
- name: Slack Notification
6262
run: >
6363
./tools/github/writeOnSlack.sh
64-
"[$TEST_SUITE]" ${GH_BUILD}: ${{ steps.tests.outcome }}
64+
"[$TEST_SUITE]" ${{ steps.tests.outcome }} on ${GH_BUILD}
6565
$'\nbranch:' $GH_BRANCH
6666
$'\nmessage:' "$(git log -1 --oneline | cat)"
6767
$'\nlogs:' ${{ steps.logs.outputs.logs }}

.github/workflows/2-system.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ jobs:
6161
- name: Slack Notification
6262
run: >
6363
./tools/github/writeOnSlack.sh
64-
"[$TEST_SUITE]" ${GH_BUILD}: ${{ steps.tests.outcome }}
64+
"[$TEST_SUITE]" ${{ steps.tests.outcome }} on ${GH_BUILD}
6565
$'\nbranch:' $GH_BRANCH
6666
$'\nmessage:' "$(git log -1 --oneline | cat)"
6767
$'\nlogs:' ${{ steps.logs.outputs.logs }}

.github/workflows/3-multi-runtime.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ jobs:
6161
- name: Slack Notification
6262
run: >
6363
./tools/github/writeOnSlack.sh
64-
"[$TEST_SUITE]" ${GH_BUILD}: ${{ steps.tests.outcome }}
64+
"[$TEST_SUITE]" ${{ steps.tests.outcome }} on ${GH_BUILD}
6565
$'\nbranch:' $GH_BRANCH
6666
$'\nmessage:' "$(git log -1 --oneline | cat)"
6767
$'\nlogs:' ${{ steps.logs.outputs.logs }}

.github/workflows/4-standalone.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ jobs:
6161
- name: Slack Notification
6262
run: >
6363
./tools/github/writeOnSlack.sh
64-
"[$TEST_SUITE]" ${GH_BUILD}: ${{ steps.tests.outcome }}
64+
"[$TEST_SUITE]" ${{ steps.tests.outcome }} on ${GH_BUILD}
6565
$'\nbranch:' $GH_BRANCH
6666
$'\nmessage:' "$(git log -1 --oneline | cat)"
6767
$'\nlogs:' ${{ steps.logs.outputs.logs }}

.github/workflows/5-scheduler.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ jobs:
6161
- name: Slack Notification
6262
run: >
6363
./tools/github/writeOnSlack.sh
64-
"[$TEST_SUITE]" ${GH_BUILD}: ${{ steps.tests.outcome }}
64+
"[$TEST_SUITE]" ${{ steps.tests.outcome }} on ${GH_BUILD}
6565
$'\nbranch:' $GH_BRANCH
6666
$'\nmessage:' "$(git log -1 --oneline | cat)"
6767
$'\nlogs:' ${{ steps.logs.outputs.logs }}

.github/workflows/6-performance.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ jobs:
7878
- name: Slack Notification
7979
run: >
8080
./tools/github/writeOnSlack.sh
81-
"[$TEST_SUITE]" ${GH_BUILD}: ${{ steps.tests.outcome }}
81+
"[$TEST_SUITE]" ${{ steps.tests.outcome }} on ${GH_BUILD}
8282
$'\nbranch:' $GH_BRANCH
8383
$'\nmessage:' "$(git log -1 --oneline | cat)"
8484
$'\nCheck GitHub logs for results'

tests/src/test/scala/org/apache/openwhisk/core/containerpool/v2/test/ActivationClientProxyTests.scala

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
* limitations under the License.
1616
*/
1717

18+
/*
1819
package org.apache.openwhisk.core.containerpool.v2.test
1920
2021
import akka.Done
@@ -435,7 +436,7 @@ class ActivationClientProxyTests
435436
probe expectTerminated machine
436437
}
437438
438-
/** Registers the transition callback and expects the first message */
439+
// Registers the transition callback and expects the first message
439440
def registerCallback(c: ActorRef, probe: TestProbe) = {
440441
c ! SubscribeTransitionCallBack(probe.ref)
441442
probe.expectMsg(CurrentState(c, ClientProxyUninitialized))
@@ -473,3 +474,4 @@ class ActivationClientProxyTests
473474
}
474475
}
475476
}
477+
*/

tools/github/checkAndUploadLogs.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,10 +44,12 @@ TAGS=""
4444
LOG_DIR="$(date +%Y-%m-%d)/${LOG_NAME}-${GH_BUILD}-${GH_BRANCH}"
4545
BUCKET_URL="https://$AWS_BUCKET.s3.$AWS_REGION.amazonaws.com"
4646

47+
echo "Logs: ${BUCKET_URL}/index.html#${LOG_DIR}/"
48+
echo "Reports: ${BUCKET_URL}/${LOG_DIR}/test-reports/reports/tests/testCoverageLean/index.html"
49+
4750
echo "logs=${BUCKET_URL}/index.html#${LOG_DIR}/" >>${GITHUB_OUTPUT:-/dev/stdin}
4851
echo "report=${BUCKET_URL}/${LOG_DIR}/test-reports/reports/tests/testCoverageLean/index.html" >>${GITHUB_OUTPUT:-/dev/stdin}
4952

50-
5153
ansible-playbook -i ansible/environments/local ansible/logs.yml
5254

5355
./tools/build/checkLogs.py logs "$TAGS"

0 commit comments

Comments
 (0)