Skip to content

Commit 2268f1a

Browse files
author
Brendan Doyle
committed
revert etcd client local change for unit testing
1 parent 9eed2e3 commit 2268f1a

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

common/scala/src/main/scala/org/apache/openwhisk/core/etcd/EtcdClient.scala

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@ import com.ibm.etcd.client.{EtcdClient => Client}
2525
import io.grpc.stub.StreamObserver
2626
import java.util.concurrent.Executors
2727

28-
//import org.apache.openwhisk.core.ConfigKeys
28+
import org.apache.openwhisk.core.ConfigKeys
2929
import org.apache.openwhisk.core.etcd.EtcdType._
3030
import org.apache.openwhisk.core.service.Lease
31-
//import pureconfig.loadConfigOrThrow
31+
import pureconfig.loadConfigOrThrow
3232
import spray.json.DefaultJsonProtocol
3333

3434
import scala.language.implicitConversions
@@ -49,10 +49,10 @@ object RichListenableFuture {
4949
object EtcdClient {
5050
// hostAndPorts format: {HOST}:{PORT}[,{HOST}:{PORT},{HOST}:{PORT}, ...]
5151
def apply(config: EtcdConfig)(implicit ece: ExecutionContextExecutor): EtcdClient = {
52-
//require(config.hosts != null)
52+
require(config.hosts != null)
5353
require(
5454
(config.username.nonEmpty && config.password.nonEmpty) || (config.username.isEmpty && config.password.isEmpty))
55-
val clientBuilder = Client.forEndpoints("testHosts").withPlainText()
55+
val clientBuilder = Client.forEndpoints(config.hosts).withPlainText()
5656
if (config.username.nonEmpty && config.password.nonEmpty) {
5757
new EtcdClient(clientBuilder.withCredentials(config.username.get, config.password.get).build())
5858
} else {
@@ -183,7 +183,7 @@ trait EtcdLeaseApi {
183183
}
184184

185185
trait EtcdWatchApi {
186-
val nThreads = 10
186+
val nThreads = loadConfigOrThrow[Int](ConfigKeys.etcdPoolThreads)
187187
val threadpool = Executors.newFixedThreadPool(nThreads);
188188
protected[etcd] val client: Client
189189

0 commit comments

Comments
 (0)