Skip to content

Commit 18b611d

Browse files
committed
Avoid send metric repeatedly
1 parent c712e78 commit 18b611d

File tree

3 files changed

+4
-21
lines changed

3 files changed

+4
-21
lines changed

common/scala/src/main/scala/org/apache/openwhisk/common/Logging.scala

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -502,12 +502,10 @@ object LoggingMarkers {
502502
val INVOKER_ACTIVATION = LogMarkerToken(invoker, activation, start)(MeasurementUnit.none)
503503
def INVOKER_DOCKER_CMD(cmd: String) =
504504
LogMarkerToken(invoker, "docker", start, Some(cmd), Map("cmd" -> cmd))(MeasurementUnit.time.milliseconds)
505-
def INVOKER_DOCKER_CMD_TIMEOUT(cmd: String) =
506-
LogMarkerToken(invoker, "docker", timeout, Some(cmd), Map("cmd" -> cmd))(MeasurementUnit.none)
507505
def INVOKER_RUNC_CMD(cmd: String) =
508506
LogMarkerToken(invoker, "runc", start, Some(cmd), Map("cmd" -> cmd))(MeasurementUnit.time.milliseconds)
509507
def INVOKER_KUBEAPI_CMD(cmd: String) =
510-
LogMarkerToken(invoker, "kubeapi", start, Some(cmd), Map("cmd" -> cmd))(MeasurementUnit.none)
508+
LogMarkerToken(invoker, "kubeapi", start, Some(cmd), Map("cmd" -> cmd))(MeasurementUnit.time.milliseconds)
511509
def INVOKER_CONTAINER_START(containerState: String, invocationNamespace: String, namespace: String, action: String) =
512510
LogMarkerToken(
513511
invoker,

core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/docker/DockerClient.scala

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -206,14 +206,9 @@ class DockerClient(dockerHost: Option[String] = None,
206206
logLevel = InfoLevel)
207207
executeProcess(cmd, timeout).andThen {
208208
case Success(_) =>
209-
MetricEmitter.emitHistogramMetric(
210-
LogMarkerToken("docker", "runCmd", "duration", Some(args.head), Map("cmd" -> args.head))(
211-
MeasurementUnit.time.milliseconds),
212-
Instant.now.toEpochMilli - transid.meta.start.toEpochMilli)
213209
transid.finished(this, start)
214210
case Failure(pte: ProcessTimeoutException) =>
215211
transid.failed(this, start, pte.getMessage, ErrorLevel)
216-
MetricEmitter.emitCounterMetric(LoggingMarkers.INVOKER_DOCKER_CMD_TIMEOUT(args.head))
217212
case Failure(t) => transid.failed(this, start, t.getMessage, ErrorLevel)
218213
}
219214
}

core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/kubernetes/KubernetesClient.scala

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import java.net.SocketTimeoutException
2222
import java.time.format.DateTimeFormatterBuilder
2323
import java.time.temporal.ChronoField
2424
import java.time.{Instant, ZoneId}
25+
2526
import akka.actor.ActorSystem
2627
import akka.event.Logging.ErrorLevel
2728
import akka.event.Logging.InfoLevel
@@ -37,18 +38,11 @@ import collection.JavaConverters._
3738
import io.fabric8.kubernetes.api.model._
3839
import io.fabric8.kubernetes.client.utils.Serialization
3940
import io.fabric8.kubernetes.client.{ConfigBuilder, DefaultKubernetesClient}
40-
import kamon.metric.MeasurementUnit
4141
import okhttp3.{Call, Callback, Request, Response}
4242
import okio.BufferedSource
4343
import org.apache.commons.lang3.exception.ExceptionUtils
44-
import org.apache.openwhisk.common.{
45-
ConfigMapValue,
46-
LogMarkerToken,
47-
Logging,
48-
LoggingMarkers,
49-
MetricEmitter,
50-
TransactionId
51-
}
44+
import org.apache.openwhisk.common.LoggingMarkers
45+
import org.apache.openwhisk.common.{ConfigMapValue, Logging, TransactionId}
5246
import org.apache.openwhisk.core.ConfigKeys
5347
import org.apache.openwhisk.core.containerpool.docker.ProcessRunner
5448
import org.apache.openwhisk.core.containerpool.{ContainerAddress, ContainerId}
@@ -182,10 +176,6 @@ class KubernetesClient(
182176
waitForPod(namespace, createdPod, start.start, config.timeouts.run)
183177
.map { readyPod =>
184178
transid.finished(this, start, logLevel = InfoLevel)
185-
MetricEmitter.emitHistogramMetric(
186-
LogMarkerToken("kubeapi", "create", "duration", Some("create"), Map("cmd" -> "create"))(
187-
MeasurementUnit.time.milliseconds),
188-
Instant.now.toEpochMilli - transid.meta.start.toEpochMilli)
189179
toContainer(readyPod)
190180
}
191181
.recoverWith {

0 commit comments

Comments
 (0)