Skip to content

feature request: support copy and rename for memory services #2483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
silver-ymz opened this issue Jun 18, 2023 · 4 comments
Closed

feature request: support copy and rename for memory services #2483

silver-ymz opened this issue Jun 18, 2023 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed services/memory

Comments

@silver-ymz
Copy link
Member

When writing tests for binding, memory is the best option as it has no side effects and can be run on all platforms.

We need to support copy and rename for memory services.
@Xuanwo Xuanwo added good first issue Good for newcomers help wanted Extra attention is needed services/memory labels Jun 18, 2023
@infdahai
Copy link
Contributor

I' like to take this task.

@Xuanwo
Copy link
Member

Xuanwo commented Jun 21, 2023

We can implement copy and rename by calling get/set/delete directly.

@oowl
Copy link
Member

oowl commented Jun 23, 2023

Sorry, it seems these features include by my PR #2513.
memory dashmap moka all support rename and copy function

@Xuanwo
Copy link
Member

Xuanwo commented Jun 23, 2023

Thank you for @oowl's work! I would also like to express my gratitude to @infdahai for his interest!

@Xuanwo Xuanwo closed this as completed Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed services/memory
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Xuanwo @infdahai @oowl @silver-ymz