refactor(core/types)!: fix with_user_metadata signature (#5960)

fix with_user_metadata signature

Author: meteorgan

core/src/services/azblob/backend.rs

@@ -571,7 +571,7 @@ impl Access for AzblobBackend {
 
                 let user_meta = parse_prefixed_headers(headers, X_MS_META_PREFIX);
                 if !user_meta.is_empty() {
-                    meta.with_user_metadata(user_meta);
+                    meta = meta.with_user_metadata(user_meta);
                 }
 
                 Ok(RpStat::new(meta))

core/src/services/cos/backend.rs

@@ -339,7 +339,7 @@ impl Access for CosBackend {
 
                 let user_meta = parse_prefixed_headers(headers, "x-cos-meta-");
                 if !user_meta.is_empty() {
-                    meta.with_user_metadata(user_meta);
+                    meta = meta.with_user_metadata(user_meta);
                 }
 
                 if let Some(v) = parse_header_to_str(headers, constants::X_COS_VERSION_ID)? {

core/src/services/gcs/core.rs

@@ -701,7 +701,7 @@ impl GcsCore {
         m.set_last_modified(parse_datetime_from_rfc3339(&meta.updated)?);
 
         if !meta.metadata.is_empty() {
-            m.with_user_metadata(meta.metadata);
+            m = m.with_user_metadata(meta.metadata);
         }
 
         Ok(m)

core/src/services/obs/backend.rs

@@ -354,7 +354,7 @@ impl Access for ObsBackend {
                     .collect::<HashMap<_, _>>();
 
                 if !user_meta.is_empty() {
-                    meta.with_user_metadata(user_meta);
+                    meta = meta.with_user_metadata(user_meta);
                 }
 
                 if let Some(v) = parse_header_to_str(headers, constants::X_OBS_VERSION_ID)? {

core/src/services/oss/core.rs

@@ -238,7 +238,7 @@ impl OssCore {
         let mut m = parse_into_metadata(path, headers)?;
         let user_meta = parse_prefixed_headers(headers, X_OSS_META_PREFIX);
         if !user_meta.is_empty() {
-            m.with_user_metadata(user_meta);
+            m = m.with_user_metadata(user_meta);
         }
 
         Ok(m)

core/src/services/s3/backend.rs

@@ -1055,7 +1055,7 @@ impl Access for S3Backend {
 
                 let user_meta = parse_prefixed_headers(headers, X_AMZ_META_PREFIX);
                 if !user_meta.is_empty() {
-                    meta.with_user_metadata(user_meta);
+                    meta = meta.with_user_metadata(user_meta);
                 }
 
                 if let Some(v) = parse_header_to_str(headers, X_AMZ_VERSION_ID)? {

core/src/services/swift/backend.rs

@@ -229,7 +229,7 @@ impl Access for SwiftBackend {
                 let mut meta = parse_into_metadata(path, headers)?;
                 let user_meta = parse_prefixed_headers(headers, "x-object-meta-");
                 if !user_meta.is_empty() {
-                    meta.with_user_metadata(user_meta);
+                    meta = meta.with_user_metadata(user_meta);
                 }
 
                 Ok(RpStat::new(meta))

core/src/types/metadata.rs

@@ -428,8 +428,8 @@ impl Metadata {
         self.user_metadata.as_ref()
     }
 
-    /// Set user defined metadata of this entry
-    pub fn with_user_metadata(&mut self, data: HashMap<String, String>) -> &mut Self {
+    /// With user defined metadata of this entry
+    pub fn with_user_metadata(mut self, data: HashMap<String, String>) -> Self {
         self.user_metadata = Some(data);
         self
     }