caching results of runtime features and minor refactoring

Author: Rohit Kumar Srivastava

include/mxnet/c_api.h

@@ -374,6 +374,7 @@ class Tuple {
   }
 };
 
+
 /*! brief check if a shape's ndim is known. */
 inline bool ndim_is_known(const int ndim) {
   CHECK_GE(ndim, -1) << "shape ndim must be >= -1, while received " << ndim;

include/mxnet/tuple.h

@@ -107,6 +107,8 @@
 _NDARRAY_BASIC_INDEXING = 0
 _NDARRAY_ADVANCED_INDEXING = 1
 
+# Caching whether MXNet was built with INT64 support or not
+_INT64_TENSOR_SIZE_ENABLED = Features().is_enabled('INT64_TENSOR_SIZE')
 
 def _new_empty_handle():
     """Returns a new empty handle.
@@ -134,8 +136,8 @@ def _new_alloc_handle(shape, ctx, delay_alloc, dtype=mx_real_t):
         A new empty `NDArray` handle.
     """
     hdl = NDArrayHandle()
-    if Features().is_enabled('INT64_TENSOR_SIZE') and sys.version_info[0] > 2:
-        check_call(_LIB.MXNDArrayCreateExInt64(
+    if sys.version_info[0] > 2 and _INT64_TENSOR_SIZE_ENABLED:
+        check_call(_LIB.MXNDArrayCreateEx64(
             c_array_buf(mx_int64, native_array('q', shape)),
             ctypes.c_int(len(shape)),
             ctypes.c_int(ctx.device_typeid),
@@ -2230,9 +2232,9 @@ def shape(self):
         (2L, 3L, 4L)
         """
         ndim = mx_int()
-        if sys.version_info[0] > 2 and Features().is_enabled('INT64_TENSOR_SIZE'):
+        if _INT64_TENSOR_SIZE_ENABLED:
             pdata = ctypes.POINTER(mx_int64)()
-            check_call(_LIB.MXNDArrayGetShapeExInt64(
+            check_call(_LIB.MXNDArrayGetShapeEx64(
                 self.handle, ctypes.byref(ndim), ctypes.byref(pdata)))
         else:
             pdata = ctypes.POINTER(mx_int)()

python/mxnet/ndarray/ndarray.py

@@ -39,9 +39,8 @@
 from ..base import check_call, MXNetError, NotImplementedForSymbol
 from ..context import Context, current_context
 from ..ndarray import NDArray, _DTYPE_NP_TO_MX, _DTYPE_MX_TO_NP, _GRAD_REQ_MAP
-from ..ndarray.ndarray import _STORAGE_TYPE_STR_TO_ID
+from ..ndarray.ndarray import _STORAGE_TYPE_STR_TO_ID, _INT64_TENSOR_SIZE_ENABLED
 from ..ndarray import _ndarray_cls
-from ..runtime import Features
 from ..executor import Executor
 from . import _internal
 from . import op
@@ -1213,14 +1212,14 @@ def _infer_shape_impl(self, partial, *args, **kwargs):
         aux_shape_size = mx_uint()
         aux_shape_ndim = ctypes.POINTER(mx_int)()
         complete = ctypes.c_int()
-        if Features().is_enabled('INT64_TENSOR_SIZE') and sys.version_info[0] > 2:
+        if sys.version_info[0] > 2 and _INT64_TENSOR_SIZE_ENABLED:
             arg_shape_data = ctypes.POINTER(ctypes.POINTER(mx_int64))()
             out_shape_data = ctypes.POINTER(ctypes.POINTER(mx_int64))()
             aux_shape_data = ctypes.POINTER(ctypes.POINTER(mx_int64))()
             if partial:
-                infer_func = _LIB.MXSymbolInferShapePartialExInt64
+                infer_func = _LIB.MXSymbolInferShapePartialEx64
             else:
-                infer_func = _LIB.MXSymbolInferShapeExInt64
+                infer_func = _LIB.MXSymbolInferShapeEx64
             check_call(infer_func(
                 self.handle,
                 mx_uint(len(indptr) - 1),

python/mxnet/symbol/symbol.py

@@ -190,8 +190,13 @@ int MXNDArrayCreateNone(NDArrayHandle *out) {
 }
 
 template<typename DataType, typename dimtype>
-void CreateArray(const DataType* shape, dimtype ndim, int dev_type, int dev_id, int delay_alloc,
-                 int dtype, NDArrayHandle* out) {
+void CreateNDArray(const DataType* shape,
+                   dimtype ndim,
+                   int dev_type,
+                   int dev_id,
+                   int delay_alloc,
+                   int dtype,
+                   NDArrayHandle* out) {
   *out = new NDArray(mxnet::TShape(shape, shape + ndim),
                      Context::Create(static_cast<Context::DeviceType>(dev_type), dev_id),
                      delay_alloc != 0, dtype);
@@ -210,15 +215,15 @@ int MXNDArrayCreate(const mx_uint *shape,
   API_END();
 }
 
-int MXNDArrayCreateExInt64(const mx_int64 *shape,
-                           int ndim,
-                           int dev_type,
-                           int dev_id,
-                           int delay_alloc,
-                           int dtype,
-                           NDArrayHandle *out) {
+int MXNDArrayCreateEx64(const mx_int64 *shape,
+                        int ndim,
+                        int dev_type,
+                        int dev_id,
+                        int delay_alloc,
+                        int dtype,
+                        NDArrayHandle *out) {
   API_BEGIN();
-  CreateArray<mx_int64, int>(shape, ndim, dev_type, dev_id, delay_alloc, dtype, out);
+  CreateNDArray<mx_int64, int>(shape, ndim, dev_type, dev_id, delay_alloc, dtype, out);
   API_END();
 }
 
@@ -230,11 +235,7 @@ int MXNDArrayCreateEx(const mx_uint *shape,
                       int dtype,
                       NDArrayHandle *out) {
   API_BEGIN();
-  *out = new NDArray(
-      mxnet::TShape(shape, shape + ndim),
-      Context::Create(static_cast<Context::DeviceType>(dev_type), dev_id),
-      delay_alloc != 0,
-      dtype);
+  CreateNDArray<mx_uint, mx_uint>(shape, ndim, dev_type, dev_id, delay_alloc, dtype, out);
   API_END();
 }
 
@@ -558,7 +559,7 @@ int MXNDArrayGetShape(NDArrayHandle handle,
 
 template<typename dtype>
 inline void GetShape(NDArrayHandle handle, const dtype** out_pdata, int* out_dim,
-              MXAPIThreadLocalEntry<dtype>* ret) {
+                     MXAPIThreadLocalEntry<dtype>* ret) {
   NDArray* arr = static_cast<NDArray*>(handle);
   if (!arr->is_none()) {
     mxnet::TShape s = arr->shape();
@@ -590,9 +591,9 @@ int MXNDArrayGetShapeEx(NDArrayHandle handle,
   API_END();
 }
 
-int MXNDArrayGetShapeExInt64(NDArrayHandle handle,
-                             int *out_dim,
-                             const mx_int64 **out_pdata) {
+int MXNDArrayGetShapeEx64(NDArrayHandle handle,
+                          int *out_dim,
+                          const mx_int64 **out_pdata) {
   MXAPIThreadLocalEntry<int64_t> *ret = MXAPIThreadLocalStore<int64_t>::Get();
   API_BEGIN();
   GetShape<mx_int64>(handle, out_pdata, out_dim, ret);