[MPMD-411] Implement getOutputPath and identify getOutputName as deprecated, (#179)

Author: elharo

src/main/java/org/apache/maven/plugins/pmd/CpdReport.java

@@ -210,7 +210,14 @@ private void executeCpd() throws MavenReportException {
     /**
      * {@inheritDoc}
      */
+    @Override
+    @Deprecated
     public String getOutputName() {
         return "cpd";
     }
+
+    @Override
+    public String getOutputPath() {
+        return "cpd";
+    }
 }

src/main/java/org/apache/maven/plugins/pmd/PmdReport.java

@@ -543,10 +543,16 @@ private String determineAuxClasspath() throws MavenReportException {
      * {@inheritDoc}
      */
     @Override
+    @Deprecated
     public String getOutputName() {
         return "pmd";
     }
 
+    @Override
+    public String getOutputPath() {
+        return "pmd";
+    }
+
     /**
      * Create and return the correct renderer for the output type.
      *

src/test/java/org/apache/maven/plugins/pmd/AbstractPmdReportTestCase.java

@@ -141,7 +141,7 @@ protected File generateReport(AbstractPmdReport mojo, File pluginXmlFile) throws
         testMavenProject = builder.build(pluginXmlFile, buildingRequest).getProject();
 
         File outputDir = mojo.getReportOutputDirectory();
-        String filename = mojo.getOutputName() + ".html";
+        String filename = mojo.getOutputPath() + ".html";
 
         return new File(outputDir, filename);
     }

src/test/java/org/apache/maven/plugins/pmd/CpdReportTest.java

@@ -182,7 +182,9 @@ public void testSkipEmptyReportConfiguration() throws Exception {
     public void testEmptyReportConfiguration() throws Exception {
         // verify the generated files do exist, even if there are no violations
         File generatedReport = generateReport(getGoal(), "empty-report/cpd-empty-report-plugin-config.xml");
-        assertTrue(new File(generatedReport.getAbsolutePath()).exists());
+        assertTrue(
+                generatedReport.getAbsolutePath() + " does not exist",
+                new File(generatedReport.getAbsolutePath()).exists());
 
         String str = readFile(generatedReport);
         assertFalse(lowerCaseContains(str, "Hello.java"));