Skip to content

Commit 427b213

Browse files
[MENFORCER-473] Notice about max JDK in custom rules
1 parent 6feac61 commit 427b213

File tree

5 files changed

+10
-17
lines changed

5 files changed

+10
-17
lines changed

enforcer-api/pom.xml

-9
Original file line numberDiff line numberDiff line change
@@ -97,15 +97,6 @@
9797
</execution>
9898
</executions>
9999
</plugin>
100-
<plugin>
101-
<groupId>org.apache.maven.plugins</groupId>
102-
<artifactId>maven-site-plugin</artifactId>
103-
<configuration>
104-
<attributes>
105-
<mavenPrerequisite>${maven.version}</mavenPrerequisite>
106-
</attributes>
107-
</configuration>
108-
</plugin>
109100
</plugins>
110101
</build>
111102
</project>

enforcer-api/src/custom-rule-sample/pom.xml

+3-3
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@
3333

3434
<properties>
3535
<api.version>${project.version}</api.version>
36-
<maven.version>${maven.version}</maven.version>
37-
<!-- use JDK 1.8 at least -->
36+
<mavenVersion>${mavenVersion}</mavenVersion>
37+
<!-- use JDK 1.8 or 11 -->
3838
<maven.compiler.source>1.8</maven.compiler.source>
3939
<maven.compiler.target>1.8</maven.compiler.target>
4040
</properties>
@@ -49,7 +49,7 @@
4949
<dependency>
5050
<groupId>org.apache.maven</groupId>
5151
<artifactId>maven-core</artifactId>
52-
<version>\${maven.version}</version>
52+
<version>\${mavenVersion}</version>
5353
<scope>provided</scope>
5454
</dependency>
5555
<dependency>

enforcer-api/src/site/apt/writing-a-custom-rule.apt.vm

+2
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ Writing a custom rule
3636

3737
%{snippet|id=project-pom|file=enforcer-api/target/custom-rule-sample/pom.xml}
3838

39+
Target bytecode version of rule must be <<<1.8>>> or <<<11>>> - due to {{{https://issues.apache.org/jira/browse/MENFORCER-473}MENFORCER-473}}.
40+
3941
Note that the classloader is shared with the embedding <<<maven-enforcer-plugin>>> (a regular {{{https://maven.apache.org/guides/mini/guide-maven-classloading.html#Plugin_Classloaders}plugin classloader}})
4042
and therefore the artifacts <<<org.apache.maven.enforcer:enforcer-api>>> are always loaded in the same version as the embedding <<<maven-enforcer-plugin>>>.
4143

maven-enforcer-plugin/pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
<description>The Loving Iron Fist of Maven</description>
3636

3737
<prerequisites>
38-
<maven>${maven.version}</maven>
38+
<maven>${mavenVersion}</maven>
3939
</prerequisites>
4040

4141
<dependencies>

pom.xml

+4-4
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777
</distributionManagement>
7878

7979
<properties>
80-
<maven.version>3.2.5</maven.version>
80+
<mavenVersion>3.2.5</mavenVersion>
8181
<maven.site.path>enforcer-archives/enforcer-LATEST</maven.site.path>
8282
<javaVersion>8</javaVersion>
8383
<mockito.version>4.11.0</mockito.version>
@@ -111,19 +111,19 @@
111111
<dependency>
112112
<groupId>org.apache.maven</groupId>
113113
<artifactId>maven-artifact</artifactId>
114-
<version>${maven.version}</version>
114+
<version>${mavenVersion}</version>
115115
<scope>provided</scope>
116116
</dependency>
117117
<dependency>
118118
<groupId>org.apache.maven</groupId>
119119
<artifactId>maven-plugin-api</artifactId>
120-
<version>${maven.version}</version>
120+
<version>${mavenVersion}</version>
121121
<scope>provided</scope>
122122
</dependency>
123123
<dependency>
124124
<groupId>org.apache.maven</groupId>
125125
<artifactId>maven-core</artifactId>
126-
<version>${maven.version}</version>
126+
<version>${mavenVersion}</version>
127127
<scope>provided</scope>
128128
</dependency>
129129
<dependency>

0 commit comments

Comments
 (0)